annoying little problem

[Anon]

I've written some code that queries a half life gameserver and returns the number of players and the current map. This works pretty well except one rather annoying bug: There are circumstances under which the server will accept the connection, but will never send anything - like inbetween map changes, or if it gets started with an invalid map name. This means that my script just sits there waiting for a line of data that it never gets.

This is the relavent code. If anyone has any suggestions, i'd love to hear them:

$fp = fsockopen ("udp://$ip", $port, &$errno, &$errstr, 2);
if (!$fp) {
return "Could't connect to $ip";
$getgsfailed=1;
break;
} else {
fwrite($fp, "ÿÿÿÿinfo\n");
$serveroutput=fread($fp, 1);
socket_set_blocking($fp, 0);
$serveroutput.=fread($fp, 4096);
fclose($fp);
}

I have tried adding while(!feof($fp)) to the fread line, but if i do that it gets stuck in the while loop. I can only assume it never sends an EOF. I've also tried reducing the length parameter but that makes no difference either.

[Anon]

Try setting the socket to non-blocking before any fread()s:

socket_set_blocking($fp, 0);
$serveroutput=fread($fp, 1);
$serveroutput.=fread($fp, 4096);

Diego

[Anon]

Actually, use fgets() instead. Because even if the socket is non-blocking, fread will try to read 1 or 4096 bytes anyway and it will wait for it. So try using fgets().

Diego

[Anon]

well, it's alread non-blocking and it's binary so you need to use fread 🙂

but thanks for the suggestions. I just figured it out:

$break=0;
while(!$break){
$char=fread($fp, 1);
$serveroutput.=$char;
if($char=="\x01") $break=1;
}