updating a table row

[Anon]

I have a form which displays all the data of a user in question in textboxes etc, which can be edited. The page derives from taking all the info from a table called "mh_users" where the user_id row is for example 21.

The problem is that the MySQL database does not update the table at all... It may be because the php is not telling the database to which row to change.

Can any one help?

My code that doesn't work:

if ($submit) {
$sql_update = "update mh_users set user_id='$user_id', first_name='first_name', last_name='last_name', sex='$sex', dob='$dob', user_email=$user_email, activated='$activated', notes='$notes'"; }

Any ideas?

[Anon]

Yea mysql doesn't know which table to update!
You need the "where" clause in the sql query like so:

if ($submit) {
$sql_update = "update mh_users set user_id='$user_id', first_name='first_name', last_name='last_name', sex='$sex', dob='$dob', user_email=$user_email, activated='$activated', notes='$notes' where user_id='$user_id'"; }

[Anon]

After the info is displayed on the form I think the $user_id variable is lost from the browser memory! Therefore its can't update the table 🙁
Any ideas??

I think your where clause method is correct though.

[Anon]

<?
$pagetitle = "Edit User";
include_once('admheader.inc.php');
include_once('../config.php');

$sql_select = "select * from mh_users where user_id ='$user_id'";
if ($debug) { print("$sql_select");}
$result = mysql_query ($sql_select);

  while ($row = mysql_fetch_array($result))
  {
      $user_id = $row["user_id"];
      $first_name = $row["first_name"];
      $last_name = $row["last_name"];
      $dob_day = substr($row["dob"],6,2);
	  $dob_month = substr($row["dob"],4,2);
	  $dob_year = substr($row["dob"],0,4);
	  $sex = $row["sex"];
      $user_email = $row["user_email"];
      $reg_date = $row["reg_date"];
	  $activated = $row["activated"];
	  $reg_year=substr($row["reg_date"],0,4);
      $reg_month=substr($row["reg_date"],4,2);
      $reg_day=substr($row["reg_date"],6,2);
	  $notes=$row["notes"];

	  // if notes is empty diplay nothing (instead of 0)
	  if (empty($notes)){$notes="";}

   }

if (!$submit) {
print "<p>Our database holds the following information about $first_name $last_name.</p><blockquote>Below you may edit his/her profile ban users and reactivate already banned users.</blockquote>";

if ($activated== '0')
{
$status = "Awaiting activation";
}
if ($activated== '1')
{
$status = "Active";
}

?>
<form name="edit_user" method="post" action="edit_user.php">
<table width="400" border="1" cellspacing="0" cellpadding="0" bordercolor="#98BEDE" align="center">
<tr bgcolor="#98BEDE">
<td><b><font size="4">User Profile</font></b>
<table width="400" border="0" cellspacing="1" cellpadding="4" align="center">
<tr bgcolor="#DCEAF5">
<td width="200"><b>First name: </b></td>
<td width="200">
<input type="text" class="textbox" name="first_name" maxlength="25" value="<? echo"$first_name";?>">
</td>
</tr>
<tr bgcolor="#CADEEE">
<td width="200"><b>Last name: </b></td>
<td width="200">
<input type="text" class="textbox" name="last_name" maxlength="25" value="<? echo"$last_name";?>">
</td>
</tr>
<tr bgcolor="#DCEAF5">
<td width="200"><b>Sex: </b></td>
<td width="200">
<select name="sex" class="textbox">
<? if ($sex =="M") {?>
<option value="<?echo $sex?>" selected>Male</option>
<option value="F">Female</option><? }
if ($sex =="F") {?>
<option value="<?echo $sex?>" selected>Female</option>
<option value="M">Male</option><? }?>

      </td>
    </tr>
    <tr bgcolor="#CADEEE"> 
      <td width="200"><b>DOB: </b></td>
      <td width="200">
	  <input type="text" class="textbox" name="dob" maxlength="8" size="8" value="<? echo"$dob_day$dob_month$dob_year";?>"><br>
        <?print "<font size='1'>Format: DDMMYYYY</font>"?>
      </td>
    </tr>
	<tr bgcolor="#DCEAF5"> 
      <td width="200"><b>Email address: </b></td>
      <td width="200">
	  <input type="text" class="textbox" name="user_email" maxlength="25" value="<? echo"$user_email";?>" 
    </td>
    </tr>
    <tr bgcolor="#CADEEE"> 
      <td width="200"><b>Registration Date: </b></td>
      <td width="200"> 
        <?print "$reg_day-$reg_month-$reg_year"?>
      </td>
    </tr>
    <tr bgcolor="#DCEAF5"> 
      <td width="200"><b>Account status:</b> </td>
      <td width="200">
	  <?if ($activated ==0){
		  print "Awaiting activation"; }
		else { ?>
	  <select name="activated" class="textbox">
            <? if ($activated ==1) {?>
			<option value="<?echo $activated?>" selected>Active</option>
			<option value=2>Ban User</option></select><br>
			<font size="1">Use this option to ban users</font><? }
			if ($activated ==2) {?>
			<option value="<?echo $activated?>" selected>Banned</option>
			<option value=1>Re-Activate</option></select><br>
			<font size="1">Use this option to reactivate banned users</font><?}}?>
      </td>
    </tr>
	<tr bgcolor="#CADEEE"> 
      <td width="200"><b>User notes:</b><br><font size="1">Here you may store any notes concerning this user. For example why their account may be banned.</font></td>
      <td width="200"><textarea name="notes" class="textbox" cols="45" rows="4"><?echo "$notes"?></textarea></td></tr>
  <tr bgcolor="#DCEAF5"> 
      <td width="200"></td>
      <td width="200"><input type="submit" class="submit" name="submit" value="Save Changes"></td></tr>
 </table>
</td>

</tr>
</table>
</form>
<p align="center"><a href = "javascript:history.back()">Return to previous page</a></p>
<?
}
if ($submit) {
$sql_update = "update perscriptions set user_id='$user_id', first_name='first_name', last_name='last_name', sex='$sex', dob='$dob', user_email=$user_email, activated='$activated', notes='$notes' where user_id='$user_id'";
print "<p>User profile has been updated successfully</p>"; }

include_once('admfooter.inc.php');
?>

[Anon]

yea your user_id gets lost because you are not passing it through the form!
You need to pass it as a hidden field, put it before the submit field like so:

<input type="hidden" name="user_id" value="<? echo $user_id; ?>">
<input type="submit" class="submit" name="submit" value="Save Changes">

[Anon]

Thanks but that doesn't work, annoyingly.

I've tried thist, but it does n't work either...

<form name="edit_user" method="post" action="edit_user.php?user_id='<? echo $user_id; ?>'">

[Anon]

I think you are missing single quotes in your query around

user_email=$user_email,

should be:

user_email='$user_email',

try that!