putting image dir contents into array

Anon

Hi,

I am wanting to copy all the filenames from the image directory (minus the ".jpg") into an array and then replace any occurances of the filename in the document with <a href="image name".jpg>image name</a>

I just cannot get it to work, here's my code:

if ($id == "14") {
$dir = opendir("./images/pics");
$file = array ();
$file = readdir($dir);
while ($file=readdir($dir)) {
if ($file != "." && $file !="..") {
$arcount = count ($file);
$i = 0;
while($i != $arcount) {
substr("$file", 0, -4);
// remove .jpg from the filename
$badStr = "$file";
$goodStr = "/<a href=\"javascript:launchwin('/images/pics/$file.jpg','newwindow',left=22,top=22,scrollbars=yes')\">$file</a>/";
$MyStr = str_replace($badStr, $goodStr, $MyStr);
next($file);
$i++;
}
}
}
closedir($dir);
}
print $MyStr;

Anon

I notice you're not storing the filenames anywhere - the name that's going into $file keeps getting replaced every time you readdir() another one.

$dir=opendir("./images/pics");
$file=array();
while($onefile=readdir($dir)){
if($onefile!='.' && $onefile!='..')
$file[]=$onefile;
}
closedir($dir);

$arcount=count($file);
for($i=0;$i<$arcount)
{ echo $file[$i].'<br>'; //Obviously you want to do more here.
}

Anon

I'm pretty new to PHP, so don't flame me if I slip something up 🙂

Your 4th line isn't necessary because you do the same thing in your while loop. But it seems like you treat $file as an array; it's a string. So the 3rd line doesn't do anything (you reassign $file later, which overwrites the array), and the 7th line just returns 1, which isn't good for much. You also don't need lines 8, 9 and 18, 16, or 17. On line 10, the substr function returns a string; that string should be assigned to a variable to be used later. I'd suggest putting line 12 before line 10 and assigning the value of the function of line 10 to $file. I assume you have some Javascript function launchwindow defined elsewhere. But I think the last argument should have an opening quote. Then, I think it should all work.

Here's your code with my modifications:

if ($id == "14") {
$path = 'test';
$dir = opendir($path);
while ($file=readdir($dir)) {
if ($file != "." && $file !="..") {
$badStr = "$file";
$file = substr("$file", 0, -4);
$goodStr = "/<a href=\"javascript:launchwin('$path/$file.jpg','newwindow','left=22,top=22,scrollbars=yes')\">$file</a>/";
$MyStr = str_replace($badStr, $goodStr, $MyStr);
}
}
closedir($dir);
}
print $MyStr;