need help!

tailorn

ive created a registration form, but at present even if no information is entered into the form and submitted, the form still submits to the database, i need to insert some kind of error message.

can anyone help?

here is my script:

<body>
<H1><center>REGISTRATION FORM</H1><hr>
<h2>Please insert your details!</h2>
<h2>All text fields must be completed, before submitting!</h2>
<?php

if ($submit=="SUBMIT FORM") {

// process form
$db = mysql_connect("localhost", "root");
mysql_select_db("Football",$db);
$sql = "INSERT INTO members (username,password,firstname,lastname,address,postcode,country,emailaddress,telno) VALUES ('$username','$password','first','$last','$address','$postcode','$country','$emailaddress','$telno')";

$result = mysql_query($sql);

echo "THANK YOU!\n";
echo "YOUR DETAILS HAVE BEEN SUCCESSFULLY SUBMITTED! YOU ARE NOW A MEMBER\n"; }

else{

Username: <input type="Text" name="username"><center>
<br>
Password: <input type="Text" name="password"><center>
<br>
First name: <input type="Text" name="first"><center>
<br>
Last name: <input type="Text" name="last"><center>
<br>
Address: <input type="Text" name="address"><center>
<br>
Postcode: <input type="Text" name="postcode"><center>
<br>
Country: <input type="Text" name="country"><center>
<br>
Email Address: <input type="Text" name="emailaddress"><center>
<br>
Tel No: <input type="Text" name="telno"><center>
<br> <br>
<input type="Submit" name="submit" value="SUBMIT FORM">
</form>

<?php } ?>

mmilano

The logic here is a little different, but give it a try. Try not to mix up your regular html with php too much. If you have an "if/else " statement, everything after the else { has to still be within the php tags. it's not much extra work really.. all you have to do is type echo ""; .. and escape your quotes...

this should work .. i haven't tested it though:

<body>
<H1><center>REGISTRATION FORM</H1><hr>
<h2>Please insert your details!</h2>
<h2>All text fields must be completed, before submitting!</h2>

if ($submit=="SUBMIT FORM") {

if(!($username)){
$error="Username Blank<br>";
}
if(!($password)){
$error="$error Password Blank<br>";
}
if(!($first)){
$error="$error First Name Blank<br>";
}
if(!($last)){
$error="$error Last Name Blank<br>";
}
if(!($address)){
$error="$error Address Blank<br>";
}
if(!($paostcode)){
$error="$error Post Code Blank<br>";
}
if(!($country)){
$error="$error Country Blank<br>";
}
if(!($email)){
$error="$error Email Blank<br>";
}
if(!($telno)){
$error="$error Telephone Number Blank<br>";
}

if(!($error)){

$result = mysql_query($sql);

echo "THANK YOU!\n";
echo "YOUR DETAILS HAVE BEEN SUCCESSFULLY SUBMITTED! YOU ARE NOW A MEMBER\n <br><br><a href =\"main.php\">BACK TO MAIN PAGE</a> </body> ";
exit;

}

if($error){
echo "The following errors have occured:<br>$error<br><br>";
}

echo "<form method=\"post\" action=$PHP_SELF>

Username: <input type=\"Text\" name=\"username\"><center>
<br>
Password: <input type=\"Text\" name=\"password\"><center>
<br>
First name: <input type=\"Text\" name=\"first\"><center>
<br>
Last name: <input type=\"Text\" name=\"last\"><center>
<br>
Address: <input type=\"Text\" name="\address\"><center>
<br>
Postcode: <input type=\"Text\" name=\"postcode\"><center>
<br>
Country: <input type=\"Text\" name=\"country\"><center>
<br>
Email Address: <input type=\"Text\" name=\"emailaddress\"><center>
<br>
Tel No: <input type=\"Text\" name="telno"><center>
<br> <br>
<input type=\"Submit\" name=\"submit\" value=\"SUBMIT FORM\">
</form>

<a href =\"main.php\">BACK TO MAIN PAGE</a>
</body>";

good luck,
-mike

[deleted]

another way to validate is:

if (strlen(trim($variable))==0)
{
$error=true;
}

or if you have a select box try this:
<option value='x'>Select One</option>
if (trim($variable)=="x")
{
$error=true;
}

or radio buttons and checkboxes:
if (!isset($variable))
{
$error=true;
}

I agree with Mike, and like to echo out all html and escape to php.

carlosa69

That won't work I don't think. First off just to simplify things you can simplify the queries to !$variable insteado of !($variable.) Secondly I think if the form is blank it stores the variable as '' and it is defined! This means that you will have to do something lik this:
if($submit=="SUBMIT FORM")
{
if($variable=='' || !$variable)
{
echo "error message for this variable";
}
.
.
.
}

hope this helps, carlos

mmilano

carlose wrote"First off just to simplify things you can simplify the queries to !$variable insteado of !($variable.) "

-- ok, he has a point there, the way i wrote will work, but this will save you 2 characters... but both ways will work.

carlos also wrote "Secondly I think if the form is blank it stores the variable as '' and it is defined!"

-- carlos ... you should have tried it before you posted your second thought. i just tested that theory with the code below are your line of thinking, although somewhat logical, is wrong.

<?
if(!($name)){
echo "no name";
} else {
echo "$name";
}
echo "<form method=post action=$PHP_SELF>
<input type=text name=name>
<input type=submit name=submit>
</form>";
?>

-mike

tailorn

thanx for the sugguestion mike, i tried to run your script but it came out with some errors

mmilano

what line?

mmilano

i missed a "}" after the "exit;"

here, i formated this one for you, it will look a little nicer. i tested it and it works fine... except your db query.. i don't know if that works cause i'm not connected to your db.

<body>
<H1><center>REGISTRATION FORM</H1><hr>
<h2>Please insert your details!</h2>
<h2>All text fields must be completed, before submitting!</h2>

if ($submit) {

if(!($username)){
$error="<li> Username Blank";
}
if(!($password)){
$error="$error <li> Password Blank";
}
if(!($first)){
$error="$error <li> First Name Blank";
}
if(!($last)){
$error="$error <li> Last Name Blank";
}
if(!($address)){
$error="$error <li> Address Blank";
}
if(!($postcode)){
$error="$error <li> Post Code Blank";
}
if(!($country)){
$error="$error <li> Country Blank";
}
if(!($emailaddress)){
$error="$error <li> Email Blank";
}
if(!($telno)){
$error="$error <li> Telephone Number Blank";
}

if(!($error)){

VALUES('$username','$password','first','$last','$address','$postcode','$country','$emailaddress','$telno')";

$result = mysql_query($sql);

echo "THANK YOU!\n";
echo "YOUR DETAILS HAVE BEEN SUCCESSFULLY SUBMITTED! YOU ARE NOW A MEMBER\n <br><br><a href =\"main.php\">BACK TO MAIN

PAGE</a> </body> ";
exit;

} }

echo "<form method=post action=$PHP_SELF>

<table border=0 cellspacing=0 cellpadding=0><tr><Td width=200 valign=top>
<font face=verdana size=1 color=red>$error</font></td>

<table border=0 cellspacing=0 cellpadding=0>
<tr><td align=right>
Username: </td><td> <input type=Text name=username></td></tr>
<tr><td align=right>
Password: </td><td> <input type=Text name=password></td></tr>
<tr><td align=right>
First name: </td><td> <input type=Text name=first></td></tr>
<tr><td align=right>
Last name: </td><td> <input type=Text name=last></td></tr>
<tr><td align=right>
Address: </td><td> <input type=Text name=address></td></tr>
<tr><td align=right>
Postcode: </td><td> <input type=Text name=postcode></td></tr>
<tr><td align=right>
Country: </td><td> <input type=Text name=country></td></tr>
<tr><td align=right>
Email Address: </td><td> <input type=Text name=emailaddress></td></tr>
<tr><td align=right>
Tel No: </td><td> <input type=Text name=telno></td></tr>
<tr><td colspan=2 align=right><br>
<input type=Submit name=submit value=\"SUBMIT FORM\">
</td></tr></table>

</td></tr></table>
</form>

<a href =\"main.php\">BACK TO MAIN PAGE</a></body>";

hope this helps.
-mike

mmilano

doh! the forums are formatting certain characters...

everywhere where you see a <li> , replace that will <.li.> (without the "."

and also, i put a font tag around the red error. it was just to make the errors show up in red.

Anon

instead of using php to show the errors ..use javascript validations for your form
so that you will remove this unneccesary load to the server!...