My SQL error in my syntax?

Anon

Arrgh. I've been staring at this forever, trying to figure it out, and it's just not working. I'm getting the following error:

You have an error in your SQL syntax near ''categoryid, character') VALUES ('1', 'dsafds')' at line 1

This is not the entire function, just the relevant part:

if($submit){
	mysql_query("INSERT INTO ".$prefix."_fanfiction_characters (categoryid, character) VALUES ('$categoryid', '$character')") or (die(mysql_error()));
	echo "$categoryid, $character";
	echo "Your character has been added.";

If I remove the or die statement, than the echoing of my variables works fine, so the data is getting sent through when submit is pressed (didn't include that part of my code, but $submit is defined elsewhere). Do you see anything glaringly wrong with my sql query? Here's the table that I'm trying to insert into:

Field Type Attributes Null Default Extra
characterid int(11) No auto_increment
categoryid int(11) No 1

character varchar(30) No

Anon

try not inserting into categoryid if it's an autoincrement.... autoincrements increment automatically so there's no need to put anything in there.

Anon

Categoryid is not an autoincrement, though. Characterid is the autoincrement, and I'm not inserting that...

carlosa69

try mysql_query("INSERT INTO ".$prefix."_fanfiction_characters (categoryid, character) VALUES ('$categoryid', '$character');")
I added the ";" just inside the quotes. I forgot when you do and when you don't have to include them, but this might be your problem,

carlos

Anon

No good; it just gave me a parse error. Thanks for the suggestion, though...

frymaster

sorry, not paying full attention.

what about $prefix. is it setting right? attempting to insert into a table that doesn't have those cols could happen if that value is wrong.

just a shot in the dark...

Anon

That's a good guess, but no, $prefix is a global. Shouldn't be having a problem with that. There must be something really obvious that I'm missing. What's driving me crazy is that I used this exact same function several other times with no problems in other places in my script, so what it's problem is now, I don't know...

Anon

Don't believe there is an error in your syntax. However, your 3rd column character is a SQL92 reserved word (Section below is from manual)

"The following words are explicitly reserved in MySQL. Most of them are forbidden by ANSI SQL92 as column and/or table names (for example, group). A few are reserved because MySQL needs them and is (currently) using a yacc parser:"

I couldn't actually create your table using character as a field name.

This may well be the problem as mysql is v. fussy about this sort of thing.

Just an idea.

Justin

Anon

Thank you so much, that was the problem. Does a happy Snoopy dance

Anon

Your welcome.