form error

tailorn

I still seem to be getting an error with this script.

The error is a parse error on line 56.

can anyone help, its driving me crazy!!!!!

here is the script:

<body>
<H1><center>REGISTRATION FORM</H1><hr>
<h2>Please insert your details!</h2>
<h2>All text fields must be completed, before submitting!</h2>

<?
if ($submit=="SUBMIT FORM") {

if(!($username)){
$error="Username Blank<br>";
}
if(!($password)){
$error="$error Password Blank<br>";
}
if(!($first)){
$error="$error First Name Blank<br>";
}
if(!($last)){
$error="$error Last Name Blank<br>";
}
if(!($address)){
$error="$error Address Blank<br>";
}
if(!($paostcode)){
$error="$error Post Code Blank<br>";
}
if(!($country)){
$error="$error Country Blank<br>";
}
if(!($email)){
$error="$error Email Blank<br>";
}
if(!($telno)){
$error="$error Telephone Number Blank<br>";
}

if(!($error)){

// process form
$db = mysql_connect("localhost", "root");
mysql_select_db("Football",$db);
$sql = "INSERT INTO members (username,password,firstname,lastname,address,postcode,country,emailaddress,telno) VALUES ('$username','$password','first','$last','$address','$postcode','$country','$emailaddress','$telno')";

$result = mysql_query($sql);

echo "THANK YOU!\n";
echo "YOUR DETAILS HAVE BEEN SUCCESSFULLY SUBMITTED! YOU ARE NOW A MEMBER\n <br><br><a href =\"main.php\">BACK TO MAIN PAGE</a> </body> ";
exit;

}

if($error){
echo "The following errors have occured:<br>$error<br><br>";
}

<form method="post" action="<?php echo $PHP_SELF?>">
<br>
Username: <input type="Text" name="username"><center>
<br>
Password: <input type="Text" name="password"><center>
<br>
First name: <input type="Text" name="first"><center>
<br>
Last name: <input type="Text" name="last"><center>
<br>
Address: <input type="Text" name="address"><center>
<br>
Postcode: <input type="Text" name="postcode"><center>
<br>
Country: <input type="Text" name="country"><center>
<br>
Email Address: <input type="Text" name="emailaddress"><center>
<br>
Tel No: <input type="Text" name="telno"><center>
<br> <br>
<input type="Submit" name="submit" value="SUBMIT FORM">
</form>
?>

Anon

Your problem is just after the if($error) bit. When you print out the form and set the action to it.. you're opening the php tags within php tags.

I think that's your problem.

~~Stezz

Anon

Close the opening <? of php code on line 55 (?>) and delete from the end.
Chewu

tailorn

thanx for that solomon, i corrected that, and ran the script again. it not states an error on line 86.

Anon

Where is the clossing bracket for:

if ($submit=="SUBMIT FORM") {

if you have to close at the end, do like this
<?
}
?>

tailorn

ok i have done that, it seems to be kind of working now, but when i run it, the page displays the error messages, for example:

The following errors have occured:
Password Blank
First Name Blank
Last Name Blank
Address Blank
Post Code Blank
Country Blank
Email Blank
Telephone Number Blank

Anon

Look at this Script. It may help you some what. If you have any question about it, you are welcome!!!!!!

<body>
<H1><center>REGISTRATION FORM</H1><hr>
<h2>Please insert your details!</h2>
<h2>All text fields must be completed, before submitting!</h2>
<?
function CreateForm($username, $password, $first, $last, $last, $address, $postcode, $country, $email, $telno)
{
echo "<form method=post action= wrong.php><br>";
echo "Username: <input type=Text name=username value=$username><center><br>";
echo "Password: <input type=password name=password><center><br>";
echo "First name: <input type=Text name=first value=$first><center><br>";
echo "Last name: <input type=Text name=last value=$last><center><br>";
echo "Address: <input type=Text name=address value=$address><center><br>";
echo "Postcode: <input type=Text name=postcode value=$postcode><center><br>";
echo "Country: <input type=Text name=country value=$country><center><br>";
echo "Email Address: <input type=Text name=email value0$email><center><br>";
echo "Tel No: <input type=Text name=telno value=$telno><center><br><br>";
echo "<input type=Submit name=submit value='SUBMIT FORM'>";
echo "</form>";
}
CreateForm($username, $password, $first, $last, $last, $address, $postcode, $country, $email, $telno);

if (isset($submit)) {
if($username == "" or $password == "" or $first == "" or $last == "" or $address == "" or
$postcode == "" or $country == "" or $email == "" or $telno == "") {
echo "<h2><font color=red>Please enter all necessary Information!!! </font></h2>";
CreateForm($username, $password, $first, $last, $last, $address, $postcode, $country, $email, $telno);
}
else if(!eregi("^{[a-zA-Z0-9_-]+@[a-zA-Z0-9-_]+.[a-zA-Z0-9-.]+$",} $email))
{
echo "<h2><font color='red'>Please enter Valid Email Address";
echo "</font></h2>";
CreateForm($username, $password, $first, $last, $last, $address, $postcode, $country, $email, $telno);
}
else if(!eregi("[0-9-]", $telno))
{
echo "<h2><font color='red'>Please enter Valid Telephone ";
echo "Number</font></h2>";
CreateForm($username, $password, $first, $last, $last, $address, $postcode, $country, $email, $telno);
}
else if(!eregi("[A-Za-z]", $first))
{
echo "<h2><font color='red'>Please enter Valid First Name</font></h2>";
CreateForm($username, $password, $first, $last, $last, $address, $postcode, $country, $email, $telno);
}
else if(!eregi("[A-Za-z]", $last))
{
echo "<h2><font color='red'>Please enter Valid Last Name</font></h2>";
CreateForm($username, $password, $first, $last, $last, $address, $postcode, $country, $email, $telno);
}

// you can continue controlling the other fields like this if you want.....
else {
// check weather a username and password are already in your database or not
$db = mysql_connect("localhost", "root");
mysql_select_db("Football",$db);
$query = "select * from members where username like '$username' and password like '$password'";
$result = mysql_query($query);
$count = mysql_num_rows($result);
if($count > 0) { // it is already in the database & display the form to choose another un & pw
echo "This user name is already chosen by somebody, please enter another.....";
CreateForm($username, $password, $first, $last, $last, $address, $postcode, $country, $email, $telno);
}
else {
$db = mysql_connect("localhost", "root");
mysql_select_db("Football",$db);
$sql = "INSERT INTO members (username,password,firstname,lastname,address,postcode,country,emailaddress,telno) VALUES ('$username','$password','first','$last','$address','$postcode','$country','$emailaddress','$telno')";
$result = mysql_query($sql);
echo "THANK YOU!\n";
echo "YOUR DETAILS HAVE BEEN SUCCESSFULLY SUBMITTED! YOU ARE NOW A MEMBER\n <br><br><a href =\"main.php\">BACK TO MAIN PAGE</a> </body>";
exit;
}
}
}
?>
<a href ="main.php">BACK TO MAIN PAGE</a>

tailorn

WOW, what a script, it seems more complex to my script.i do understand bits of it, but id rather carry on with the current one, thanx for it anyway.

i cant seem to understand, why im getting this problem still though.

here is my script:

<body>
<H1><center>REGISTRATION FORM</H1><hr>
<h2>Please insert your details!</h2>
<h2>All text fields must be completed, before submitting!</h2>

<?
if ($submit=="SUBMIT FORM") {
}
if(!($username)){
$error="Username Blank<br>";
}
if(!($password)){
$error="$error Password Blank<br>";
}
if(!($first)){
$error="$error First Name Blank<br>";
}
if(!($last)){
$error="$error Last Name Blank<br>";
}
if(!($address)){
$error="$error Address Blank<br>";
}
if(!($paostcode)){
$error="$error Post Code Blank<br>";
}
if(!($country)){
$error="$error Country Blank<br>";
}
if(!($email)){
$error="$error Email Blank<br>";
}
if(!($telno)){
$error="$error Telephone Number Blank<br>";
}

if(!($error)){

$result = mysql_query($sql);

echo "THANK YOU!\n";
echo "YOUR DETAILS HAVE BEEN SUCCESSFULLY SUBMITTED! YOU ARE NOW A MEMBER\n <br><br><a href =\"main.php\">BACK TO MAIN PAGE</a> </body> ";
exit;

}

if($error){
echo "The following errors have occured:<br>$error<br><br>";
}

</body>

Anon

Sorry for sending you complex Script. But it is very simple Script.

If some body enters wrong email address, for example 'dgshsjhddjjf', how do you control it?

Or wrong telefon number like 88gggaaaa?

.....

tailorn

yea, you are right, i do see your point.

you know the script you sent me, did you test it yourself? because i tested it, but i dont think it was all working