PHP, javascript mix

Anon

I have a php page with javascript displaying php variable using alert. I am getting syntax error and not sure why.
The code is:
case "copyas":
// This code inserted by SS for confirming the copy before updating
echo "<script Language=\"JavaScript\" Type=\"text/javascript\">\n";
echo "<!--\n";
echo "var x=confirm('Do you want to copy from $copyfrom to $copyto');";
echo "if (!x);";
echo "window.location.href = 'http://www.contactsready.com/per_mod.php?op=$frompage';";
echo "else;";
echo "<?php copyas($uname,$frompage,$copyfrom,$copyto);?>;";
echo "end;";

echo "//-->\n";
echo "</script>\n";

I am getting a syntax error in the winow.location..... line.

note: $copyfrom and $copyto are php variables. copyas is a php function.

Please help
Sridhar

Anon

Looks like some extra semicolons on this line andafter the "else" that follows:

echo "if (!x);";

jesus_hairdo

i think that your if and else statements should need an ; echoing after them.
so you should have,
echo "if (!x)";
...
echo "else";
....

Jamie

Anon

Still I am getting the same error.

Please help

Thanks

Anon

syntax or parse error? (i.e. javascript or php error?) If it is a javascript error, post the resulting source coce of the page and let us see that. I am going to guess that you need something like this:

...om/per_mod.php?op='".$frompage."'';";

moehome

U have to close your quotations marks before adding you PHP variable like
echo "var x=confirm('Do you want to copy from".$copyfrom." to".$copyto');"; and so on in all your script!!

greez moe

Anon

Actually the error is not on that line. Now I am trying to add another redirection line as follows to handle the problem differently but I am getting parse error on this line.
echo "window.location.href=\"http://www.1234.com/per_mod.php?op='copyok'&uname=$uname\"\n";

Please help

sridhar

Anon

Please help

sridhar