Checking each row in a table

[bike5]

I have-

$Query = "SELECT * from $TableName";
$Result = mysql_db_query ($DBName, $Query, $Link);

while ($Row = mysql_fetch_row ($Result)) {
if ($user_name == $Row[1]){
echo "YES";
} else {
echo "No";
}}

How to I keep adding 1 to the row number to check all rows. I tried $Row[user_name] (which is the name in the table for that colum) but it doesn't work right.

Im trying to check for a user name and password match, once I get it to check for a user name I think I can get it to check for the password too. Any help would be great.
Thank you.

[van__]

Danny wrote:

Im trying to check for a user name and password match, once I get it to check for a user name I think I can get it to check for the password too. Any help would be great.

Thank you.

Write a better query.
Grabbing the entire table to check for something that could be done by the database for you is wasteful.

$Query = "SELECT * from $TableName WHERE user_name='$user_name'";
$Result = mysql_db_query ($DBName, $Query, $Link);

if (@mysql_num_rows($Result)>0) {
echo "YES";
} else {
echo "No";
}

[Anon]

This can be improved still further - there's no point returning all the fields of all the matching records if you just want to know how many records match.

$Query = "SELECT count(*) from $TableName where user_name='$user_name'";
$Result = mysql_db_query($DBName, $Query, $Link);
$count=mysql_result($Result,0,0);
if($count>0)
{ echo 'YES';
}else{
{ echo 'No';
}

[van__]

True, but look at what he's checking for.
A user login is typically the time we will be grabbing data to set session_vars and other happy crap...so just returning a count would not be the ideal way to go here.

Plus, we may have been smart and encrypted the password, which would mean we'd preg_match the decrypted result to ensure the password matched.

[bike5]

When I put in

$Query = "SELECT count(*) from $TableName where user_name='$user_name'";
$Result = mysql_db_query($DBName, $Query, $Link);
if (@mysql_num_rows($Result)>0) {
echo "YES";
} else {
echo "No";
}

I get YES back every time, no matter what name I input.

[van__]

That's because mysql_num_rows is returning a row even on a no match.

try...
$Query = "SELECT count(user_name) as unique from $TableName where user_name='$user_name'";
$Result = mysql_db_query($DBName, $Query, $Link);

$data = mysql_fetch_array($Result,MYSQL_ASSOC);
if ($data['unique']>0) {
echo 'yes';
} else {
echo 'no';
}

[bike5]

I put what Grumbler put in minus the extra { he accidently put in and it worked. I added the password with it and its works. Now I need to fix it being non-casensitive because it accepts any variation of Caps and non-caps.

Thanks guys.

[van__]

MySQL searched case insensitive by defualt.
The only way aound this is to either use a LIKE or RLIKE or to change the user_name column to a binary datatype.

Read up on this issue here:
http://www.mysql.com/doc/C/a/Case_sensitivity.html

You can get rid of the count and use this statement and check the name with a regex instead:
$QUERY="SELECT user_name from $tableName where user_name='$user_name'";

$data = mysql_fetch_array($Result,MYSQL_ASSOC);
if (@mysql_num_rows($Result)>0) {
if (preg_match('/'.$data['user_name'].'/',$user_name)) {
echo "yes";
}
} else {
echo 'no';
}