Trouble with tables and parseerrors

Anon

Hello , ive been working on a script that displays entries from my sql , the script seems to works fine now but i am trying to add in a feature so that when each row of data is extracted from the array and put into the table it will have "more info" html text in the far right field that links to "info.php" to display that records information held in another table.

At the moment ive having trouble getting it even to put in teh html text link i need , any help would be greatly appreciated.

thanks

echo "<tr><td>Job ID</td><td>Job Details</td><td>Job Title</td><td>Location</td><td>Salary</td><td>Closing date</td><td>Type</td><td>info</td></tr>\n";
//start loop
do {

//write rows in the array to the screen
printf("<tr><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td></tr>\n", $myrow["JobID"],$myrow["JobDetails"],$myrow["Jobtitle"],$myrow["location"],$myrow["salary"],$myrow["closingdate"],$myrow["type"],"<a href="info.php?record=$myrow["JobID"]" info /a>");

This is the rough idea of how it should work but i know i have the syntx wrong but cant figure out how to do it.

}
//keep looping while there is still stuff there
while ($myrow = mysql_fetch_array($result));

echo "</table>\n";

Anon

First, your parse errors are coming in because you have "<a href="info.php - and PHP doesn't know what info.php means. And you mangle the end of the <a>, too.

Second, change your do{...}while(...) to just a while(...){...}. Otherwise your first row will be a bunch of blanks, 'cos $myrow[] wouldn't have any values yet.

Third, printf() is overkill for this If you're just interpolating strings in strings, either use variable interpolation, string catenation, or (since you're printing) do the HTML outside the PHP.

while($myrow=mysql_fetch_array($result)
{
echo '<tr>
<td>'.$myrow["JobID"].'</td>
<td>'.$myrow["JobDetails"].'</td>
<td>'.$myrow["Jobtitle"].'</td>
<td>'.$myrow["location"].'</td>
<td>'.$myrow["salary"].'</td>
<td>'.$myrow["closingdate"].'</td>
<td>'.$myrow["type"].'</td>
<td><a href="info.php?record='.$myrow["JobID"].'"> info </a></td>
</tr>
';
}

(I'm assuming you aren't leaving out newlines for a reason. Pack all that onto one line if you are.)

Anon

I tried the method you suggested but for some reason it still complains of a parse error , im new to php and not sure of teh syntax but i cant see anything that is immediately wrong , i get parse errors when i use echo to put in html code thats the main reason I decided to use printf.

//set reult equal to the output of the sql query
$result = mysql_query($query);

//if there is any rows to grab , grab them and put them in an array
if ($myrow = mysql_fetch_array($result)) {

while($myrow=mysql_fetch_array($result)
{ <<<< it points the parse error to here
echo'<tr>
<td>'.$myrow["JobID"].'</td>
<td>'.$myrow["JobDetails"].'</td>
<td>'.$myrow["Jobtitle"].'</td>
<td>'.$myrow["location"].'</td>
<td>'.$myrow["salary"].'</td>
<td>'.$myrow["closingdate"].'</td>
<td>'.$myrow["type"].'</td>
<td><a href="info.php?record='.$myrow["JobID"].'"> info </a></td>
</tr>';
}

} else {
//no records
echo "Sorry , no records were found!";

}

Anon

You're missing a parenthesis:

while($myrow=mysql_fetch_array($result)

should be

while($myrow=mysql_fetch_array($result))

Diego

Anon

thanks mate , looks like notepad has done my eyes in

Anon

Mea culpa, I'd missed out the parenthesis myself. Maybe I should be hitting ctrl-+ in this browser a bit more often as time wears on 🙂