Mail Function Problem

tony_l

I have constructed a Script that basically looks at the MySQL database and pulls out members that have not confirmed their membership. This Script will eventually be integrated and ran automatically with a CronTab job, but I am just testing this right now.

The problem is that my script should work, however I have never used the Mail() function before (except to test my knowledge of it). When I run the Script, it starts to load but the Script takes a LONG time and fails to execute.

I am thinking that there are too many emails to sort through for the script (there are 52 records). But I am not sure if my script has inadvertently come across an infinite loop or if I need to try something else.

Can Anyone tell me what I am doing wrong here?

// connection to DB and other code already performed //

$Query1 = "SELECT* from $TableName1 where confirm = '0'";

$Result1 = mysql_query($Query1, $Link1);

########################################################

Loop through Addresses and send Confirmation Email

########################################################

while ($Row1 = mysql_query($Query1, $Link1)) {

$body = "You have recieved this email to confirm whether or not you wish to continue your Membership.\r\n You MUST click on one of the links below or your membership will be considered INACTIVE and you will LOSE your website and forum access.\r\n I WISH TO CONTNUE MY MEMBERSHIP http://www.mysite.com/ACCESS/confirm.php?passvar=$Row1[profile_id] \r\n I DO NOT WANT TO CONTINUE MY MEMBERSHIP: http://www.mysite.com/ACCESS/confirm.php?passvar=$Row1[profile_id]\r\n Thank You for your cooperation!";

mail("$Row1[email]","Confirmation Email",$body);

}

if (mysql_db_query ($DBName, $Query1, $Link1)) {

print ("Sucessful DB connection!! ");

}

else {

print (mysql_error());

}

print ("The Confirmation Email should have been sent now");

wchris

I would do it this way:

$select = "SELECT * from $TableName1 WHERE confirm = '0'";
$result = mysql ($dbase, $select);
$num_rows = mysql_num_rows ($result);

for ($row = 0; $row < $num_rows, $row ++) {

$mail_adress = mysql_result ($result, $row, "mail_adress");
$profile_id = mysql_result ($result, $row, "id");

$body = "your text with variables";

$send = mail($mail_adress,"Confirmation Email",$body);

if ($send) {
print "eMail send successfully";
}

} // end for

And a second thing:

$db_link = $mysql_connect ($host, $duser, $dpass) or die ("Connection failed")

Perhaps better?

wchris

Could it be that your script always stays in the same row, so the ´while´ never ends?

tony_l

Well I actually figured it out, the $Row1 argument in the loop was configured wrong, I had it check for the query, not fetch array like it should have 🙁 my fault, but thank you anyways.