Problems looping through recordset

[pgosse]

Okay, here's the situation. I'm building the distributors page for a client's site, and I'm going to have a select list with all his distributors. It is to be structured as follows:

-----COUNTRY-----
---PROVINCE/STATE---
Dealer Name (City)
Dealer Name (City)
---PROVINCE/STATE---
Dealer Name (City)
-----COUNTRY-----
---PROVINCE/STATE---
Dealer Name (City)
Dealer Name (City)
Dealer Name (City)
---PROVINCE/STATE---
Dealer Name (City)

and so on.

Below is the code that I'm using to loop through the recordset, but first a short explanation.

I'm looping through the recordset and at the end I'm assigning the variable $last_dist the value of the current recordset (so for the first loop, $last_dist is empty). Then I perform a series of checks which decide if the two recordsets have the same province and country, the same country, or neither, and act accordingly.

Oh, and I'm using ADOdb for db access.

$last_dist; // set empty var to hold last record processed
while (!$dist_rs->EOF) {
if (count($last_dist) == 0) {
echo "<option>".strtoupper($dist_rs->fields['country_name'])." ----------</option>\n";
echo "<option>--- ".$dist_rs->fields['provstate']." ---</option>\n";
echo "<option value=\"".$dist_rs->fields['dist_id']."\">".$dist_rs->fields['name']." (".$dist_rs->fields['city_town'].")</option>\n";
} else if ($dist_rs->fields['country'] == $last_dist[country] && $dist_rs->['prov_state'] == $last_dist[prov_state]) {
echo "<option value=\"".$dist_rs->fields['dist_id']."\">".$dist_rs->fields['name']." (".$dist_rs->fields['city_town'].")</option>\n";
} else if ($dist_rs->fields['country'] == $last_dist[country] && $dist_rs->['prov_state'] != $last_dist[prov_state]) {
echo "<option>----- ".$dist_rs->fields['provstate']." -----</option>\n";
echo "<option value=\"".$dist_rs->fields['dist_id']."\">".$dist_rs->fields['name']." (".$dist_rs->fields['city_town'].")</option>\n";
} else if ($dist_rs->fields['country'] != $last_dist[country]) {
echo "<option>".strtoupper($dist_rs->fields['country_name'])."</option>\n";
echo "<option>------------------</option>\n";
echo "<option>----- ".$dist_rs->fields['provstate']." -----</option>\n";
echo "<option value=\"".$dist_rs->fields['dist_id']."\">".$dist_rs->fields['name']." (".$dist_rs->fields['city_town'].")</option>\n";
}
unset($last_dist);
$last_dist = $dist_rs->fields;
$dist_rs->MoveNext();
}

Now whenever I run the code as it is, I get the following error:

Parse error: parse error, expecting T_STRING' orT_VARIABLE' or '{'' or'$'' in c:\phpdev\www\rushtonlandingnets\includes\c_distributors.php on line 44

However, if I remove the three else if statements and replace them with an else statement, I can output the remaining records, through either the $last_dist variable, or the current recordset.

Anyone have any idea as to why the code won't work as it is? I've been looking at it for quite a while and trying everything I can think of but I can't find the problem.

Any help is greatly appreciated.

Thanks in advance,
Pablo

[[deleted]]

Wherever you have:

$last_dist[country]

Replace it with:

$last_dist["country"]

[Anon]

Um, which one's line 44? Ah, that one.

I do notice you're not quoting 'country' when you write $dist_rs[country]. There are a couple of other places you do that, too. The lone $last_dist; at the top is there why? The unset() at the bottom is unnecessary.

But what's this?

$dist_rs->['prov_state']

?

[pgosse]

Grumbler, THANK YOU!

Seriously, I looked through that code for at least an hour and couldn't see anything wrong. Then I look at your post an hour later and BLAM, it's right there.

$dist_rs->['prov_state']

should've been

$dist_rs->fields['prov_state']

I use the ADOdb class for talking with databases, and $dist_rs is the variable which is assigned the recordset produced by my query, and the ->fields method accesses the prov_state element of the recordset associated with $dist_rs (that's not a very good explanation, but my brain isn't exactly functioning right now ;o)

The lone $last_dist and the unset($last_dist) were my feeble attempts to see if it could be anything else causing the problem. They're both redundant, and I should've removed them but forgot.

On that note, and taking into consideration the complete and utter unreadability of the code I posted, I think this forum could be well served by a feature which allowed users to preview a post, and which allowed for preformatted text for code examples. I sometimes post to the PL/SQL forum on www.tek-tips.com and on their forums you can preview your posts and the code is indented properly.

Just a thought.

Thanks again, Grumbler.

P.

[Anon]

On the subject of previews and formatting of these posts, I have to agree with you wholeheartedly. I reckon some pretty significant changes need to be made to the wildly inconsistent formatting rules of this forum.

Some tags are recgonised and applied (like b and font), causing the rest of the text to look weird, while some tags are silently dropped (like html and pre). Since code excerpts can't be expected to follow all the rules of HTML, it makes no sense to treat posted code as HTML.

Once these posts go into the archives, the habit of rendering random bits of HTML becomes even worse.

And of course, indentation. If this was a Python forum any code posted wouldn't even work!