Custom Function Question

[Anon]

Hi,
I have writen my own function to aid in code re-use, I get the error "cannot declare GDates()" where GDates() is the name of my function. the function contains a query that runs based on a variable passed in to the function. Could the problem be that queries dont work inside functions ?
any ideas ??

[Anon]

If you can't define a function, it's probably because something BEFORE the function is wrong...Try looking for unclosed curly brackets, quotes, or something of that sort.

Diego

[Anon]

You might have declared a variable with the same name as that of the function(GDates).
S.

[Anon]

It get stranger... originally I was going to call the function 5 times, but that didn't work.. so I created a loop inside the function so only on call was needed but Inow get the error :cannot redeclare gd() (yes I have renamed the function also.

below is the code:

Function GD($db, $EmpID)
{

		 $DBcon = $db;
		 $EID = $EmpID;

		 // create an array with the days
		 $Day = array("Saturday", "Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday");

		 For ($i=0; $i<6; $i++)
		 {
		 	$sql_t1 = "SELECT Start, Stop
							 	 	FROM Timesheet
									WHERE EmployeeID=$EID
									AND Day=";

			echo"<td width=\"61\" valign=\"top\"><table width=\"61\"  border=\"0\" class=\"thdr_s\">";
			$sql_t = $sql_t1 . "'" . $Day[$i] ."'";
			$qry_t = mysql_query($sql_t,$DBcon);
				while ($myrow = mysql_fetch_array($qry_t))
					{
					echo"<tr><td>" . $myrow["Start"] . " - " . $myrow["Stop"] . "<br></td></tr>";
					}
			echo"</table></td>";
			}
		return;
		}


		echo (GD($db, $EmpID));

[Anon]

Have you tried the last statemnt (echo (GD($db, $EmpID))😉 like this:
GD($db, $EmpID);

S.

[Anon]

Yes, thats the way I did it first.
Cheers

[Anon]

Are you sure that's the error you get? "cannot declare function Gd"? 'cause I copy and pasted your code and ran it in PHP and I got many parse errors. So you should fix those first.

Diego

[wchris]

while ($myrow <b>==</b> mysql_fetch_array($qry_t)) {....}

-- Perhaps --

[Anon]

No, that's as silly as last time.

As for Stuart's code, I didn't get any parse errors when I tried it. In fact, it ran.

'Course, 'cos i'm not running mysql round here and I don't have the database, I commented out the query and the loop.

I even did a quick grep of the PHP4.1.1 source code - didn't get any matches on the string "cannot declare" - in fact, even the word "declare" seems to be absent.

Can't replicate this problem.

[Anon]

Okay: _RE_declare. bonk

I'm strongly suspecting there's more code here that we need to see. I can only see one place where GD() is being declared, so why is PHP attempting to do so twice?

This is a function intended for code reuse. So I'm guessing it's in an include() file. If this file gets included twice in any fashion (A includes B and C, B and C both include D; A includes B and C, B includes C; A includes B, B includes A,....) things are gonna puke in just this way.

Am I right? Is this file getting included multiple times? If it is, consider replacing include() with include_once(), so that PHP won't bother including it again if has done so once already.

[Anon]

No, it only gets called once from within the same page...

I have redone it (without the need for a function) using just the loop and it works fine...

Not sure what the problem was but thanks to everyone anyway.