Drop Down 3

Anon

I want the contents of a list for a drop down box to come from a column (Industry) in a table (Lists) in MySQL.

Someone has kindly provided the script below:

$results = mysql_query("SELECT industry FROM lists ORDER BY industry");

echo '<select name="industry">';
while( list($industry) == mysql_fetch_row($results)){
echo "<option value='$industry'>$industry";
}
echo "</select>";

Someone has also said the above script should be in the HTML page and that it should be renamed ".php". I thought I need an HTML page so people could see form in browser?

Which page and exactly where in the page does it go...in the HTML or Results.php page? See below:

HERE IS PART OF THE HTML PAGE:

<form action="http://localhost/insert_client.php" method="post">
<table border=0 font-size=8>
<tr><td>Industry</td><td>
<select name="Industry">
<option value="Banking">Banking
<option value="Commerce">Commerce
<option value="Energy">Energy
<option value="IT">IT
<option value="Media">Media
<option value="Market Data">Market Data
<option value="Project Management">Project Management
</select><br></td></tr>

AND HERE IS PHP PAGE:

<head>
<title>4i dotCom Entry Results</title>
</head>
<body>
<h1>4i dotCom Entry Results</h1>
<?
if (!$ClientName || !$ClientStNo || !$ClientStName || !$ClientPostCode || !$AreaCode || !$MainPhone || !$MainFax || !$MainEmail || !$MainContact || !$ConsultantID)
{
echo "You have not entered all the required details.<br>"
."Please go back and try again.";
exit;
}
$ClientID = addslashes($ClientID);
$ClientName = addslashes($ClientName);
$ClientBldgName = addslashes($ClientBldgName);
$ClientStNo = addslashes($ClientStNo);
$ClientStName = addslashes($ClientStName);
$ClientStType = addslashes($ClientStType);
$ClientDistName = addslashes($ClientDistName);
$ClientCityName = addslashes($ClientCityName);
$ClientPostCode = addslashes($ClientPostCode);
$ClientCountry = addslashes($ClientCountry);
$AreaCode = addslashes($AreaCode);
$MainPhone = doubleval($MainPhone);
$MainFax = doubleval($MainFax);
$MainEmail = addslashes($MainEmail);
$MainContact = addslashes($MainContact);
$Comments = addslashes($Comments);
$MainContact = addslashes($MainContact);
$ConsultantID = doubleval($ConsultantID);

$db = @mysql_pconnect("localhost.localdomain:3306", "root", "password");

if (!$db)
{
echo "Error: Could not connect to database. Please try again later.";
exit;
}

mysql_select_db("4i_dotCom");
$query = "insert into Clients (ClientID, ClientName, ClientBldgName, ClientStNo, ClientStName,
ClientDistName, ClientCityName, ClientPostCode, ClientCountry, Industry, AreaCode, MainPhone, MainFax,
MainEmail, MainContact, Comments, ConsultantID, ClientStType) values

('".ClientID."', '".$ClientName."', '".$ClientBldgName."', '".$ClientStNo."', '".$ClientStName."',
'".$ClientDistName."', '".$ClientCityName."', '".$ClientPostCode."', '".$ClientCountry."',
'".$Industry."', '".$AreaCode."', '".$MainPhone."', '".$MainFax."', '".$MainEmail."', '".$MainContact."', '".$Comments."', '".$ConsultantID."', '".ClientStType."')";

$result = mysql_query($query) or die("Error: ".mysql_error());
if ($result)
echo mysql_affected_rows()." client inserted into database.";
?>

</body>

winelight

I think the script that you have been provided with should replace:

in your html page. Then, you'll have to rename the page as .php instead of .html, and of course change any references to it.

Perhaps someone can give an easier answer?

winelight

Oh, and you'll have to enclose the script with <?php and ?>

like this:

<?php
script
?>

winelight

But someone's already given you the answer further down. And they (correctly) pointed out you need to replace everything between <select... and </select>

I think you're missing an important point. If a web page has the extension .php but contains only html code and no php script, it will be sent to the browser as html and display as normal.

However, if the server encounters <?php in the page, it will then proceed to execute the code up to the ?>. That code may (or may not) output additional html code, which the server sends to the browser.

Anon

OK did that...error is now:

Parse error: parse error, expecting `'='' in /opt/apache/htdocs/newclient.php on line 38

I created a column called IndName in the table Industry

HERE IS PHP FORM NOW:

<head>
<title>4i dotCom - New Client Entry</title>

<body>
<h1>4i dotCom - New Client Entry</h1>

<form action="http://localhost/insert_client.php" method="post">
<table border=0 font-size=8>
<tr><td><font=8>Industry</font></td><td>
<?
$results = mysql_query("SELECT IndName FROM Industry ORDER BY IndName");

echo '<select name="IndName">';
while( list($IndName) == mysql_fetch_row($results)){
echo "<option value='$IndName'>$Ind Name";
}
echo "</select>";
?>

Anon

Also, I did not copy and paste the tags over to this forum by mistake, but they are there in my page.

But now that I have saved it as .php I can't even see the form now, I just get the parser error as mentioned.

Anon

Is this line 38?
while( list($IndName) == mysql_fetch_row($results)){

Because the "==" should be "=". It's something of a PHP/MySQL coding idiom. What it does is:

Try and fetch a row from the database.
If you succeed, put its first field into $IndName, and continue through the while loop.
If you fail, jump to where the loop finishes.

Anon

If there's a parser error, PHP gives up and doesn't even try to process the page.

Anon

OK I did that but get same error... so here is top part of page showing all the 38+ lines:

<head>
<title>4i dotCom - New Client Entry</title>
<STYLE TYPE="text/css">
H1 {
font-weight: bold;
font-size: 12pt;
line-height: 12pt;
font-family: verdana;
font-variant: normal;
font-style: normal;
}
BODY {
color: black;
background-color: white;
background-image:src="manual/images/4i_Logo.gif";
background-repeat: no-repeat;
font-family:verdana;
font-variant: normal;
font-style: normal;
font-weight: normal;
font-size: 10pt;
line-height: 11pt;
}
</STYLE>
</head>
<align="left"><IMG SRC="manual/images/4i_Logo.gif" ALT="4i Logo" BORDER=0>
<body>
<h1>4i dotCom - New Client Entry</h1>

echo '<select name="IndName">';
while( list($IndName) "=" mysql_fetch_row($results)){
echo "<option value='$IndName'>$Ind Name";
}
echo "</select>";
?>

Anon

Duplicate in case you missed last reply

OK I did that but get same error... so here is top part of page showing all the 38+ lines:

<form action="http://localhost/insert_client.php" method="post">
<table border=0 font-size=8>
<tr><td>Industry</td><td>
<?
$results = mysql_query("SELECT IndName FROM Industry ORDER BY IndName");

echo '<select name="IndName">';
while( list($IndName) "=" mysql_fetch_row($results)){
echo "<option value='$IndName'>$Ind Name";
}
echo "</select>";
?>

Anon

Um, where did those quotes come from?

list($IndName) = mysql_fetch_row($results)

I used them in my post for a reason. Something in English known as the "use-mention distinction". You'll see I quoted the "==" there as well for the same reason.

Anon

Yikes I did that and got this:

4i dotCom - New Client Entry
Industry
Warning: Can't connect to local MySQL server through socket '/tmp/mysql.sock' (111) in /opt/apache/htdocs/newclient.php on line 35

Warning: MySQL Connection Failed: Can't connect to local MySQL server through socket '/tmp/mysql.sock' (111) in /opt/apache/htdocs/newclient.php on line 35

Warning: MySQL: A link to the server could not be established in /opt/apache/htdocs/newclient.php on line 35

Prior to adding this PHP script and saving as PHP, I guess the HTML page relied on the results page to connect. That page only has an insert statement to the Clients table.

Here is top part of entry page with 35+ lines and further down the results page.

echo '<select name="IndName">';
while( list($IndName) = mysql_fetch_row($results)){
echo "<option value='$IndName'>$Ind Name";
}
echo "</select>";
?>

HERE IS RESULTS PAGE

$db = @mysql_pconnect("localhost.localdomain:3306", "root", "password");

if (!$db)
{
echo "Error: Could not connect to database. Please try again later.";
exit;
}

$result = mysql_query($query) or die("Error: ".mysql_error());
if ($result)
echo mysql_affected_rows()." client inserted into database.";
?>

</body>

juxstapose

Hiya

Your syntax error is the quoted equal sign.
Grumbler already pointed this out.

-Mike