systematic array extraction

[nigel_belanger]

I have a form that display data pulled from a table. It does this by:
$result=the result of my query...
while ($x = mysql_fetch_row ($result) )
{
?>
<td><input type="text" name="content[]" value="<?php echo $x[2]; ?>" size="15"><input type="hidden" name="contentid[]" value="<?php echo $x[0]; ?>">
}

This will post an array when the form is submitted. NOW...I need to extract the data in the array (as there are multiple records) and update each item in the array ($content) based on the ($contentid) which is also passed in an array.

This is how I started this venture:

if (@$update) // did the submit get clicked?
{
$content_array = implode (",",$content);
$contentid_array = implode (",",$contentid);

for each ($u as list($content_array) and $i as list($contentid_array))
{
$update_con_query="update table SET content='$u' WHERE contentid='$i' ";
$con_result=mysql_query($update_con_query);
}
}

This is not working, but I need to parse the first value in each of the arrays and then update the database based on the data.

Tough for me - maybe ez 4 u?

Thanks in advance!

[Anon]

First, don't use '@' where it is unnecessary!!

if (@$update)

should be:

if (isset($update) && $update)

And this:
for each ($u as list($content_array) and $i as list($contentid_array))
{
$update_con_query="update table SET content='$u' WHERE contentid='$i' ";
$con_result=mysql_query($update_con_query);
}
}

should be:

for ($i=0; $i < count($content_array); $i++)
{
$update_con_query="update table SET content='$content_array[$i]' WHERE contentid='$contentid[$i]' ";
$con_result=mysql_query($update_con_query);
}
}

Notes:
1. foreach loops are not "for each" loops (which don't exist)

2. You can't have 2 "as" statements in the foreach loop.

Diego

[nigel_belanger]

That fixed it - Thank you Diego!

Oddly enough, I read the article by Tim (PHP & Arrays) just after reading this.

Question: Why should I not use '@' to supress errors?

[Anon]

Because, in my opinion, '@' should only be used for quick fixes. If you're using '@', then you should still include the error checking somewhere else. In your case, you don't even need the '@' if you use isset(). But in other cases, like this:

$con = @mysql_connect();
if (!$con) die("could not connect");

you use '@' to supress PHP's error message, but you still need to catch the error and display something to the user (or for yourself when debugging).

I don't like using '@' because basically it makes your code harder to debug later on.

Diego

[nigel_belanger]

Nice. Good info. I guess it's just me being lazy and not taking them out.

(grin)

Take care Diego and thanks again!