Undefined Variable

Anon

I am pretty new to PHP and script programming in general. So consequently I am struggling to understand where I have gone wrong. So any help anyone can give me would be great.

I keep getting an Undefined Variable error message.

Warning: Undefined variable: ID in G:\wwwroot\php\whiteboard\Edit2.php on line 21

The error comes in this line of code.

$sql = "Update [User] SET Status = '$Status', TimeOut = '$TimeOut', TimeIn = '$TimeIn', Location = '$Location', AccCall = '$AccCall', LocExt = '$LocExt' WHERE ID = '$ID'";

The interesting thing is that I can phyiscally insert an ID Number for a User and the code works perfectly. Can anyone point me in a direction to pursue.

Thanks, Phil

khaine

The line looks to be fine could you post your code in context? It just that sometimes an error can give one line as at fault but it is in fact an earlier error causing the problems.

Mark.

stuartc1

I would try a test like this above the SQL:

echo "The ID varaiable is: "$ID;
exit;

to see if the variable does exist, also check to see if the character case is the same (uppercase or lowercase).

Anon

Here is the Code in Context. The Line in Question comes from the second set of code. Thanks for your input.

<?php
//Connect to Database
$db = odbc_connect("Status", "", "") or die ("Could not CONNECT!");

// Prepare SQL Statement
$sql = "SELECT * FROM [User] WHERE ID = '$ID'";

// Prepare SQL Statement
$result = odbc_prepare($db, $sql) or die ("Could not PREAPARE SQL Statement");

// Execute SQL Statement
odbc_execute($result) or die ("Could not EXECUTE SQL Statement");

while (odbc_fetch_row($result)) {
$ID = odbc_result($result, 'ID');
$FirstName = odbc_result($result, "FirstName");
$LastName = odbc_result($result, "LastName");
$Status = odbc_result($result, "Status");
$TimeOut = odbc_result($result, "TimeOut");
$TimeIn = odbc_result($result, "TimeIn");
$Location = odbc_result($result, "Location");
$AccCall = odbc_result($result, "AccCall");
$LocExt = odbc_result($result, "LocExt");
$UserExt = odbc_result($result, "UserExt");

echo "

<head>
<title> Modify Record</title>
</head>
<body>
<h3>Editing Status for: $FirstName $LastName</h3>&nbsp<I>ID: $ID</I>

<table border=0 width=240>
<tr>
<td>
<strong>Status:</strong>
</td>
<td>
<SELECT name=\"Status\">
<OPTION value=\"\">-- Select One --</Option>
";
if ($Status == "IN") {
echo "<OPTION value=\"IN\" selected>IN</Option>";
} else {
echo "<OPTION value=\"IN\">IN</Option>";
}

		if ($Status == "OUT") {
			echo "<OPTION value=\"OUT\" selected>OUT</Option>";
		} else {
			echo "<OPTION value=\"OUT\">OUT</Option>";
		}
		echo"
	</SELECT>
</td>

</tr>

<tr>
<td valign=top>
<strong>Destination:</strong>
</td>
<td valign=top>
<TEXTAREA name=\"Location\" cols=35 rows=2>$Location</TEXTAREA>
</td>
</tr>

<tr>
<td valign=top>
<strong>Accept Calls:</strong>
</td>
<td valign=top>
<SELECT name=\"AccCall\">
<OPTION value=\"\">-- Select One --</Option>
";
if ($AccCall == "Yes") {
echo "<OPTION value=\"Yes\" selected>IN</Option>";
} else {
echo "<OPTION value=\"Yes\">Yes</Option>";
}

		if ($Status == "No") {
			echo "<OPTION value=\"No\" selected>OUT</Option>";
		} else {
			echo "<OPTION value=\"No\">No</Option>";
		}
		echo"

	</SELECT>
</td>

</tr>

<tr>
<td valign=top>
<strong>Destination Extension:</strong>
</td>
<td valign=top>
<INPUT type=\"text\" name=\"LocExt\" value=\"$LocExt\" size=8 maxlength=6>
</td>
</tr>

</Form>
";
}

<?php
//Connect to Database
$db = odbc_connect("Status", "", "") or die ("Could not CONNECT!");

// Prepare SQL Statement
$sql = "SELECT * FROM [User] WHERE ID = '$ID'";

// Prepare SQL Statement
$result = odbc_prepare($db, $sql) or die ("Could not PREAPARE SQL Statement");

// Execute SQL Statement
odbc_execute($result) or die ("Could not EXECUTE SQL Statement");

echo "

<head>
<title> Modify Record</title>
</head>
<body>
<h3>Editing Status for: $FirstName $LastName</h3>&nbsp<I>ID: $ID</I>

		if ($Status == "OUT") {
			echo "<OPTION value=\"OUT\" selected>OUT</Option>";
		} else {
			echo "<OPTION value=\"OUT\">OUT</Option>";
		}
		echo"
	</SELECT>
</td>

</tr>

<tr>
<td valign=top>
<strong>Destination:</strong>
</td>
<td valign=top>
<TEXTAREA name=\"Location\" cols=35 rows=2>$Location</TEXTAREA>
</td>
</tr>

		if ($Status == "No") {
			echo "<OPTION value=\"No\" selected>OUT</Option>";
		} else {
			echo "<OPTION value=\"No\">No</Option>";
		}
		echo"

	</SELECT>
</td>

</tr>

<tr>
<td valign=top>
<strong>Destination Extension:</strong>
</td>
<td valign=top>
<INPUT type=\"text\" name=\"LocExt\" value=\"$LocExt\" size=8 maxlength=6>
</td>
</tr>

</Form>
";
}

Anon

My appologies I copied the first set of Code twice in the previous message.

<!--
function redirect()
{
window.location = "http://online.tayloru.edu/php/whiteboard/Statusboard.php"
}

setTimeout("redirect();", 20000)
//-->

</SCRIPT>

<?php

//Connect to Database
$db = odbc_connect("Status", "", "") or die ("Could not CONNECT!");

// Prepare SQL Statement
$sql = "Update [User] SET Status = '$Status', TimeOut = '$TimeOut', TimeIn = '$TimeIn', Location = '$Location', AccCall = '$AccCall', LocExt = '$LocExt' WHERE ID = '$ID'";

// Prepare SQL Statement
$result = odbc_prepare($db, $sql) or die ("Could not PREAPARE SQL Statement");

// Execute SQL Statement
odbc_execute($result) or die ("Could not EXECUTE SQL Statement");

echo "The ID varaiable is: '$ID'";
exit;

Anon

Is $ID supposed to come from the user? Then you should use $GET['ID'] or $POST['ID'] depending on the input method you're using.

Diego

[deleted]

The ID variable is passed forward through the URL