Script not working...any ideas

Anon

Hi all,
Can anyone see anything wrong with this script:

<?php

require 'include.php';

$UserName = strtoupper ($UserName);
// UserName is not case sensitive - Password is however.

$Connect = mysql_connect($DBhost,$DBuser,$DBpass);
mysql_select_db($DBName, $Connect);

$query = mysql_query("SELECT UserName, Password FROM $table WHERE UserName = '$UserName'", $Connect);

if (mysql_num_rows($request) == 0) {
print "&Go=Yes&Success=No&";
} else {
$settings = mysql_fetch_row($request);

if ($settings[1] != $Password) {  //Makes sure the Pass from the DB - matches the one entered by the user.
        print "&Go=Yes&Success=No&"; 
} else {  
        print "&Go=Yes&Success=Yes&";
}

}

Cheers,
suzyQ

rbenfield

about line 13 and 16 seem to reference the wrong variable for the query result. So this...

if (mysql_num_rows($request) == 0) {

should be this...

if (mysql_num_rows($query) == 0) {

. Same thing for the mysql_fetch_row.

Hope that helps,
Richard

rbenfield

Btw, after looking at this again, I feel I should caution you. I could be way off but it seems that you might be appending the "&Go=Yes&Success=No&"; to a url link or header redirect once you have authenticated them. The problem with this would be that if there is no other checking then the savy user would figure out that if they changed the url to contain "&Go=Yes&Success=Yes&"; that they would be able to skip the authentication. Like I said, I could be mis-reading this. It just depends on what you are trying to accomplish. If you are just trying to keep honest people honest then it may be ok. If you are trying to keep dishonest people out, you will need something more secure. Either way I am just making a suggestion.

Thanks,
Richard

Anon

Thanks for the reply....
It will be secure, the values are being put back into a swf. Would this be secure enough?

rbenfield

ahhh, ok, well I don't know anything about swf's so maybe someone else could comment on that. I do know that using it in the url would be in-secure. Since you are not doing that it is at least a little better but without knowing flash I cant say how secure it is.

Thanks,
Richard

rrijnders

$query = mysql_query("SELECT UserName, Password FROM $table WHERE UserName = '$UserName'", $Connect);

Note that you have <b>='$UserName'</b>

The single quotes around the variable will keep it from being dereferenced into it's value. In essence, you are searching for "$UserName", literally.

-- Rich