Simple XOR function

[Anon]

When I try to use the following code I get the error message below. Can someone please tell me what's wrong.

function simpleXor($inString,$key)
{
$outString="";
$l=0;
if strlen($inString)!=0 {
for ($i = 1; $i < strlen($inString); $i++) {
$outString=$outstring . ($inString{$i}^$key{l});
$l=$l+1;
if $l==strlen($key) then $l=0
}
}
return $outstring
}

Parse error: parse error, unexpected T_STRING, expecting '(' in c:\apache group\apache\htdocs\php\test.php on line 6

[Anon]

You are missing a bunch of semicolons.

if $l==strlen($key) then $l=0;

return $outstring ;

Hope this helps.

[Anon]

Yeah, and the whole "then" thing is not from PHP. It should be

if ($l==strlen($key))
$l=0;

[nnichols]

Thanks. Have changed to this -

function simpleXor($inString, $key)
{
$outString="";
$l=0;
if (strlen($inString)!=0) {
for ($i = 1; $i < strlen($inString); $i++) {
$outString=$outstring . ($inString{$i}^$key{l});
$l=$l+1;
if ($l==strlen($key))
$l=0;
}
}
return $outstring;
}

and now it only returns an empty string every time. I'm missing something.

[nnichols]

Somebody please help.

[olechka]

OK, another suggestion 🙂

Wne you refer to an element in an array (or string), you should use [], not {}.

$outString=$outstring . ($inString{$i}^$key{l});

should be

$outString=$outstring . ($inString[$i]^$key[l]);

Also try to keep variable names the same case (though I am not sure it matters).

If this doesn't help you probably messed something up with ^, but I am not familiar with it 🙁

[olechka]

Also, key[l] should be key[$l]