error in SQL syntax -- where ??

[Anon]

I am not sure where should I be looking to debug this problem, but when I am trying to writeup date to mysql, I get this,

Error adding submitted item: You have an error in your SQL syntax near ''a' at line 1

Now, my code looks like this,
<?php
$dbcnx = @mysql_connect(
"localhost", "root", "pass");
if (!$dbcnx) {
echo( "<P>Unable to connect to the " .
"database server at this time.</P>" );
exit();
}

// Select the jokes database
if (! @mysql_select_db("test") ) {
  echo( "<P>Unable to locate the joke " .
        "database at this time.</P>" );
  exit();
}

if ("SUBMIT" == $submit) {
  $sql = "INSERT INTO subject SET " .
    "SUB_NAME='$sname', " .
    "SUB_Age='$sage', " .
    "HAND_OR='$handor', " .
    "METAL_IMPLANTS='$metal', " .
    "ILLNESS='$ill', " .
    "ADHD='$adhd', " .
    "BILINGUAL='$biling', " .
    "GUARDIAN_Name='$guard', " .
    "PART_INFO='$part";

  if (mysql_query($sql)) {
    echo("<P>Your item has been added.</P>");
  } else {
    echo("<P>Error: " .
         mysql_error() . "</P>");
  }
}

if (isset($delete)) {
$sql = "DELETE FROM subject " .
"WHERE ID=$sid";
if (mysql_query($sql)) {
echo("<P>The item has been deleted.</P>");
} else {
echo("<P>Error deleting: " .
mysql_error() . "</P>");
}
}

echo("<P> Here are all subjects " .
     "in our database: </P>");


$result = mysql_query(
            "SELECT * FROM subject");
if (!$result) {
  echo("<P>Error performing query: " .
       mysql_error() . "</P>");
  exit();
}

while ( $row = mysql_fetch_array($result) ) {

    $sid = $row["SUB_ID"];
    $sname = $row["SUB_Name"];
    $sage = $row["SUB_Age"];

echo("<TD>$sname</TD>\n");
echo("<TD>$sage</TD>\n");
echo("<TD>[<A HREF='$PHP_SELF?delete=$sid'>" .
"Delete this item</A></P>");

}

?>

<FORM ACTION="<?php echo($PHP_SELF); ?>" METHOD=POST>
<P>Enter New Subject Details<BR>
Name: <INPUT TYPE=TEXT NAME="sname" SIZE=20 MAXLENGTH=100><BR>
Age: <INPUT TYPE=TEXT NAME="sage" SIZE=20 MAXLENGTH=100><BR>
Hand Or: <INPUT TYPE=TEXT NAME="handor" SIZE=20 MAXLENGTH=100><BR>
Metal: <INPUT TYPE=TEXT NAME="metal" SIZE=20 MAXLENGTH=100><BR>
Illness: <INPUT TYPE=TEXT NAME="ill" SIZE=20 MAXLENGTH=100><BR>
ADHD: <INPUT TYPE=TEXT NAME="adhd" SIZE=20 MAXLENGTH=100><BR>
BiLing: <INPUT TYPE=TEXT NAME="biling" SIZE=20 MAXLENGTH=100><BR>
Guardian: <INPUT TYPE=TEXT NAME="guard" SIZE=20 MAXLENGTH=100><BR>
Part Info: <INPUT TYPE=TEXT NAME="part" SIZE=20 MAXLENGTH=100><BR>
<INPUT TYPE=SUBMIT NAME="submit" VALUE="SUBMIT">
</FORM>

</BODY>

Please advice

[alfoxy]

is sage an INT field ? if so then take out the '' in

"SUB_NAME='$sname', "
Al

[rbenfield]

I am not positive but the problem may be you are trying to update an existing record with INSERT. You need to check to see if it exists. If it does use UPDATE and if not then use INSERT.

Hope that helps,
Richard

[Anon]

You forgot the last " ' " at the end of '$part' in the insert query, : ).
Hope that helps.

[Anon]

Ok,
It was a syntax problem. Thanks for pointing it out for me. Such things are so hard for me to notice, at times.

I wonder whats a good composer which will help me detect such errors easily. Bluefish ??

Thanks a bunhc again !!