Insert problem

Anon

Can anyone see why this won't work? Table is calles users and column is email:

$sql_insert = "insert email into users where email = '$email'";
$result = mysql_query($sql_insert);

Thanks

nigel_belanger

Should be:

$sql_insert = "insert into users (email) values ('$email') where userid = '$userid'";

The rest is fine. when you insert, use the above convention (comma delimit if multi-fields)

When updating use:

update tablename set field1='$field1', field2...etc

Hope that helps!

Anon

Hi Ali,

Try replacing the "$sql_insert ....." line:

$sql_insert = "insert into users values ('$email');";

Rgds,
Keld List-Jensen.

Anon

Hi Nigel,

Please explain to me how the insert works, using the where option? I've never seen it before, but perhaps I'm missing something.

Another thing is the userid. Where did that come from in the original quistion? I agree with you, that the table (well, almost any table) should have an id field because it makes things much easier.

Rgds,
Keld List-Jensen.

nigel_belanger

Honestly, I didnt' even look into it that far. I can't think of a reason to use a where condition when inserting. good catch Using the where when performing an UPDATE would be better. I am not sure when you would want to use the WHERE clause when inserting - my bad...heh!

I added the USERID field as an example for good practice. If you would like to update a particular record, using the WHERE clause will only update the record WHERE a field has the same value as what is in the table. (e.g. If you want to update a record for a particular user - you would write the SQL statement to use a WHERE userid = the passed userid value. This is assuming you are using userid as a field in the users table)