HTTP User authentification in OO style

[docpiper]

Hi,

today I played aroung with the HTTP authentification functionality of PHP. The goal was to write an adminscript where the user has to enter username and password in the normal user authentification manner.

Now, because I wrote the functionality part of this script in OO style, I also wanted to perform here also in OO style. But I failed.

I came along with this:
index.php:
<?php
adminuser='admin';
adminpass='password';
include_once('./admin.class.php');
$obj = new Admin($adminuser, $adminpass);
echo "Logged in";
?>

admin.class.php:
<?php
class Admin {
var $adminpass='';
var $adminuser='';
function Admin ($adminuser, $adminpass) {
global $PHP_AUTH_USER, $PHP_AUTH_PW;
$this->adminpass = $adminpass;
$this->adminuser = $adminuser;
if (isset($PHP_AUTH_USER) {
if ( $PHP_AUTH_USER != $this->adminuser || empty($PHP_AUTH_USER)) {
$this->adminLogin();
}
if ( $PHP_AUTH_PW != $this->adminpass || empty($PHP_AUTH_PW)){
$this->adminLogin();
}
} else {
$this->adminLogin();
}
}
function adminLogin() {
Header( "WWW-Authenticate: Basic realm=\"Test Authentication System\"");
Header( "HTTP/1.0 401 Unauthorized");
echo "You must enter a valid login ID and password to access this resource\n";
exit;
}
}
?>
(Don't look to much onto typos or ot closed brackets, I wrote this from mind)

What happens: I always get the login window even when I type in the correct username and password, the user never get authentificated.
What I'm doing wrong?

I tested a version straight ahead in the index.php which works, but doesn't satisfy me (I'm that kind of scripter which wants to know more than one way).
I also tried a similar version like used in phpMyAdmin, but didn't got the same result.
I'm out of ideas, maybe one of you might have one.

Thanks for any suggestion. Regards, Thomas

[Anon]

Ok,

1. Syntax error:

   adminuser='admin';
   adminpass='password';

should be:
$adminuser='admin';
$adminpass='password';

2. global $PHP_AUTH_USER, $PHP_AUTH_PW;

Those variables are Apache-specific. So if your web server is not Apache, you won't be able to use those vars.

3. global $PHP_AUTH_USER, $PHP_AUTH_PW;

Depending on your PHP version and configuration, you might have to use $SERVER['PHP_AUTH_USER'] and $SERVER['PHP_AUTH_PW']

Diego

[docpiper]

Hi,

1. ok, was a mistake because for me it was late in the night and it was not the original code I took.

2. it is an Apache server

3. I use 2 different version of PHP: on my Linux server (LAMP) I have Apache 1.3.20 with PHP 4.1.2, on my Windows machine (WAMP) I use Apache 1.3.23 with PHP 4.2.1.

Do you think it is better to use $_SERVER['...'] instead?
I mean the script works fine as long I take the part from the constructor and the function from the class into the script (index.php) itself. That's why I wonder that this doesn't work in this programming style.

Thomas

[Anon]

Hmm...then you have register_globals on, right? Tsk tsk, that's not good...

But anyway, if you use $SERVER['...'] it should solve your problems, because $SERVER is a super global, so you don't need to declare "global $_SERVER;" inside the function.

Diego