sql problem with html content

Anon

Hello all,
my problem is that the stylesheet for my website is saved in my database, and I want to update the following stylesheet:

body {background-color:#252341;
scrollbar-face-color: #CBCBCB;
scrollbar-shadow-color: #AFAFAF;
scrollbar-highlight-color: #AFAFAF;
scrollbar-3dlight-color: #AFAFAF;
scrollbar-darkshadow-color: #000000;
scrollbar-track-color: #262342;
scrollbar-arrow-color: #3333ff;}

a:link {color:#0000FF; text-decoration:none}
a:active {color:#4684BD; text-decoration:none}
a:visited {color:#0000FF; text-decoration:none}
a:hover {color:#4684BD; text-decoration: none}

.text {color:#000000; font-size:12px}
.td {background-color:#dddddd}

input {font-family: Arial,
font-size: 12px;
color: #5F5F5F;
background-color: #DFDFDF;
border-top-width : 1px;
border-right-width : 1px;

   border-bottom-width : 1px;
   border-left-width : 1px;
   text-indent : 0px;}

and I want to update it by the following function:
function update($tabel, $action, $connect) {
$sql = "update $tabel SET $action where $id=1";
$result = mysql_db_query($db,$sql,$connect)
or die("Couldn't execute query.");
return $result;
}

I call this function by the following line:
$update = update("ppn_design","design_name=$design_name,stylesheet=$stylesheet","$connect");

but all I get is the output:
Couldn't execute query.

I got no clue where the problem is, maybe it has something to do with the , and ; and " in the $stylesheet, but I'm not sure..
please help me.

theslinky

Nope. I think it has to do with the # characters. # is a comment character in mysql. Also, make sure you don't have a ' (single quote) character. If you do, escape that as well.

A simple command to escape the # would be:

$stylesheet = str_replace("#", "\#", $stylesheet);

and for the ', you can use addslashes or just use string replace:

$stylesheet = str_replace("'", "\'", $stylesheet);

also, it's best to try out queries from the command line or using a program like phpMyAdmin (http://phpmyadmin.sourceforge.net). If you're hosting your site with a web provider, the probably won't let you have shell access to use the command line program. So installing phpmyadmin is very beneficial.

-sridhar

Anon

thank you very much, but the problem becomes larger!

I tried out what you've said, but it doesnt work, so I just tried something:
I gave $stylesheet and $design_name both a value of "test" without the " and server also said couldnt execute query....
now I'm totally confused....

well, thanks for your help, I'll post here if my problem is solved...

Anon

I shouldn't call the funktion like this:
$update = update("ppn_design","design_name=$design_name,stylesheet=$stylesheet","$connect");

I should do it like this:

update("ppn_design","design_name='$design_name',stylesheet='$stylesheet'","design_id=$design_id","$connect");

and now it works...
you see, I was an idiot and have forgotten the '

well, thanks for your help anyway, Sridhar