File Uploads

[Anon]

Hi folks,

I am trying to upload a file to the host system. Check out my code and if you can, please help.

Thanks in advance,
-Tim

Error Output.

Warning: Unable to create 'c:\temp\C:\WINNT\php29.tmp': Invalid argument in c:\program files\nusphere\apache\htdocs\inline6\scripts\p_addpost.php on line 21
No dice

Form Submission.....
<form name="addpostform" method=post enctype="multipart/form-data" action="<?echo $i6global[httproot];?>/scripts/p_addpost.php">
<input type=hidden name="i6f[projectID]" value="<?echo $i6cp->id?>">
<input type=hidden name="i6f[birth]" value="<? echo time();?>">
<table border=0 cellpadding=4 cellspacing=0 width="100%">
<tr>
<td align=right width="40%">
File
</td>
<td align=left width="60%">
<input type=file name="i6f[file]" maxlength=255 size=35>
</td>
</tr>

	<tr>
		<td align=center colspan=2 class=lightblue>
			<input type=button name="submitbutton" value="Submit" onClick="checkForm()">
		</td>
	</tr>
	</table>
	</form>

handling code......
if (copy($i6f[file], "c:\temp\$i6f[file]")) {
echo "Successfully Added!";
}else{
echo "No dice";
}

[theslinky]

first of all, i think you need to put the file in quotes:

$i6f['file'];

and if you use it inside quotes (i.e. in a string), you need to use braces {} around it or use the string append:

"c:\temp\{$i6f['file']}"

or:

"c:\temp\" . $i6f['file'];

-sridhar

[Anon]

hi i'm an aoler, aren't i nifty?

[rrijnders]

Read the section in the manual on uploading files. Basically, you can't use the same var for the source of the copy ($i6f['file']) and also use it to append to your copy target as the new file name. The variable is a pointer to the temp file created by the web server when the file was uploaded from the web page; it is a location in the server's temp directory.

If you want to now copy it somewhere and retain the same file name the user uploaded, you have to do some extra work because the name of the file will be in another var created by the server. Either that, or you can manually extract the file name from the fully qualified path that php seems to casting the $i6f['file'] into (you can see it in the error message). I wouldn't trust that though.

-- Rich

[theslinky]

uh... sure... yeah, you're nifty...!

??

just a random post or do you have a question about php? :-)

-sridhar

[Anon]

Ok, I am very confused by your thoughts here. I have changed the page significantly to try and make it easier to read.

Now I don't get any errors, or mesages of any sort. By the way, it doesn't work.

-Tim

<?
if(isset($upload)){

     if ($file=="none"){

            echo "You must specify a file to upload";

        }else{

        $formats = array('mp3','exe');

        if(in_array(strtolower(substr($file_name,-3)),$formats)) {

            echo "<font face=\"verdana,arial,helvetica\" size=\"2\" color=\"#000000\"><b>Sorry! MP3's and .EXE's are disallowed!</b></font>";

        }else{

            copy($file, "$file_name");
            unlink($file);

            echo "<font face=\"verdana,arial,helvetica\" size=\"2\" color=\"#000000\"><b>File Uploaded Successfully to <b>$username</b> directory!</b></font>";
        }

    }

}

?>

<table border="0" width="80%" cellspacing="5" cellpadding="5">
<form action="<?=$PHP_SELF;?>" method="post" enctype="multipart/form-data">
<tr>
<td><font color="#000000" face="verdana" size="2">File</font></td>
<td><input type="file" size="40" name="file"></td>
</tr>
<tr>
<td colspan="2"><input type="hidden" name="MAX_FILE_SIZE" value="100000">
<input type="submit" name="upload" value="Upload"></td>
</tr>
</form>
</table>