PROS! Uploading an image help...simple!

Anon

Hello all,

Please ehlp if you can!

I have a form in which the user submits a ton of variables to the MySQL database...from the same form the user can upload an image from their desktop.

The form gets submitted to a PHP page which parses all the data:

I do a SQL INSET to insert all the data...it's works fine. Then I call an $ID function which grabs the number the netry was just assigned...

$ID = mysql_insert_id();

Now, I want to name the image that was uploaded in the form the $ID value .jpg, and then stick it in the proper place on my server...(this is the code that doesn't work for me.)

$file_name = "$ID.jpg";
move_uploaded_file ($file, "/home/lightso/movies/images/$file_name");

mysql_close();
?>

Then I take the file that was uploaded and create a thumbnail image of the file...

<?
$iname="$file";
$x=60;
$y=87;
$srcimage = ImageCreateFromJPEG ($iname);
$newimage = imagecreate ($x, $y);
imagecopyresized ($newimage, $srcimage, 0, 0, 0, 0, $x, $y, imagesx($srcimage), imagesy($srcimage));
imagejpeg($newimage,"/home/lightso/public_html/movies/images/thumbs/$ID.jpg");
?>

Everything works except the first image uploading/renaming scheme. Any ideas what I'm doing wrong?

NOTE: This may or may not be a problem, and if it is a problem I need to firgure out a work around...

All images being uploaded through the form are JPG images, BUT these images have names like BBDBDB.01

with no extension! Just so you know!

Thanks in advance!

yurko

1) move_uploaded_file(); is implemented in PHP 4.0.3 check if you have this or newer version.
(http://www.zend.com/manual/function.move-uploaded-file.php)
I use copy() instead, works everywhere.

2)check if you have rights to write to destination path. I use relative path like this:
copy($sendimage, "./$img_dir/$dest_image_name");
(in my form filed where you browse for image has name "sendimage")

3)If you want to use mysql_insert_id(); You must call "LOCK tables" like this:

$sql = "LOCK TABLES your_table_here WRITE";
$mysql_result = mysql_query( $sql ) or die("Unable to lock table");
$sql = "Your inser here";
$mysql_result = mysql_query( $sql ); // dont die here!
$ID = mysql_insert_id();
//now unlock table
$sql = "UNLOCK TABLES";
$mysql_result = mysql_query($sql) or die("Unable to unlock table");

Why do we need it for? Coz if several users will access your system at the same time you can get into situation when somebody inserted data just after your insert but before your $ID=mysql_insert_id(). So you will get wrong id. If you locked tables then all other will wait for you so you are guaranteed that you will get proper id.
Dont lock tables for long time.
(If Im wrong with this, some gurus plz correct me, coz Im using this aproach for some years and so far it works).

4)nobody cares what was original filenames on user's pc.

Hope this helps a little bit 🙂

Anon

Actually, according to the MySQL manual,

"The most recently generated ID is maintained in the server on a per-connection basis. It will not be changed by another client. It will not even be changed if you update another AUTO_INCREMENT column with a non-magic value (that is, a value that is not NULL and not 0). "

So you don't need to lock the tables. Locking the tables make me uneasy, and from what I was told a long time ago, "Don't lock the tables unless you explicitly HAVE to."

You can find the above information at http://www.mysql.com/doc/G/e/Getting_unique_ID.html

Anon

Hi guys....

Ok...everything works, ONLY IF I change the name of the file on my desktop to something .jpg

If I leave the file with a name like BBBBB.01 without an extension I get this error:

imagecreatefromjpeg: '/tmp/phpy7BAVx' is not a valid JPEG file

So, what's the work around here???

Please help!

Thanks.

yurko

Man it so funny to work with php/mysql so long and still there is something you missed in the manual 🙂
Thank you very much for correcting me!

yurko

Hm.. really strange... GD doesnot care about extension. Recently I made "thumbnailer" script. If you want you can look here

http://members.lycos.co.uk/horobey/
Leftframe menu:[Demos]>[php/mysql]>[Image resizer (Thumbnails)]

this script accepts user uploaded image and resizes it to fit some given dimension (108x108 in my case). It either shrinks or enlarges the image. And it works.

However I found that on Tripod where it is hosted function imagecopy() doesn't work at all. imagecopyresized() works fine. Maybe your prob is kinda this -- ask your ISP then if imagecreatefromjpeg() is working.

Another prob I've got while working on my script was that it doesnot accept *.png files generated by Acdsee (image viewer application for windows). But it accepts files which are generated by imagepng() function. So it seems that GD also doesnot support some newer or older image formats.

To everyone, if you have some small (<10k) png image please try to submit it to script mentioned above. Im just curious if it will work.