link database to email &quot;to&quot;

link database to email "to"

justinb

Hello,
It's me again, I am creating a database that sends out a newsletter. Everthing seems to work,except that no emails are sent (I'm not getting any errors)
Please help, this is my code

<?
session_start();
if($valid !="yes") {
header("Location: contact_menu.php");
exit;
} else {
session_register('valid');
}

$db_name = "ecomphpdb";
$table_name = "justin_contacts";

$connection = @mysql_connect("localhost", "ecomphpstudents",

"makesites") or die("Couldn't connect - please try later.");

$db = @mysql_select_db($db_name, $connection) or die("Error2 -

Couldn't connect - please try later.");

$sql = "SELECT email
FROM $table_name";

$result = @($sql, $connection) or die("Error3 - Couldn't

connect - please try later.");

// while there are rows of results to get from the database table

while($row = @mysql_fetch_array($result))
{ //start while

//new variable $id holds the id for the first row in the result array

called $row

 $id = $row['id']; 
 $email = $row['email'];

} //end while

// *********** Validate *******************

if(($message == ""))
{
header("Location: htmlEmail.htm");
exit;
}

// ***** start of email to customer *******

$msg = "$message\n";

$to = "$email";
$subject = "Newsletter";

$mailheaders = "From: jblayney@jrbgraphicdesign.com\n";
$mailheaders .= "Reply-To: jblayney@jrbgraphicdesign.com";
$mailheaders .= "MIME-Version: 1.0\r\n";
$mailheaders .= "Content-type: text/html; charset=iso-2022-jp\r\n";

mail($to,$subject,$msg,$mailheaders);

// ****** end of customer email *********

<head><title>Justin Blayney</title></head>

<body>
<h3>Your email has been sent</h3>

</body>

daarius

well, in your sql you are only select(ing) the email field.. but down in while loop you are also requesting $row['id'] which should actually be giving you error, but i guess it wont because you are using @ for all mysql functions.

anyway, you might want to do select *

secondly, in your while, you are doing:
$email = $row['email];

but that is simply reseting the $email each time it is called in a loop, i.e. the previous values are being erased. if you want to send mail to all of those returned by the select query, you might want to do:

$email .= $row['email'].', ';

regards,
Daarius...

justinb

O.k. thanks daarius,

I don't understand the all * ( i don't want to select all fields only email ) ,but I changed it to this, and it still doesn't work (I am a newbie, been learning it 2 weeks in school )

$db_name = "ecomphpdb";

$table_name = "justin_contacts";

$connection = @mysql_connect("localhost", "ecomphpstudents", "makesites") or die("Couldn't connect - please try later.");

$db = @mysql_select_db($db_name, $connection) or die("Error2 - Couldn't connect - please try later.");

$sql = "SELECT email

    FROM $table_name";

$result = @($sql, $connection) or die("Error3 - Couldn't connect - please try later.");

// while there are rows of results to get from the database table

while($row = @mysql_fetch_array($result))

{ //start while

//new variable $id holds the id for the first row in the result array called $row

 $email = $row['email'].', ';

} //end while

justinb

I tried this as well, it didn't work

$sql = "SELECT * FROM justin_contacts WHERE email";

siwis

assuming you might not have already sorted it, the problem, to me, is that you are not calling your mail() function until you've finished lloping through the email addresses. You mail() call needs to within your while statement.

Here's an excerpt from mine: (there are a large number of variables which are passed through from previous queries, but you should be able to get an idea of what is occuring.....

$addr_query = mysql_query("SELECT address FROM $addresstable ORDER BY address ASC",$db);
while ($addresses = mysql_fetch_array($addr_query))	{
	$email = $addresses['address'];
	$email = trim($email);
	$disclaimer = str_replace("%unsubscribeurl%", "$UNSUBSCRIBE_URL", $disclaimer_msg);
	$disclaimer = str_replace("%email%", "$email", $disclaimer);
	$sentmsg = "$list_name\n\n$message\n\n";
		if ($send_sig == 1)	{
			$sentmsg .= "$signature\n\n";
		};
	$sentmsg .= "+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n$disclaimer"; 
	$mailheaders = "From: \"$sender_name\" <$sender_email>\nReply-To: $reply_to\nX-Sender: $owner_email\nX-UnsubscribeURL: $UNSUBSCRIBE_URL&email=$email\nX-Mailer: PHPML V1.0 http://www.siwis.co.uk/\nX-AntiSpam: PHPML did not send you this email, review below for sender info.\nX-AntiSpam: Sent by http://$site_url\nX-AntiSpam: Server Administrator for abuse reports abuse@siwishost.co.uk\n";

############################# MAIL SENDING ##########################
mail($email, $subject, $sentmsg, $mailheaders);
#################################################################
?>
Dispatched to <b><?PHP echo $email; ?></b>...........OK<br>
<?PHP
$sent++;
$total_sent++;
if ($sent == "100") {
sleep(5);
$credit_used++;
$sent = 0;
}
unset($email);
unset($sentmsg);
unset($mailheaders);
unset($disclaimer);
}; // END of while ($addresses = mysql_fetch_array($addr_query))

BEWARE of LINE WRAPS