can anyone help me out? (code to upload)

Anon

I want to make a form that lets you browse and upload either a gif ir a jpeg, and I got this code: (with help from a tutorial)

<?php
//Defining Variables
$supported_type1 = ".gif";
$supported_type2 = ".jpeg";
$website_url = "http://novaz3ro.com/";
$absolute_path = "/"; //path to where images are uploaded
$sizelimit = "no"; //no size limit for the image(s)
$check1 = "image/gif"; //GIF file type.
$check2 = "image/jpeg"; //Jpeg file type.

$log = "<br>";

//Checks if a filename was specified
if ($uploaded_image_name = "") {
$log .= "No file was specified";
}
//Check if the filename is being used by another image and adds to the log if it is
if ($uploaded_image_name != "") {
if (file_exists("$absolute_path/$uploaded_image_name")){
$log .= "An image with the same name currently exists, the upload could not be processed.<br>";
}
//Check if the file is an image
if (($uploaded_image_type == $check1) or (uploaded_image_type == $check2)) {
//Copys the image to the actual host and adds to the log if the upload was unsuccessful.
@copy($uploaded_image, "$absolute_path/$uploaded_image_name") or $log .= "The image could not be copied to the host, please try again.<br>";
}
if (file_exists("$absolute_path/$uploaded_image_name")) {
$log .= "Upload was successful, your image is located at $website_url/$absolute_path/$uploaded_image_name.<br>";
} else { $log .= "The file trying to be uploaded is not a supported file type, please make sure the file is a $supported_type1 or a $supported_type2.<br>";
}
}
?>
<head><title>File Upload v.1</title></head>
<body>
<center>
<?php
echo "$log";
?>
<a href="upload.php">Upload another image</a>
</center>
</body>

I get nothing back from the echo "$log"; command and I tried putting $log = "test"; at the beggining of the script and it worked, so that means nothing getting added to the log. And the real problem is that the file does'nt get uploaded. if anyone can point me out the flaw that would be great,

thanx

Anon

i found one typo:

//Checks if a filename was specified
if ($uploaded_image_name = "") {
$log .= "No file was specified";
}
u have to have "==" instead of "=" if you are testing a condition.

so it shudd look life:

//Checks if a filename was specified
if ($uploaded_image_name == "") {
$log .= "No file was specified";
}

hope dat helps,
r O h I t H

Anon

well, at least now it reports the error when I echo the $log. the only thing is that it says that I did'nt specify a filename.

can anyone help?

thanx

by the way, the script is located at >> http://novaz3ro.com/scripts/upload/upload.php

rohithmr

yo,
My guest guess is that you have register_globals turned OFF. It it is, (and it shudd be) you will have to change some parts of your code. If the register_globals is turned ON, just change the variable names accordingly(in the following code).

Also notice that I took out the "@" infront of teh "copy" so that it will show the actual error.

try this:

*************** START CODE*******

<?php
//Defining Variables
$supported_type1 = ".gif";
$supported_type2 = ".jpeg";
$website_url = "http://novaz3ro.com";
$absolute_path = "/"; //path to where images are uploaded
$sizelimit = "no"; //no size limit for the image(s)
$check1 = "image/gif"; //GIF file type.
$check2 = "image/jpeg"; //Jpeg file type.

$log = "<br>";

//Checks if a filename was specified
if ($POST['uploaded_image']['name'] == "") {
$log .= "No file was specified";
}
//Check if the filename is being used by another image and adds to the log if it is
if ($POST['uploaded_image']['name'] != "") {
if (file_exists("$absolute_path/{$POST['uploaded_image']['name']}")){
$log .= "An image with the same name currently exists, the upload could not be processed.<br>";
}
//Check if the file is an image
if ($POST['uploaded_image']['type'] == $check1 || $POST['uploaded_image']['type'] == $check2) {
//Copys the image to the actual host and adds to the log if the upload was unsuccessful.
copy($POST['uploaded_image']['tmp_name'], "$absolute_path/{$POST['uploaded_image']['name']}") or $log .= "The image could not be copied to the host, please try again.<br>";
} else { $log .= "The file trying to be uploaded is not a supported file type, please make sure the file is a $supported_type1 or a $supported_type2.<br>";
}
if (file_exists("$absolute_path/{$POST['uploaded_image']['name']}")) {
$log .= "Upload was successful, your image is located at $website_url/$absolute_path/{$_POST['uploaded_image']['name']}.<br>";
} else {
$log .= "Upload Failed! Please try again.";
}
}
?>
<head><title>File Upload v.1</title></head>
<body>
<center>
<?php
echo "$log";
?>
<a href="upload.php">Upload another image</a>
</center>
</body>

********* END CODE******

rohithmr

btw ru using a windows or *nix machine?

cuz im usin WIndows and in my upload script, i had to specify the COMPLETE absolute path to where the image is goin to be copies.

(ex: c:/path/to/folder);

I dunno abt *nix.

Anon

I'm using windows. I yet have to try out the srcipt you gave me but that does that global thing mean?

Anon

I tried your script and the same thing happens, it says no filename was entered, here's the code for the form if you think you need it:

<head><title>Upload a File</title></head>
<body>
<form method="post" action="upload_process.php" enctype="multipart/form-data">
<Input type="file" name="uploaded_image" size="30"><p>
<input type="submit" value="Upload Image">
</form>
</body>

rohithmr

register_globals is a new feature in PHP. What is basically does is, it controls where the value comes from. For example, if you set a cookie on a client computer in page 1 and allows access to page2 if teh cooike is present, the user can easily forge his way to page2 by doing this:

http://somedomain.com/pag2.php?cookiename=value.

With register_globals enabled the the value of "cookiename" HAS to come from a cookie, you cannot set the value in the URL or uisng a POST request. So everything except $_COOKIE['cookiename'] will test undefined.

Now back to your problem. If you have a lot of scripts in ur server, better start converting them so that they are compatible with regiser_globals turned OFF. Now the last this i wudd consider is, in ur script where it sayz
$absolutepath="/";

change it to

$absolutepath="c:/path/to/the/ACTUAL/folder";

williamisis

when i browse the page http://novaz3ro.com/scripts/upload/upload.php
,after clicking the button UPLOAD,i get this msg THE FILE DOSE'NT EXIST.
what is up?

bye the way,i am a chinese student.my english is NOT very good.

williamisis

my view:
before u copy the file,why dont u print the value of yr source path and the target path?
it may be useful!

siwis

WHere are you getting the value for $uploaded_image_name from?

You would be better to actual test for the existence of the actual image array upon upload rather than testing for the existence of an actual filename.

Lets assume your form field for the image is called "image"

Once it is uploaded, there is an image array $image

So initial;ly to check whether an image has been uploaded do a check like this:
if ($image != "none") {
rest of code to check filetype
} else {
Report no image uploaded script.
};

Next, the image array ($image) is automatically assigned to the following variables by the upload engine itself:
$image_name
$image_size
$image_type

So I run a pretty simple function call on it:

function getFileExtension($str) {
$file_detail = explode(".", $str);
$file_name = $file_detail[0];
$ext = $file_detail[1];
return $ext;
}

$pext = getFileExtension($img_orig_name);
$pext = strtolower($pext);
if (($pext != "jpg") && ($pext != "jpeg") && ($pext != "gif") && ($pext != "png")){
Give error message about unsupported formats
} else {
Process the image
};

HTH

Anon

thanx all, but the problem isn't errors in the script, it's that the image isn't getting uploaded, I don't really mind if it gives a phony log, I can fix that after, but the problem is the the image is not getting uploaded.

thanx

siwis

is your form set to use the correct type?

ie <form action="<?PHP echo "$PHP_SELF"; ?>" enctype="multipart/form-data">

If enctype="multipart/form-data" isn't specified the file will not be uploaded anyway.

If however it is specified it is most likely a local configuration issue with the server onto which your files are destined.

Anon

yeah, I posted my form beffore:

siwis

So, without sounding stupid, how exactly do you know that the file is NOT being uploaded?

The script you posted at the every top of this thread had (which somebody else pointed out before) potential problems with filepaths.

Do an extremely simple test.
From your form, upon upload, just get the processor section of your script to echo the following to screen:

(assumes fieldname in form called "uploaded_image")

echo "$uploaded_image";
echo "$uploaded_image_name<br>\n";
echo "$uploaded_image_size<br>\n";
echo "$uploaded_image_type<br>\n";
unlink($uploaded_image);

Then just paste back the output to this forum. Don't try to save or move the image, lets just ensure whether, or not, it is actually making it up into the default temp folder for php on your hosts server.

Anon

ok, I'll try that when my web host gets back online. by the way, I know the files isn't getting uploaded since I actually checked using an ftp program and no file was uploaded.

siwis

Henri,

Your code (taken from first post);

Your problem is most likely within your $absolute_path variable.

Assuming that you are working on a *nix server, the image uploaded initially gets uploaded to (unless specified otherwise) php's temp folder (which you may discover by doing a phpinfo().

So in your script you then ask php to copy the image:
@copy($uploaded_image, "$absolute_path/$uploaded_image_name")

which means that php will attempt to copy the image to //$uploaded_image_name
Now forgive me if you've defined something elsewhere, but if you're on *nix, you (and httpd) simply don't have permission to write a file to the very root of the server drive. This would be outside of your own web treee, and even if the file did get copied successfully (which I seriously doubt) you certainly wouldn't find it within your web tree via ftp.

$absolute_path should be defined as something like (and this is a path on my own server) "/home/sites/siteXX/web/uploads" and then you'll need an additional variable to define the web version of that path (ie /uploads).

You've got to remember that php runs, not as your username, but as the user httpd which means it can read almost any folder with suitable permissions on the server. You via ftp on the other hand, will be restricted to viewing YOUR owned files on the server

I would hazard a guess that the file is indeed getting uploaded but the file cannot be saved to the location you are specifying. Hense why the output from my previous post is so important. If you receive an output (and it will look something like this:

ORIGINAL IMAGE
/tmp/phpWmoSW4
Friend.jpg
62050 bytes
image/pjpeg

because it takes that information from the temp file. If your temp file exists, the problem lies within the rest of the code handling that image.