Bloody MySQL

Anon

$string = "INSERT INTO lessons VALUES('" . $POST['spacecraft'] . "','" . $POST['category'] . "','" . $POST['source'] . "','" . $POST['info'] . "');";
$insert = mysql_query($string);

I have that, trying to insert some data into a table... It gives no errors, but it also gives not data to the table...

does anyone have any idea why that might be?

fitzbean

Think you got an extra ; .. no need for one of those at the end of a mySQL statement

$string = "INSERT INTO lessons VALUES('" . $POST['spacecraft'] . "','" . $POST['category'] . "','" . $POST['source'] . "','" . $POST['info'] . "')";
$insert = mysql_query($string);

this should also work, and reduce the confusing look of the above:

$string = "INSERT INTO lessons VALUES('${POST['spacecraft']}','${POST['category']}','${POST['source']}','${POST['info']}')";

let me know if that works..

uatec

no, it didnt work...
i think it had the same problem as my peice of script though... becuase it was exactly the same as before...

siwis

Assuming you are specifying the correct number of fields for your database (as I can't see a field that would equate to a primary key or ID field):

$spacecraft = $POST['spacecraft'];
$category = $POST['category'];
$source = $POST['source'];
$info = $POST['info'];

$string = "INSERT INTO lessons VALUES('$category','$category','$source','$info')";
$insert = mysql_query($string);

If you have more fileds than just the four within your table, ie an auto-incrementing ID field, you also need to specify it within your sql. So assuming the table has 5 fields, the first of which is ID:

$spacecraft = $POST['spacecraft'];
$category = $POST['category'];
$source = $POST['source'];
$info = $POST['info'];

$string = "INSERT INTO lessons VALUES('', '$category', '$category', '$source', '$info')";
$insert = mysql_query($string);

siwis

oops, just realised I doubled up $category when pasting!

First instance of $category in the sql should in fact be $spacecraft!

jesus_hairdo

have you tried change $insert = mysql_query($string);
to

$insert = mysql_query($string) or die(mysql_error());

This should return any MySQL errors. PHP only reports PHP syntax & parse errors, and wont report any errors in your SQL code.

Jamie