Add to an array with a function?

[johnnybravo]

Hi.

I'm trying to write a function that will validate input from a text field and (if necessary) add errors to an $errors[] array. I thought it would be simple enough, since appending to a string within a function seems to be straightforward, but apparently not. Here's the function so far:

function validateMe($thisValue, $thisRequired, $thisPattern, $thisError) {
  if ($thisRequired == "y" and $thisValue == "") {
    $errors[] = "No ". $thisError ." entered.";
  } elseif ($thisValue != "" and $thisPattern != "none" and !ereg($thisPattern,$thisValue)) {
    $errors[] = "Invalid ". $thisError ." format.";
  }
}

And I'm calling it like this, with a numerical regex for argument's sake (heh heh... hoo... I kill me...):

	validateMe($field,"y","[0-9]+","field description");

I tested it with some additional tweaks to make sure the conditions of the if statements were being met, and they are. I also know that the statement that adds the error works when performed outside of a function. However, after feeding validateMe form data that I know is bad, $errors[] still remains empty. I'm sure it's something dumb that I'm missing, but I've read all I can find in the manual about how functions deal with arrays, and I'm stumped.

Help?!? Much appreciated...

-- Bravo

P.S. I know classes are probably a better way to go, but I'm working with legacy code and this marginally less painful, he said with a sigh.

[Weedpacket]

Functions work with arrays in the same way they work with other variables. If you want a function to work on a variable that is defined outside the function, you need to declare it as "global $error;" first:

function validateMe($thisValue, $thisRequired, $thisPattern, $thisError) { 
global $error;
/*...*/
}

Otherwise, the function creates its own $error variable and works on that. Then it gets destroyed when the function ends.

Alternatively, you can modify the function to receive a reference to the $error array:

function validateMe($thisValue, $thisRequired, $thisPattern, $thisError, &$error)

Notice the '&' character. Without it, the function will work on a copy of the $error array and leave the original untouched; with it, it will work on the original (which is what you want). The advantage is that you can have more than one "error" array, and work on each independently, by choosing which one you pass to the function. The disadvantage is that it means adding the variable to all your uses of the function.

One or the other of these solutions will get you what you want.

[intenz]

Don't know.
Try this...

function validate($value,$required,$pattern,$error)
{
     global $errors;

 if($required == 'y' && $value == '')
      $errors[] = 'No ' . $error . 'entered.';
 elseif(!$value && !$pattern && (!ereg($pattern,$value)))
      $errors[] = 'Invalid ' . $error . ' format.';
}

[johnnybravo]

Could you guys rock any harder. In addition to working like a charm, the ampersand, with your multiple error array suggestion, looks very likely to solve another problem that I haven't bothered looking at yet.

Mucho gracias.

-- Bravo