no entries are saved in my db

[floppi]

Hi,
I created two scripts. The first one should take the entries of the gb-file and save it in my db. The other one should take these entries to display it on screen. Like a typical guestbook-script.

But my problem is, when I fill out the first script and click to submit nothing happens. Only the file is reloaded and the entrie is away.

I used this to submit the entrie:

if ($submitted) {
	$name = trim($name);
	$email = trim($email);
	$addy = trim($addy);
	$comments = trim($comments);

	$pattern = "^([0-9a-z]+([0-9a-z\.-_]+)@([0-9a-z\.-_]+)\.([0-9a-z]+)";
if ($name == false) { 
	print ("$fontinfo The form value <b>name</b> was not completed!<br> $fontinfo2");
} if ($email == false) {
	print ("$fontinfo The form value <b>email</b> was not completed!<br> $fontinfo2");
} if ($comments == false) {
	print ("$fontinfo The form value <b>comments</b> was not completed!<br> $fontinfo2");
} else {
$link = mysql_connect($host, $user, $password);
$datum = date("Y-m-d H:i:s",time());
$query = "INSERT * INTO $tablename VALUES ('', '$name', '$email', '$addy', '$datum', '$comments')";
if (mysql_db_query ($dbname, $query, $link)) {print ("<center><font face=verdana size=1 color=#000000>Thx for your entrie<br><a href=\"$home\">Home</a> | [<a href=\"cdlegere.php\">view</a> ]</font></center>");}
else {print ("<center><font face=verdana size=1 color=#000000>Error. Please try again.<br><a href=\"$home\">Home</a> | <a href=\"cdlegere.php\">view</a></font></center>");}
mysql_close ($link);

Whats wrong with this....?
thx Floppi

[siwis]

Firstly, what is the form ation you specified in the form used to collect the user data?

Secondly, you've included an ereg type character validation string and yet I don't see it used anywhere?

Thirdly, it should be INSERT INTO $tablename VALUES()
NOT
INSERT * INTO

Try the following mods as well:
if ($name == "")
if ($email == "")
if ($comments == "")

if (mysql_query ($dbname, $query, $link))

[floppi]

1. I use the post method. I hope the tag I use is correct. <form action=cdscribere.php method=post>

2. I do not know what you mean with "ereg type character validation string". I never heard about this. I use it? I don't know....

3. I changed the script though I have only seen the version with * but that is not important.

I don't know what I have made wrong or what I have forgotten in the script

thx floppi

[tomhath]

From what you said it sounds like you are posting the form to the wrong page (to itself instead of to the page that updates the database).

IT doesn't look like what you posted here will compile, it's missing some "}". And as siwis mentioned, you set variable $pattern but never use it.

[siwis]

Originally posted by floppi
1. I use the post method. I hope the tag I use is correct. <form action=cdscribere.php method=post>

OK, the first thing that strikes me in this case is that you are not correctly checking for a form submission.
The NAME= of your Submit button becomes a variable upon which you can check. Thus:
<input type="submit" name="submit" value="Submit"> within your form creates a variable upon submission of $submit so your check for second pass would be:

if ($submit){
}

2. I do not know what you mean with "ereg type character validation string". I never heard about this. I use it? I don't know....

$pattern = "^([0-9a-z]+([0-9a-z\.-_]+)@([0-9a-z\.-_]+)\.([0-9a-z]+)";

[floppi]

Thx, this error message is away, but another appeared.

After clicking submit this messages is on screen:

Warning: Wrong parameter count for mysql_query() in c:\hp\cdscribere.php on line 12 DB-Error. Please try again

The code for this part is:

$link = mysql_connect($host, $user, $password);
$datum = date("Y-m-d H:i:s",time());
$query = "INSERT INTO $tablename VALUES ('', '$name', '$email', '$addy', '$datum', '$comments')";
if (mysql_query ($dbname, $query, $link)) {print ("Thx for signing");}
else {print ("DB-Error. Please try again
mysql_close ($link);

Line 12 starts with if (mysql_query ....

thx floppi

[siwis]

if (mysql_query ($dbname, $query, $link)) {print ("Thx for signing");} 

should most likely be:

if (mysql_query ("$query", $link)) {print ("Thx for signing");} 

[floppi]

The Script-Errors are gone. Thx god but now .....

the DB-Error from Line 13 is active. Now it is complicated because I am not familiar with MySql. I just copy the line which I used to create the DB.

$query = "create table $tablename (id int unsigned not null auto_increment primary key, name Text, email text, addy text, datum datetime, comments longtext)";