help anyone?

Henri

I made this script but it keeps telling me:

Parse error: parse error in /home/virtual/site191/fst/var/www/html/t_up/index.php on line 59

this is the script, if any of you could tell me what you think is making that error appear I would be very thankful.

<?php
//You may edit this script but not distribute an edited version without permission from the author.
include("configuration.inc");
$action = "";
switch ($action) {
default:
echo "
<html><head><title>Upload a file v2.0</title>
<style>
body {font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 8pt; font-color: #000000;}

table {font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 8pt; text-decoration: none; font-color: #000000;}

a:link, a:visited, a:active {color: #000000}

a:hover {COLOR: #FAFAFA; BACKGROUND-COLOR: #000000;}
</style>
</head>
<body bgcolor=\"#FAFAFA\">
<center>
<table width=\"700\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" border-color=\"#000000\">
<TR height=\"30\">
<TD bgcolor=\"#FAFAFA\" align=\"center\" valign=\"middle\">Upload a file.</TD>
</TR>
</table>

<p>

<table width=\"700\" cellspacing=\"0\" cellpadding=\"0\" border=\"1\" border-color=\"#000000\">
<TR height=\"400\">
<TD bgcolor=\"#FAFAFA\" align=\"center\" valign=\"middle\">
<form action=\"index.php?action=upload\" method=\"post\" enctype=\"multipart/form-data\">
Choose a file for upload:<p>
<input type=\"file\" name=\"file\"size=\"30\" style=\"font-family: v; font-size: 8pt; color: #F8F8F8; border: 1px solid #000000; padding-left: 4; padding-right: 4; padding-top: 1; padding-bottom: 1\">
<button type=\"submit\" style=\"font-family: v; font-size: 8pt; color: #F8F8F8; border: 1px solid #000000; padding-left: 4; padding-right: 4; padding-top: 1; padding-bottom: 1\">Upload</button>
</form>
</TD>
</TR>
</table>

<p>
//You may not edit or remove the following
<table width=\"700\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" border-color=\"#000000\">
<TR height=\"30\">
<TD bgcolor=\"#FAFAFA\" align=\"center\" valign=\"middle\">Copyright 2002~2003 <a href=\"http://novaz3ro.com/\">H-L.C.</a> © All rights reserved.</TD>
</TR>
</table>

</body>
</html>";
break;

case "upload":
include("configuration.inc");
//Check file size.
if ($size_limit = yes) {
if ($bytes_limit > $file_size) {
$log .= "File size was too big.<br>"
}
}

//Checks if a file was specified.
if ($file_name == ""){
$log .= "No file was specified.<br>"
}

//Check if file exists
if (fileexists($absolutepath/$file_name)){
$log .= "The file already exists, please try again with a different file name.<br>"
}

//Copys the file
if ($log == ""){
@copy ($file, "$absolutepath/$file_name") or $log .= "The file could not be uploaded, please ask the website administrator to CHMOD 666 the absolute path.<br>"

if ($log == ""){
$log .= "The file was uploaded, it is located at:<br><a href=\"$site/$absolutepath/$file\">$site/$absolutepath/$file</a>"
}

echo "
<html><head><title>Upload a file v2.0</title>
<style>
body {font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 8pt; font-color: #000000;}

table {font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 8pt; text-decoration: none; font-color: #000000;}

a:link, a:visited, a:active {color: #000000}
a:hover {COLOR: #FAFAFA; BACKGROUND-COLOR: #000000;}
</style>
</head>
<body bgcolor=\"#FAFAFA\">
<center>
<table width=\"700\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" border-color=\"#000000\">
<TR height=\"30\">
<TD bgcolor=\"#FAFAFA\" align=\"center\" valign=\"middle\">Upload a file.</TD>
</TR>
</table>

<p>

<table width=\"700\" cellspacing=\"0\" cellpadding=\"0\" border=\"1\" border-color=\"#000000\">
<TR height=\"400\">
<TD bgcolor=\"#FAFAFA\" align=\"center\" valign=\"middle\">

$log

</TD>
</TR>
</table>

<p>
//You may not edit or remove the following
<table width=\"700\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" border-color=\"#000000\">
<TR height=\"30\">
<TD bgcolor=\"#FAFAFA\" align=\"center\" valign=\"middle\">Copyright 2002~2003 <a href="http://novaz3ro.com/">H-L.C.</a> © All rights reserved.</TD>
</TR>
</table>

</body>
</html>";
break;
}
?>

thank you very much.

mlweb01

The problem is on line 58:

$log .= "File size was too big.<br>"

You need to add a semi-colon to the end of the line.
In PHP, it is always a good idea to check the line BEFORE the error, especially if there is nothing wrong with the line number that it gives you.

Henri

ah, ok, thanx a lot. I'll remember that tip😉

Henri

dang, I just fixed up the code and the thing you told me to change works, I also added some "\"s I forgot to insert beffore but it now says:

Parse error: parse error in /home/virtual/site191/fst/var/www/html/t_up/index.php on line 123

the thing is that line 123 is the line with ?> on it :-s

does anyone know what to do?

thanx

hand

Did you somewhere forget to close an if } ? May be here ?

//Copys the file
if ($log == ""){
@copy ($file, "$absolutepath/$file_name") or $log .= "The file could not be uploaded, please ask the website administrator to CHMOD 666 the absolute path.<br>"

if ($log == ""){
$log .= "The file was uploaded, it is located at:<br><a href=\"$site/$absolutepath/$file\">$site/$absolutepath/$file</a>"
}

In your script I can detect much more missing semi-colons.
Please correct all these lines ...

Henri

thank you, and I know, I fixed those up, just did'nt post an updated version of the script.

hand

What's about the ifs?

victordb

the 'if' statements must always have a close '}' on them, but only if they had an opening '{' on them.