anyone willing to help me gets a cookie!

Henri

alright, here's the deal guys. I want the sript to to get the pass from the database in the same "row" as the username correspondant to it.

heres the code:

<?php
$db_name = "novaz3ro_com"; 
$connect = mysql_connect('localhost','***','***'); 
$db = mysql_select_db($db_name,$connect);

$query1 = mysql_query("SELECT password FROM adminlogin WHERE username = '$username'", $connect);
$row = mysql_fetch_array($query1); 
$password_check = $row['password'];

if ($password_check == $password) 
{
echo "

<html><head><title>Administrative Login</title>
<style>

a:link {color: black;}
a:visited {color: black;}
a:active {color: black;}
a:hover {color: #FFFFFF; background-color: #000000;}

body { 	SCROLLBAR-FACE-COLOR: #FFFFFF;
	   SCROLLBAR-HIGHLIGHT-COLOR: #F6F6F6;
	   SCROLLBAR-SHADOW-COLOR: #3A432C;
	   SCROLLBAR-3DLIGHT-COLOR: #000000;
	   SCROLLBAR-ARROW-COLOR: #FFFFFF;
	   SCROLLBAR-TRACK-COLOR: #EDEDED;
	   SCROLLBAR-DARKSHADOW-COLOR: #EDEDED;
}
</style>
</head>

<body bgcolor=\"#F6F6F6\">

<center>

<table size=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" bordercolor=\"#000000\">

<br><br>

<TR height=\"20\">
<TD align=\"center\" valign=\"middle\" bgcolor=\"#EDEDED\" width=\"500\"><font color=\"black\" size=\"3\">Administrative Logon</font></TD>
</TR>
</table>

<br>

<table size=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" bordercolor=\"#000000\">

<TR height=\"200\">
<TD align=\"center\" valign=\"middle\" bgcolor=\"#EDEDED\" width=\"500\">

<a href=\"admincp.php\">Go to adminCP</a>

</TD>
</TR>

</table>

</body>
</html>";
}else{
echo "

<html><head><title>Administrative Login</title>
<style>

a:link {color: black;}
a:visited {color: black;}
a:active {color: black;}
a:hover {color: #FFFFFF; background-color: #000000;}

body { 	SCROLLBAR-FACE-COLOR: #FFFFFF;
	   SCROLLBAR-HIGHLIGHT-COLOR: #F6F6F6;
	   SCROLLBAR-SHADOW-COLOR: #3A432C;
	   SCROLLBAR-3DLIGHT-COLOR: #000000;
	   SCROLLBAR-ARROW-COLOR: #FFFFFF;
	   SCROLLBAR-TRACK-COLOR: #EDEDED;
	   SCROLLBAR-DARKSHADOW-COLOR: #EDEDED;
}
</style>
</head>

<body bgcolor=\"#F6F6F6\">

<center>

<table size=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" bordercolor=\"#000000\">

<br><br>

<TR height=\"20\">
<TD align=\"center\" valign=\"middle\" bgcolor=\"#EDEDED\" width=\"500\"><font color=\"black\" size=\"3\">Administrative Logon</font></TD>
</TR>
</table>

<br>

<table size=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" bordercolor=\"#000000\">

<TR height=\"200\">
<TD align=\"center\" valign=\"middle\" bgcolor=\"#EDEDED\" width=\"500\">

Login unsuccessful.<p>
<font size=\"2\"><a href=\"index.php\">Try again</a></font>

</TD>
</TR>

</table>

</body>
</html>";
}
?>

My problems are:

Even when I specify the right username and password, it says that the login was unsucessful.
When I enter nothing and just hit "Login" on the form, it acts as if I logged in successfully.

any help would be greatly appreciated,

thank you

Weedpacket

Are you sure $username and $password have the values they should? Try echoing them before doing the query to see what they contain.

PS: When you're outputting a big block of HTML it's a lot easier in more ways than one (e.g. PHP processes it faster and you don't have to escape all your ") to just go:

<?php
if($this){
?>
Do a lot of HTML stuff here if "$this" is true.
<?php
}
else
{
?>
Do a lot of HTML stuff here if "$this" is false.
<?php
}
?>

Henri

ok, thanx for the tip.

I echoed both $password and $username and the info got thru.

I also forgot to mention this, I get an error saying this on check.php:

Warning: Supplied argument is not a valid MySQL result resource in /home/virtual/site191/fst/var/www/html/sea/staff/check.php on line 7

here are the surrounding lines of code:

#1 <?php
#2 $db_name = "novaz3ro_com"; 
#3 $connect = mysql_connect('localhost','****','****'); 
#4 $db = mysql_select_db($db_name,$connect);
#5
#6 $query1 = mysql_query("SELECT password FROM adminlogin #7 WHERE username = '$username'", $connect);
#8 $row = mysql_fetch_array('$query1');
#9 $password_check = $row['password'];

thanx

Weedpacket

Well, there's the problem: if the error is happening on the line where you send the query, then your connection is bad ($connect contains an invalid database resource). MySQL is having the the problem, in other words.

Add some diagnostic messages to see just what problems MySQL is having:

$connect = mysql_connect('localhost','****','****') or die "Couldn't connect to DB host. MySQL sez: ".mysql_error(); 

$db = mysql_select_db($db_name,$connect) or die("Failed to select database $db_name. MySQL sez: ".mysql_error());

$sql = "SELECT password FROM adminlogin WHERE username = '$username'";
$query1 = mysql_query($sql, $connect) or die("Database choked on query ($sql). MySQL sez: ".mysql_error());

Henri

I got no timeouts or SQL errors...

this is my "new" version of the code:

<?php
$db_name = "novaz3ro_com"; 
$connect = mysql_connect('localhost','***','***') or die("Couldn't connect to DB host. MySQL sez: ".mysql_error());
$db = mysql_select_db($db_name,$connect) or die("Failed to select database $db_name. MySQL sez: ".mysql_error());

$sql = "SELECT password FROM adminlogin WHERE username = '$username'";
$row = mysql_query($sql, $connect) or die("Database choked on query ($sql). MySQL sez: ".mysql_error());
$password_check = $row['password'];

if ($password_check == $password) 
{
echo "

<html><head><title>Administrative Login</title>
<style>

a:link {color: black;}
a:visited {color: black;}
a:active {color: black;}
a:hover {color: #FFFFFF; background-color: #000000;}

body { 	SCROLLBAR-FACE-COLOR: #FFFFFF;
	   SCROLLBAR-HIGHLIGHT-COLOR: #F6F6F6;
	   SCROLLBAR-SHADOW-COLOR: #3A432C;
	   SCROLLBAR-3DLIGHT-COLOR: #000000;
	   SCROLLBAR-ARROW-COLOR: #FFFFFF;
	   SCROLLBAR-TRACK-COLOR: #EDEDED;
	   SCROLLBAR-DARKSHADOW-COLOR: #EDEDED;
}
</style>
</head>

<body bgcolor=\"#F6F6F6\">

<center>

<table size=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" bordercolor=\"#000000\">

<br><br>

<TR height=\"20\">
<TD align=\"center\" valign=\"middle\" bgcolor=\"#EDEDED\" width=\"500\"><font color=\"black\" size=\"3\">Administrative Logon</font></TD>
</TR>
</table>

<br>

<table size=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" bordercolor=\"#000000\">

<TR height=\"200\">
<TD align=\"center\" valign=\"middle\" bgcolor=\"#EDEDED\" width=\"500\">

<a href=\"admincp.php\">Go to adminCP</a>

</TD>
</TR>

</table>

</body>
</html>";
}else{
echo "

<html><head><title>Administrative Login</title>
<style>

a:link {color: black;}
a:visited {color: black;}
a:active {color: black;}
a:hover {color: #FFFFFF; background-color: #000000;}

body { 	SCROLLBAR-FACE-COLOR: #FFFFFF;
	   SCROLLBAR-HIGHLIGHT-COLOR: #F6F6F6;
	   SCROLLBAR-SHADOW-COLOR: #3A432C;
	   SCROLLBAR-3DLIGHT-COLOR: #000000;
	   SCROLLBAR-ARROW-COLOR: #FFFFFF;
	   SCROLLBAR-TRACK-COLOR: #EDEDED;
	   SCROLLBAR-DARKSHADOW-COLOR: #EDEDED;
}
</style>
</head>

<body bgcolor=\"#F6F6F6\">

<center>

<table size=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" bordercolor=\"#000000\">

<br><br>

<TR height=\"20\">
<TD align=\"center\" valign=\"middle\" bgcolor=\"#EDEDED\" width=\"500\"><font color=\"black\" size=\"3\">Administrative Logon</font></TD>
</TR>
</table>

<br>

<table size=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"1\" bordercolor=\"#000000\">

<TR height=\"200\">
<TD align=\"center\" valign=\"middle\" bgcolor=\"#EDEDED\" width=\"500\">

Login unsuccessful.<p>
<font size=\"2\"><a href=\"index.php\">Try again</a></font>

</TD>
</TR>

</table>

</body>
</html>";
}
?>

I now get no error, but still have the same problems I had beffore. When I enter nothing, it acts as if I logged in successfully and when I enter the right login and pass it acts as if I logged in unsuccessfully 😐

you can try for yourself here: http://novaz3ro.com/sea/staff/

can anyone help me out?

thanx a lot

by the way Weedpacket, do you have an AIM chat handle?

Weedpacket

Rewriting it for my own benefit I see exactly what the problem is:

You're trying to test $row['password'] when there is no such thing - $row is a resultset, not an array. So $password_check is always empty. So it matches an empty $password.

This is what I rewrote it as:

<html><head><title>Administrative Login</title>
<style>
a:link {color: black;}
a:visited {color: black;}
a:active {color: black;}
a:hover {color: #FFFFFF; background-color: #000000;}
body {     SCROLLBAR-FACE-COLOR: #FFFFFF;
       SCROLLBAR-HIGHLIGHT-COLOR: #F6F6F6;
       SCROLLBAR-SHADOW-COLOR: #3A432C;
       SCROLLBAR-3DLIGHT-COLOR: #000000;
       SCROLLBAR-ARROW-COLOR: #FFFFFF;
       SCROLLBAR-TRACK-COLOR: #EDEDED;
       SCROLLBAR-DARKSHADOW-COLOR: #EDEDED;
}
</style>
</head>
<body bgcolor="#F6F6F6">
<center>
<table size="100%" cellpadding="0" cellspacing="0" border="1" bordercolor="#000000">
<br><br>
<TR height="20">
<TD align="center" valign="middle" bgcolor="#EDEDED" width="500"><font color="black" size="3">Administrative Logon</font></TD>
</TR>
</table>
<br>
<table size="100%" cellpadding="0" cellspacing="0" border="1" bordercolor="#000000">
<TR height="200">
<TD align="center" valign="middle" bgcolor="#EDEDED" width="500">
<?php

$username=$_POST['username'];
$password=$_POST['password'];

$db_name = "novaz3ro_com"; 
$connect = mysql_connect('localhost','***','***') or die("Couldn't connect to DB host. MySQL sez: ".mysql_error());
$db = mysql_select_db($db_name,$connect) or die("Failed to select database $db_name. MySQL sez: ".mysql_error());
$sql = "SELECT count(*) FROM adminlogin WHERE username = '$username' AND password='$password'";
$row = mysql_query($sql, $connect) or die("Database choked on query ($sql). MySQL sez: ".mysql_error());
$row = mysql_fetch_row($row);
if ($row[0]!=0)
{
	echo '<a href="admincp.php">Go to adminCP</a>';
}else{
	echo 'Login unsuccessful.<p><font size="2"><a href="index.php">Try again</a></font>';
}
?>
</TD>
</TR>
</table>
</body>
</html>

The crucial change is the addition of a mysql_fetch_row() line. I also fiddled with the query itself a touch 'cos I just like fiddling 🙂. You can change it back and then test for $row[0]==$password if you like. I just did it because $row[0]!=0 is probably a couple of clock cycles faster than $row[0]==$password 😃.

Henri

thanx a lot, it works well now, just that you can't have any spaces in your username, is there something that you could change to make that possible?

Weedpacket

Originally posted by Henri
thanx a lot, it works well now, just that you can't have any spaces in your username, is there something that you could change to make that possible?

😕 You mean it doesn't now and it should, or it does now and it shouldn't? There's nothing there stopping it at the moment.

Henri

it does'nt now and I don't really acre if it works ;-)

thanx a lot for the help, now all I need to know is how to get a piece of code at the beginning of every adminCP page that checks and blocks off the user if he did'nt login🙁

any clue on how to do that?

Weedpacket

You'll probably be wanting to use session variables to carry their username and maybe some related data, so you can check it on each page to see if it's set and/or in the database. But that's another story – or at least thread.