coding error (nned help please)

Henri

I keep on getting this error:

Parse error: parse error in /home/virtual/site191/fst/var/www/html/sea/staff/news.php on line 69

this is my code:

<?php include("session_check.inc") ?>

<?php
$db_name = "novaz3ro_com"; 
$connect = mysql_connect('localhost','***','***'); 
$db = mysql_select_db($db_name,$connect);
?>

<html><head><title>SEA adminCP v1.0</title>

<?php include("style.inc") ?>

</head>

<body bgcolor="#DEAD9D">

<center>

<img src="top_logo.gif">

<br><br>

<table size="100%" cellpadding="0" cellspacing="0" border="1" bordercolor="#000000">

<TR height="20">
<TD align="center" valign="middle" bgcolor="#AD8C8C" width="750"><font color="black" size="3">SEA adminCP v1.0</font></TD>
</TR>
</table>

<br>

<table size="100%" cellpadding="0" cellspacing="0" border="1" bordercolor="#000000">
<TR height="20">
<TD align="center" valign="middle" bgcolor="#AD8C8C" width="750"><font color="black" size="3"><?php include("menu.inc") ?></font></TD>
</TR>
</table>

<br>

<table size="100%" cellpadding="0" cellspacing="0" border="1" bordercolor="#000000">

<TR height="500">
<TD align="left" valign="top" bgcolor="#E7BD94" width="750">
<br>
<!-- body start --!>
<?php
$date = date("m.d.y");
switch ($action) {
default:
echo "<form method=\"post\" action=\"news.php?action=add\">";
session_register("username");
echo "<b>Author:</b> $username<br>
<b>Date:</b> $date<br>
<b>Subject:</b> <input type=\"text\" size=\"40\" name=\"article_subject\" name=\"article_subject\"><br>
<b>Content:</b><br>
<textarea name=\"article_content\" ROWS=\"12\" COLS=\"40\" name=\"article_content\">
</textarea>
</form>";
break;
case add:
$add_news = "<table width=\"100%\" cellpadding=\"0\" cellspacing=\"0\" border=\"0\">
<TR height=\"30\">
<TD bgcolor=\"#000000\" width=\"450\" align=\"left\" valign=\"middle\"><font size=\"2\">$article_subject</font> - <font size=\"2\">Posted @ $date by $username</font></TD></TR>
<TR>
<TD bgcolor=\"#002660\" width=\"450\" align=\"left\" valign=\"top\">$article_content</TD></TR>
</table>
<br><br><br>";
$query = "INSERT INTO SEA_news (content) VALUE ('$add_news');
$query_check = "mysql_query($query, $connect)";
mysql_query($query, $connect);
if ($query_check == TRUE) {
echo "<center>News was successfully updated.</center>";
}
}
?>
<!-- body end --!>
</TD>
</TR>

</table>

<br>

<table size="100%" cellpadding="0" cellspacing="0" border="1" bordercolor="#000000">
<TR height="20">
<TD align="center" valign="middle" bgcolor="#A89788" width="750"><font color="black" size="3">Copyright 2002~2003 © <a href="http://novaz3ro.com/">H-L.C.</a> Desing & PHP.</font></TD>
</TR>
</table>

</body>
</html>

any help would be greatly appreciated🙂

thanx

Henri

oh and I just noticed that if someone accesses the session_check.inc file, they can see everything on it (including the database password)

is there a way I can block viewing of the file?

thanx

elfynmcb

Hey,

The first error i noticed in the calling script is this:

<?php include("session_check.inc") ?>
...
<?php include("style.inc") ?>

should be:

<?php include("session_check.inc"); ?>
...
<?php include("style.inc"); ?>

secondly in the switch() control struct. the case statement should look like this:

case "foo":

or

case 'xyz':

and the syntax here:

$query = "INSERT INTO SEA_news (content) VALUE ('$add_news');
$query_check = mysql_query($query, $connect);

should be:

$query = "INSERT INTO SEA_news (content) VALUE ('$add_news')";
$query_check = mysql_query($query, $connect);

Get rid of these, and then see if more arrise...

Henri

thanx for the help, I'll let you know how it goes😉 but what about "hiding" the session_check.inc file?

EDIT:

I get this error:

Warning: Cannot send session cache limiter - headers already sent (output started at /home/virtual/site191/fst/var/www/html/sea/staff/news.php:1) in /home/virtual/site191/fst/var/www/html/sea/staff/news.php on line 51

EDIT2: XD I forgot to re-upload session_check.inc

but does anyone know how I could make that file non-accessible browser-wise?

Weedpacket

Originally posted by Henri
thanx for the help, I'll let you know how it goes😉 but what about "hiding" the session_check.inc file?

Oh, that's easy: rename it "check.inc.php" and update your includes likewise. Then if someone asks for "check.inc.php" the server will process it as a PHP file. Since it doesn't actuually produce any output of its own, all they'll get is a blank page.

The fancier approach is to fiddle with your .htaccess or equivalent to disallow ".inc" files from being served at all.

Henri

tahnx a lot man😉