Why isnt this working???

rapmonkey

First of all, here's my code:

<?php

if ($action == "viewallgames" ) { require "viewallgames.php"; }
elseif ($action = "viewdownloads" ) { require "viewdownloads.php"; }
elseif ($action = "viewlinks" ) { require "viewlinks.php"; }
elseif ($action = "viewreview" ) { require "viewreview.php"; }
else { echo '<p align="center"><font color="#FFFFFF" size="5"><u>RapMonkey GameCenter News</u></font>
<p align="center"><font color="#FFFFFF" size="3">07.30.02 - The RapMonkey Gaming Labs & Gamecenter sites are launched!</font>
<p align="center"><font color="#FFFFFF" size="3">07.30.02 - Quiz added. <a href="http://www.rapmonkey.com/quiz/pcgamer.htm">Are You The Ultimate PC Gamer?<p>'; }

?>

This code executes, but dispite the if and elseif statements, when there is no $action variable supplied, it acts as if $action = "viewallgames". Why is this doing this? It should work!

Weedpacket

Offhand I don't see why the "viewallgames" is the one being executed, but I do not you've got $action='foo' in many places where you mean $action=='foo'.

I'd rewrite this as a switch, myself (looks tidier, and PHP only needs to check the value of $action once, not four times):

switch($action)
case 'viewallgames':
require('viewallgames.php');
break;
case 'viewdownloads':
require('viewdownloads.php');
break;
...
default:
echo 'RapMonkey ... etc.';
}

ShawnD

well is viewgames an include or is it just seeing if the file is there?

rapmonkey

It checks, and if the file is there, then it displays it.

ShawnD

why require the check thing? just include it and if it isn't there then oh well.
here is what my site is like

<?php
	  if ($page == index) 
	  include("index_tfc.inc");

  elseif ($page == admins) 
  include ("admins_tfc.inc");

  elseif ($page == banlist)
  include("banlist_tfc.inc");

  elseif ($page == downloads)
  include("downloads_tfc.inc");

  elseif ($page == screenshots)
  include("screenshots_tfc.inc");

  elseif ($page == settings)
  include("settings_tfc.inc");
  ?>

rapmonkey

oh well, the switch code worked. 😃