help my Refer a Friend

Mobile

Hi everybody, below is my refer a friend script.

It sends the message no problem, but it brings up error messages on my thank you page (where the script is housed).

<?
$sitename=getenv("HTTP_HOST");
$message = "";
for ($i=0;$i<count($names);$i++){
$cur_name = $names[$i];
$cur_email = $emails[$i];
$message.="Look: $sitename\n\n";
$message.="Dear $cur_name,\n\n" // Fill your message in the space below.
."So and so. Visit this site please.\n\n"
."Thanks,\n\n
.$senders_name";
mail($cur_email,"Invitation from $senders_name",$message,"From: $senders_email"); - DAMN LINE 16
}
?>

Even though it sends the email I get these page errors -

Warning: Bad Message destination in D:\inetpub\websites\WebsiteVRM\sent.php on line 16

I entered my name and email, and two others, and it just displayed it all at the beginning, and didn't echo any error or warning

http://www.websitevrm.com/recommend.php

My form fields are named -

senders name = field name - senders_name
senders email = field name - senders_email

friends name = field name - names[]
friends email - field name - emails[]
friends name = field name - names[]
friends email - field name - emails[]
friends name = field name - names[]
friends email - field name - emails[]

dotwebbie

Instead, try this:

mail("$cur_email","Invitation from $senders_name","$message","From: $senders_email");

Mobile

I inserted that line and i still get the same errors. 🙁

http://www.websitevrm.com/recommend.php

dotwebbie

My apologies for taking so long to get back with you.

<?php
$site="yourname.com";
for($i=0; $i < count($towhom); $i++) {
$curname=$towhom[$i];
$curemail=$toemail[$i];
$body="Hi, $curname\n";
$body.="Please visit $site, it's great!";
$body.="\n\nSincerely,\n$cname\n$cemail";
$m=mail($curemail,"Invitation for $curname","$body","From: $curname <$curemail>");
}
if(!$m) {
print("mail failed. $cname, $cemail to $curemail, $curname");
}
else {
print("mail should be there.");
}
?>
<html>
<head>
</head>
<body>
<form method="post" action="tell2.php">
<input type="text" name="cname">your name<br />
<input type="text" name="cemail">your email<br />
<input type="text" name="towhom[]">their n<br />
<input type="text" name="toemail[]">their e<br />
<input type="text" name="towhom[]">their n<br />
<input type="text" name="toemail[]">their e<br />
<input type="text" name="towhom[]">their n<br />
<input type="text" name="toemail[]">their e<br />
<input type="submit">
</form>
</body></html>

Feel free to seperate the html from the php code or do whatever you want with it but it works the way it is. 🙂

I ended rewriting the thing because for some odd reason, no matter what I tried, I could not get your script to work. 🙁

Mobile

I added in the changes but it still sends the mail but with page errors - http://www.websitevrm.com/recommend.php - although I get a different error message now.

dotwebbie

Well, my debug was right, mail did fail. Which version of php are you using? Is register_globals on or off? Well, it has to be on since it picked up the senders name and email address . . . Did you make any changes? It works fine on my host. Sorry for the choppy sentences, I'm just thinking aloud.

Mobile

my friend script was loosely based on the script below which processes my contact us form no problem -

<?
$sitename=getenv("HTTP_HOST");
$message.="Site: $sitename\n\n";
while ( list( $key, $val )=each($HTTP_POST_VARS) )
{
$message .="$key : $val\n" ;
}
mail("myemailaddress","WebsiteVRM",$message,"From: mail@mysite.com");
?>

http://www.websitevrm.com/recommend.php - houses the form which calls up the processor page

http://www.websitevrm.com/sent.php - houses the processing script

I'm using the latest version of php. My contact us forms work and your script works too. Its just the small error that gets produced at the top of the page -

Warning: Bad Message destination in D:\inetpub\websites\WebsiteVRM\sent.php on line 13

Warning: Bad Message destination in D:\inetpub\websites\WebsiteVRM\sent.php on line 13
mail failed. hans, hans@cardriver.co.uk to ,

dotwebbie

Yeah, I don't get that. Why is it only picking up two of the variables? It works great on my site. If everything was left untouched, according to it, it is failing on the } at the end of the if(). Are you running Apache or IIS?

Mobile

i'm running iis on win 2000 server.

dotwebbie

Okay, since mail is failing, let's try a simple mail().

<?php
$m=mail("to@you.com", "Subject", "Hi!", "From: someone <you@you.com>");
if(!$m) {
print("failed! Check your mail settings in php.ini if you have access.");
}
else {
print("Supposed to be there waiting for you in your mailbox!");
}
print("No errors should be thrown, if there are, something is wrong with your php and/or IIS setup.");
?>

Mobile

Hey dotwebbie sorry for the delay. I put the code in and this is the output - http://www.websitevrm.com/sent.php

I hope it is something you were expecting.

dotwebbie

np. Actually, I meant in a new file. Sorry, my fault. 🙁

Mobile

you mean create a bare php page and insert your code in the head?

dotwebbie

Just create a php file with just that code I gave you last. Make sure of course to edit the attributes accordingly.