uploading file from within function php 4.2

spriggig

Hello and thank you for reading...

I'm trying to create a FUNCTION that takes the value of a

tag and uploads to a Unix server. I can make it work OUTSIDE of a function, but when I try to run it INSIDE a function, it looks like it can't see the value of the input tag, I get the error:

Warning: fopen("/users/ttspike/public_html/deluxe/learnphp/attachments/.", "w") - Invalid argument in /nfs/users/ttspike/public_html/deluxe/learnphp/uploadtest.php on line 69

Warning: Supplied argument is not a valid File-Handle resource in /nfs/users/ttspike/public_html/deluxe/learnphp/uploadtest.php on line 69

Here is a shortened version of my code, I've attached the full version in a text file as well:

<?php
include("accesscontrol.php");
if (!isset($submitted)) {
?>
<html>
<body>
<form enctype="multipart/form-data" method="post" action="<?=$PHP_SELF?>">
<input name="userfile" type="file" size="128">
<input name="submitted" type="submit" value="submit"></form>

</body>
</html>
<?php
} else {
upload_attachment($userfile);
}

function upload_attachment($userfile) {
if (file_exists($userfile)){
$file_size = filesize($userfile);

			 if ($file_size >= 3200000)  {  
		   		error("Maximum file size is 3.0 MB, please reduce file size and try again, or contact Darrin.");
				 }


			$this_name = "$currentuserID$userfile_name".".".$ext;

			$attachmentinsert = "INSERT INTO items SET
									i_file_attachment = '$this_name'";
			if (!$result = mysql_query($attachmentinsert)) {
	    				error("After Attachment Insert, a database error occurred in processing your ".
	        				  "submission.\\nIf this error persists, please ".
	        				  "contact darrin.");
    			}

			$thisfile = fread(fopen($userfile, "r"), filesize($userfile));
			$new_file = "/users/ttspike/public_html/deluxe/learnphp/attachments/$this_name";
			$filewrite = fwrite(fopen($new_file, "w"), $thisfile, filesize($userfile));

		} 
				exit;	
}

siwis

Well I tried it using a different approach, by using copy()

function file_process($file, $filename, $target) { 
	if (file_exists($file)){ 
		$file_size = filesize($file); 
		if ($file_size >= 3200000) { 
			error("Maximum file size is 3.0 MB, please reduce file size and try again, or contact Darrin."); 
			die;
		} 

	$newfile = "up_" . $filename; 	// <- Rename our original
	copy($file, $target . $newfile);		// <- Save our original to disk
} 
exit; 
}

Then in your second pass processing use something like:

<?
if ($action=="upload"){
$targetpath = "/home/sites/siteXX/web/path/to/target/folder/";
		file_process($fileupload, $fileupload_name, $targetpath);
};
?>

Tested AND works.

What I think is going wrong within yours is that you cannot use variables inside a function UNLESS you pass those variables in within the function call. Hense my function expects to receive 3 pieces of information. The actual uploaded file array, the name portion of that array AND the target location into which we want to save the file.

spriggig

Thank you for you help, I think I'm close but...

I get this: Warning: Array to string conversion in /nfs/users/ttspike/public_html/deluxe/learnphp/newprocess.php on line 11

Details:

The form with the file input tag newattachment is included such as:

error_reporting(E_ALL);
if ($action == 'first_time') {
<bunch of mysql processing, etc. snipped>

 include("form_add_item.php"); // Which includes: <input name="newattachment" type="file" size="40"> and <input type=submit name="add_another" value="Add Another">

}

then I come through a second time, array in tow:

if (isset($add_another)) {

$targetpath = "/users/ttspike/public_html/deluxe/learnphp/attachments/";

echo ("attachment data ".$FILES['newattachment']." ".$FILES['newattachment']['name']."<br>"); // Which produces: attachment data Array sticker_copper_only_2x3.jpg

$attacharray = $FILES['newattachment'];
$attachname = $FILES['newattachment']['name'];

upload_attachment($attacharray, $attachname, $targetpath);
}

I also tried with, no surprise, the same results:

upload_attachment($FILES['newattachment'], $FILES['newattachment']['name'], $targetpath);

the function:

function upload_attachment($userfile, $filename, $target) {
if (file_exists($userfile)){...
}

I get a pause as if the file is uploading but then:

Warning: Array to string conversion in /nfs/users/ttspike/public_html/deluxe/learnphp/newprocess.php on line 11

Line 11 is "if (file_exists($userfile)) {", and no file appears in the server directory.

I've attached the full script if you care to peek.

Thank you for your time, patience and altruism.

siwis

See this is where I can't get my head round some employed methods (and it's not just you I refer to) but you've uploaded a complete script and yet the functions don't work? So now, because you've got so much additional baggage in your coding its gonna be really hard to analyze exactly what is going wrong.

If you follow my regime, I create a raw file which contains the basic actions that the script is going to take. I place simple echo's into each section and test that those various states work correctly.

I then, one at a time begin to construct the subset actions that take place within each script state, only moving onto the next script state once I know that the previous one works exactly as planned. I even strip out that coding into a temporary file such that it doesn't get in the way of coding the next state if at all possible.

So here's my suggestion.
Code yourself a single 2 state page. one which requests the upload file, and one which processes it. When and only when you have that portion working do you then drop the remainder of your nicities in.

I'll have a look at your script, but I can make no promises. If necessary, I'll upload exactly what I created and which worked on my server on the second attempt.

spriggig

Don't bother with what I sent, I'll strip it down to the bone and post again. Sorry for the mess.

spriggig

Ok, I stripped it down to what I think is the bare essentials, no attachment this time, it's all here. I get the same error from this code as the previous attached zip, that is: "Warning: Array to string conversion in /nfs/users/ttspike/public_html/deluxe/learnphp/newprocess.php on line 5"

I'd appreciate it if you could take a look whenever you have time. Thank you again.

<<newprocess.php begin>>

<?php
error_reporting(E_ALL);
//FUNCTION
function upload_attachment($userfile, $filename, $target) {
if (file_exists($userfile)) {
$file_size = filesize($userfile);

$new_file_name = $currentuserID."".$currenttracking."".$userfile_name.".".$ext;
copy($userfile, $target . $new_file_name); // <- Save our original to disk
} else {
echo("no good");
}
}

include("form_add_item.php");

if (isset($add_another)) {

$targetpath = "/users/ttspike/public_html/deluxe/learnphp/attachments/";
echo ("attachment data ".$_FILES['newattachment']." ".$_FILES['newattachment']['name']."<br>");
upload_attachment($_FILES['newattachment'], $_FILES['newattachment']['name'], $targetpath);

include("form_add_item.php");

exit;
}
?>

<<newprocess.php end>>

<<form_add_item.php begin>>

<<form_add_item.php end>>

siwis

Your current function:

function upload_attachment($userfile, $filename, $target) {
if (file_exists($userfile)) {
				echo("hello from inside if file exists<br>");	
   				 $file_size = filesize($userfile);  

				 if ($file_size >= 3200000)  {  

			   		error("Maximum file size is 3.0 MB, please reduce file size and try again, or contact Darrin.");
					 }
		$goodtype = "N";		
		 if ($userfile_type == "image/pjpeg") { 
			  $ext ="jpg"; 
  			$goodtype = "Y";
			}
		 if ($userfile_type == "image/gif") { 
			$ext ="gif"; 
			$goodtype = "Y";
    	}	
  	 if ($userfile_type == "application/pdf") { 
			$ext ="pdf"; 
			$goodtype = "Y";
			}	
		 if ($userfile_type == "application/msword") { 
			$ext ="doc"; 
			$goodtype = "Y";
			}	
		if ($goodtype == "Y") { 	
				$new_file_name = $currentuserID."_".$currenttracking."_".$userfile_name.".".$ext;
				$insertfilename = "INSERT INTO items SET
										i_file_attachment = '$new_file_name'";
					    if (!mysql_query($insertfilename)) {
    	    				error("After Insert File Name, a database error occurred in processing your ".
    	        				  "submission.\\nIf this error persists, please ".
    	        				  "contact darrin.");
        				}
        		copy($userfile, $target . $new_file_name);        // <- Save our original to disk
			} else {
				error("$userfile_type is an unknown file type! \\nSorry, but we only accept Adobe Acrobat, Microsoft Word, \\nGIF Image and JPG Image file formats.");
			}
					echo "<P>Good Upload!</a>";	
	}
}

First things first. I previously stated that you could not use a variable inside a function unless that variable value is fed into the function when it is called.
Immediately, you have 2 such variables used inside your function:
$currentuserID & $currenttracking
These need to be fed into the function at the point it is called.

Next, your sql seems a little strange.

Surely it should be:

$insertfilename = "INSERT INTO items (i_file_attachment) VALUES ('$new_file_name')";

Anyway, after a bit of messing about, I've rewritten your function:

function uploadattachment($userfile, $userfile_type, $userfile_name, $target, $USER_ID, $CURRENT_TRACKING)	{
	if (isset($userfile))	{
			switch ($userfile_type)
			{
			case "image/pjpeg":
				$ext = "jpg";
				break;
			case "image/gif":
				$ext = "gif";
				break;
			case "application/pdf":
				$ext = "pdf";
				break;
			case "application/msword":
				$ext = "doc";
				break;
			default:
				$ext = "";
			}	// END of switch ($userfile_type)
			if (($ext == "jpg") || ($ext == "gif") || ($ext == "pdf") || ($ext == "doc")) {
				$new_file_name = $USER_ID."_".$CURRENT_TRACKING."_".$userfile_name;
				$insertfilename = "INSERT INTO items (i_file_attachment) VALUES ('$new_file_name')";
//				echo $new_file_name;
//				echo $insertfilename;
					if (!mysql_query($insertfilename)) {
						error("After Insert File Name, a database error occurred in processing your ".
						"submission.\\nIf this error persists, please ".
						"contact darrin.");
					}	else	{
		       		copy($userfile, $target . $new_file_name);        // <- Save our original to disk
					unlink($userfile);
					};	// END of if (!mysql_query($insertfilename))
			}	else	{
				error("$userfile_type is an unknown file type! \\nSorry, but we only accept Adobe Acrobat, Microsoft Word, \\nGIF Image and JPG Image file formats.");
			};	// END of if (($ext == "jpg") || ($ext == "gif") || ($ext == "pdf") || ($ext == "doc"))
	}	else	{
	echo "No File Specified";
	};	//	END of if (file_exists($userfile))
}	// END of function uploadattachment()

ENSURE THAT YOU ADD THE ADDITINAL VARIABLES INTO YOUR FUNCTION CALL.
THIS HAS BEEN TESTED AND IT DOES WORK (Well it does on my server anyway.)
I've left in a couple of echos I used while testing!

siwis

Sorry to keep coming back on this, but my server runs with register_globals = on so I'd commented out a few lines in my test code.
As soon as I uncomment the line $fileupload = $_FILES['fileupload']; it chokes with a very similar message to that which you received.

Anyway, if you want to see the dummy script I created it is attached.

spriggig

I don't have time right now to try it out, but about the SQL:

$sql = "INSERT INTO orders SET
i_file_attachment = '$new_file_name'";

as opposed to:

$insertfilename = "INSERT INTO items (i_file_attachment) VALUES ('$new_file_name')";

I've come across it both ways, and both work just fine on my server. The way I've chosen seems much easier to read. Is there any reason I shouldn't code it that way?

I don't recall what version of SQL my ISP is running but I do remember it was one of the latest versions, when I checked.

Also, my server also has register_globals = on.

siwis

I'm willing to accept that your sql is correct, it was just the first time I'd seen it done that way :rolleyes:

Anyway, back to the task in hand.
If your server is running with Register_globals=on, then really there is no reason why the script shouldn't work. BUT and I say BUT, mine runs with =on and as I said before, as soon as I uncommented the line

$fileupload = $_FILES['fileupload'];

it spat the dummy out.

The beauty of register globals=on is that you don't really need to assign the uploaded file and data to variables, it is done automatically by php itself (although it could be argued that it makes for sounder code because you are not relying upon it being set to on! but of course if its your server and you have no intention of distributing your code then you should do what works for you!). This in turn means that there is no need for the above quoted line (hense it was commented out within my test script). Allowing php to assign the file array automatically to a variable "fileupload" (ie that was the name of my input tag) the script, and the modified function works perfectly. I get a document (of the filtered types) parked in the folder I specified. BUT as soon as the comments came out, it reported a very similar error to the one you received.

Anyway, leave register_golbals=on and uncomment your variable assignment line, and just see what happens then.

As it happens, there were other things which didn't quite add up within your original function. You'd placed checks to confirm filetype and size, and yet even if those checks were invoked, ie by a file failing the tests, there was nothing to stop the remainder of the function from executing.

If you take a look at the file I uploaded (the dummy script I used to test your function) you can see the processes I went through to get it to work.
Firstly, I created a very simple upload script that did nothing more than save it to a predetermined place on the filesystem after renaming it. function process_file()
Secondly, I Introduced the naming regime you wanted AND made the funtion check for compatabilty by a simple check on the file extension. function file_process()
Finally, I set the file type checking to use the mime header type, and introduced your sql routine.

All three functions have been tested and do work. So its up to you to get em to work for you.