T-STRING error

[hermzz]

im trying to set up a search engine for my site, but i keep getting an error: Parse error: parse error, unexpected T_STRING in C:\WINDOWS\Desktop\pagina\letras.com\search.php3 on line 4
ive set up my computer to be the server thats why its on the c drive, php and mysql function perfectly. the code is:

<?php
MYSQL_CONNECT("localhost","root","root");
MYSQL_SELECT_DB("letras");
mysql_query(SELECT * FROM letras WHERE autor = $_POST['name']);
if ($myrow = mysql_fetch_array($result)) {
echo "<table border=1>\n";
echo "<tr><td>Name</td><td>Position</td></tr>\n";
do {
printf("<tr><td>%s %s</td><td>%s</tr>\n", $myrow["autor"], $myrow["titulo"], $myrow["texto"]);
} while ($myrow = mysql_fetch_array($result));
echo "</table>\n";
} else {
echo "Sorry, no records were found!";
}
?>

[bladx]

You need to at least define $result:

$result = mysql_query(SELECT * FROM letras WHERE autor = $_POST['name']);

[mrmufin]

I'd write it like this:

<?php

$conn = mysql_connect("localhost","root","root");

// Make sure you connected:
if(!$conn) {
	exit("Can't get a database link.");
}

$db = mysql_select_db("letras", $conn);

// Make sure you made a database selection:
if(!$db) {
	exit("Can't select the database.");
}

// When you run the query, assign the result to handler AND it's gotta be wrapped in quotes inside the mysql_query statement.
//And don't ferget to keep stuff on the right side of the column / value part of the query quoted when searching CHAR columns:
$result = mysql_query("SELECT * FROM letras WHERE autor = \"" . $_POST['name'] . "\"");

// Make *sure* you got a result:
if(!$result || !mysql_num_rows($result)) {
	echo "Query returned no results.";
} else {
	// Start spitting out the table:
	echo "<table border=\"1\">";
	echo "<tr><td>Name</td><td>Position</td></tr>";
	// Since you're using an associative array, just request an associative array specifically:
	while($myrow = mysql_fetch_array($result, MYSQL_ASSOC)) {
		printf("<tr><td>%s %s<td><td>%s</td></tr>\n", $myrow['autor'], $myrow['titulo'], $myrow['texto']);
	}
	echo "</table>";
	// Free up the resources associated with the results:
	mysql_free_result($result);
}

[hermzz]

thanks a million, now it works.
you have no idea, how much you have helped me.
thanks again. 🙂