undefined variables, how can i fix it?

ShawnD

first off, my code DOES work. it just bugs me a little that i have errors

<?php


   if ($page == index)  

   include("index_tfc.inc"); 

   elseif ($page == admins)  

   include ("admins_tfc.inc"); 

   elseif ($page == banlist) 
   include("banlist_tfc.inc"); 

   elseif ($page == downloads) 
   include("downloads_tfc.inc"); 

   elseif ($page == screenshots) 
   include("screenshots_tfc.inc"); 

   elseif ($page == settings)
   include("settings_tfc.inc"); 
   ?>

if i assign a value to this variable it disables the ability to have a link to the pages like tfc.php?page=settings

Weedpacket

You're a victim of bad coding practice, and PHP's telling you so.

If you don't want to replace $page with $_GET['page'] everywhere, just start your script off with

$page=$_GET['page'];

Also, you should be testing
$page=='index', not $page==index.

And if you don't want people seeing your PHP source code, either rename your include files to have a file extension like ".inc.php" or reconfigure your server to handle ".inc" files the same way as ".php" ones.

jediosu

is your problem that the variable isn't set when you first go to the page? This was one thing I did... my index includes pages based on the links people click... when you first go to the page there is no value, so make a check if its set

<?php

if (isset($page)){

// If statements for the sideBar links
if ($page == ""){
	include("main.php");
	}
if ($page == "1"){
	include("1.php");
	}
if ($page == "2"){
	include("2.php");
	}

}
else {
include("main.php");
}
?>

That what you mean?

ShawnD

Originally posted by Weedpacket
You're a victim of bad coding practice, and PHP's telling you so.

If you don't want to replace $page with $_GET['page'] everywhere, just start your script off with
$page=$_GET['page'];
[/B]

lol yeah i'm a victim of my own stupidity 😃
what is that $_GET[page]; supposed to mean anyway?

i really wish they taught PHP in sk00l, they only teach us C++ and not very damn much of it i might add 🙁

Rayn

no no no... this is the easy way to get the error to STFU

error_reporting(7);

place that below <?php and it should work 🙂

ShawnD

rofl 🙂

MrAlaska

So what errors are you getting?

I think yer IfElses would be much pertier as a switch statement, btw:

switch($page){
    case 'index':
    	include("index_tfc.inc");
    	break;
    case 'admins':
    	include ("admins_tfc.inc");
    	break;
    case 'banlist':
    	include("banlist_tfc.inc");
    	break;
    case 'downloads':
    	include("downloads_tfc.inc");
    	break;
    case 'screenshots':
    	include ("screenshots_tfc.inc");
    	break;
    case 'settings':
    	include ("settings_tfc.inc");
    	break;
    default:
    	include ("default.php");
}

ShawnD

what is the difference between a switch and a ton of elseif statements? don't they both check "if" that case is true and if not, move on?

i'm not being fa-see-shus (i can't spell that word damn it 🙁)

Weedpacket

Originally posted by ShawnD

lol yeah i'm a victim of my own stupidity 😃
what is that $_GET[page]; supposed to mean anyway?

Well, it's in the manual...

i really wish they taught PHP in sk00l, they only teach us C++ and not ver11y damn much of it i might add 🙁

C++! Cripes, I remember sitting in classes that taught BASIC! And that was at a fairly advanced age. Not this newfangled VB thing either, but with LINE NUMBERS!

A seriously bratchny langauge that was, my Droogs...

ShawnD

um..... yeah ok sure....

well the C++ they teach us is very very weak, look at the first 100 pages of C++ for dummies and that is about how much we learn in a full semester of 3 classes per week (each class is 1 hour and 10 minutes i think)

MrAlaska

Originally posted by ShawnD
what is the difference between a switch and a ton of elseif statements? don't they both check "if" that case is true and if not, move on?

For one thing, switch statements are PERTIER! Just look at it, see how nice it looks?

It also makes it easier for someone else to debug the code. One glance and you can see the switch is on the same variable, instead of reading through each if statement to make sure you aren't missing anything.

Weedpacket

Originally posted by MrAlaska
For one thing, switch statements are PERTIER! Just look at it, see how nice it looks?

It also makes it easier for someone else to debug the code. One glance and you can see the switch is on the same variable, instead of reading through each if statement to make sure you aren't missing anything.

With a load of elseif statements there's no warning that the same thing will be tested again, so it's "get the value of $page and compare it to 'index'. Are they the same? No. Follow the else. Get the value of $page and compare it to 'admins'. Are they the same? No. Follow the else...."

With a switch statement the parser is able to build up a table of what things $page will be tested against in advance. When it comes time to run the switch, it only needs to fetch the value of $page once and go through this table to find a match.

In short, a switch statement is like a single if statement that can branch off in a lot of directions, instead of a series of if statements, with only two branches each, that might all have to be checked through.

How smart PHP is with this is open to question and experiment, but C compilers at least implement a switch table directly in machine code, which is a lot faster than the long series of tests and jumps that a series of if statements would produce.

ShawnD

are you saying that my page with all the if statements is causes wasted CPU usage?

MrAlaska

If the results on this page can be relied upon:
http://phpxpath.sourceforge.net/benchmark/phpBench.php
It appears that PHP has not, yet anyway, fully optimized the simplistic appeal of a switch statement (the performance increase was slight), but I expect they will in the future so I would have my code ready anyway.

While I was at that page, I noticed they found === is faster than ==. Whazzup with that? I guess it's time to hit the manual again.

Weedpacket

Originally posted by MrAlaska
While I was at that page, I noticed they found === is faster than ==. Whazzup with that? I guess it's time to hit the manual again.

I guess using === sidesteps all that "Type Juggling" code it would otherwise do to find tht eg. 57=='57'.

Me, I'm hitting the source code...

ShawnD

me....i'm hittin the tequila 😉

thanks for all your help 🙂