First script dead in the water

[Michael_J_Drost]

This is my first self built script. It is supposed to log ip's and date/time. Unfortunatly I get an error.

Here's the script:

<?php

$month = date("M");
$day = date("d");
$year = date("Y");
$time = ":".date("H").":".date("i").":".date("s");

$visos = $SERVER["HTTP_USER_AGENT"];
$visip = $SERVER["REMOTE_ADDR"]

//write to flat file
$data= $visip." - - ".$day."/".$month."/".$year.$time." - "$visos."\n";
$filename = "visitor.log";
$fp=fopen($filename, "a");
fwrite($fp, $data);
fclose($fp);

?>

Here's the error:

Parse error: parse error, unexpected T_VARIABLE in line 12

Can anyone tell me where I've gone wrong ?

Help will be very much appreciated !

Michael J. Drost

[mrmufin]

Well, you can start by replacing:

$visip = $_SERVER["REMOTE_ADDR"]

with

// end the line with a semi-colon:
$visip = $_SERVER["REMOTE_ADDR"];

Or, you can make the whole thang a bunch 'cleaner' (and faster) by creating your visitor data like this:

$data = $_SERVER['REMOTE_ADDR'] . '---' . date("d/M/Y:H:i:s") . '-' . $_SERVER['HTTP_USER_AGENT'] . "\n";

[Michael_J_Drost]

Ok, the semi-colon did well for my self-confidence.

I think I'll hide in fridge now and check out what happens with the light.

Oh, and thanks 🙂
Needless to say it works now.

Michael

[mrmufin]

Glad it's working for you...

[psy]

be thankful, parse errors are the best type 🙂 its usually over something stupid like a ;