Aaargh - why won't this work

[Ted_Haller]

Hi,

Can anyone please tell me why this won't work:

in file1.php
...
if( $logged_in )
echo "<script>top.details.location=\"booking.php?exporter=$exporter\"</script>";

then in booking.php...

...
if(strtoupper($exporter) == "XYZ")
doSomeThing

when booking.php loads I''m getting 'undefined variable exporter' errors.

thanks in advance

Ted

[malbera]

try

$_GET['exporter'];

[trooper]

Ted

The error message is showing up as you have not declared your variable $exporter.

W

Originally posted by Ted Haller
Hi,

Can anyone please tell me why this won't work:

in file1.php
...
if( $logged_in )
echo "<script>top.details.location=\"booking.php?exporter=$exporter\"</script>";


then in booking.php...

...
if(strtoupper($exporter) == "XYZ")
doSomeThing

when booking.php loads I''m getting 'undefined variable exporter' errors.

thanks in advance

Ted

[trooper]

Ted

The error message is showing up as you have not declared your variable $exporter.

What version of PHP are you running sounds like your running php 4.0.1+,
There are two ways of fixing this error.
1) Reduce the error reporting level in your php.ini file, or
2) Exokicitly delclare your variable at the top of the file

Personally i'd go for the second option as it allows the script to run on boxes that have register_globals on or off and is therefore more robust.

Originally posted by Ted Haller
Hi,

Can anyone please tell me why this won't work:

in file1.php
...
if( $logged_in )
echo "<script>top.details.location=\"booking.php?exporter=$exporter\"</script>";


then in booking.php...

...
if(strtoupper($exporter) == "XYZ")
doSomeThing

when booking.php loads I''m getting 'undefined variable exporter' errors.

thanks in advance

Ted

[Ted_Haller]

the situation is as follows:
I'm using php v 4.0.6

I've got 3 frames - frame1, frame2, frame3

there is a login form in frame 3
if the login is successful i want to change what is currently displayed in frame2 and load a new php file into frame3.

hence:
if($logged_in)
{
?>
<script>top.frame2.location="actionbar.php?exporter=<? echo $exporter ?>"</script>
<script>top.frame3.location="booking.php?exporter=<? echo $exporter ?>"<script>
<?
}

Using $_GET['exporter'] in booking.php also gives me the 'undefined variable exporter' warning.

What I have discovered is that '$exporter' only seems to be passed to one of the scripts. If I switch the two scripts above around, then booking.php is fine, but the incorrect info is displayed in actionbar.php ???

Any ideas - I'm due to give a demo in about an hour:-(

[chaostik]

Hi,

This is a stab in the dark and may or may not help: have you tried:

if( $logged_in ) 
echo "<script>top.details.location=\"booking.php?exporter=" . urlencode($exporter) . "\"</script>"; 

and

if(strtoupper(urldecode($exporter)) == "XYZ") 
doSomeThing 

It's just a thought because if you have any spaces or special characters it would not work properly without using the urlencode() function first.

All the best,

Louis Aslett

[Weedpacket]

Originally posted by Ted Haller
the situation is as follows:
I'm using php v 4.0.6

That being the case (your PHP version is < 4.1), $_GET['exporter'] won't work. Try $HTTP_GET_VARS['exporter'] instead.

Sorry this seems to have arrived after your demo was due...

[Ted_Haller]

Is there something I need set in the php.ini file because '$exporter = $HTTP_GET_VARS['exporter']; returns the following warning - 'undefined index exporter'

The info is not being sent to the new page via a form but rather as part of the URL using javascript.

Cheers

[Weedpacket]

Well, I cranked error reporting right up and tried sending it something in the URL:

error_reporting(E_ALL);
$exporter=$HTTP_GET_VARS['exporter'];

And it went fine. So...

Two things:

First the obvious: is the exporter variable really going into the URL?

Second, is this being done inside a function? If so, you'll need to declare

global $HTTP_GET_VARS;

before you can use it there.

And you can get a look at just what is and isn't defined in $HTTP_GET_VARS by using

print_r($HTTP_GET_VARS);

I wrote the wee file test.php

error_reporting(E_ALL);
print_r($HTTP_GET_VARS);
$exporter=$HTTP_GET_VARS['exporter'];
echo $exporter;

Tried

[url]http://..../test.php?exporter=stuff[/url]

And got

Array ( [exporter] => stuff ) stuff

exactly what I expected; and no errors. How does it go for you?

[Ted_Haller]

Hi,

problem solved :-)

I tried everything you suggested, Weedpacket, but without much success. $exporter was set and was going through. For some reason though, php seems to have a problem with having two of those javascripts one after the other.
i.e. - in the following sequence:
if($logged_in)
{
echo "<script>top.details.location=\"booking.php?exporter=$exporter\"</script>";
echo "<script>top.action_bar.location=\"actionbar.php?exporter=$exporter\"</script>";
}

booking.php in the 'details' frame was fine, BUT, actionbar.php in the 'action_bar' frame was not.

If I switched the two scripts around, then booking.php in the 'details' frame didn't work but, actionbar.php in the 'action_bar' frame did! Go figure!

To solve my problem, I've removed the first script and put it inside actionbar.php.

i.e. in login.php I've got...
if($logged_in)
echo "<script>top.action_bar.location=\"actionbar.php?exporter=$exporter\"</script>";

and inside actionbar.php, I've got...

if(!isset($action))
$action = "booking";

if($action == "exit")
...
elseif( $action == "weeks")
...
elseif($action == "booking")
{
echo "<script>parent.frames.details.location=\"booking.php?exporter=$exporter\"</script>";
...
}
else
...

And it works like a charm!

Thanks for all the help none the less. I learnt a lot from all the responses.

Cheers (oh, the demo, albeit late, went just fine ;-))

Cheers

[Weedpacket]

 echo "<script>top.details.location=\"booking.php?exporter=$exporter\"</script>";
echo "<script>top.action_bar.location=\"actionbar.php?exporter=$exporter\"</script>";

[/b]

Quietly bizarre...

I'd've tried

 echo "<script>top.details.location=\"booking.php?exporter=$exporter\";
 top.action_bar.location=\"actionbar.php?exporter=$exporter\";</script>";

And seen if that made a difference; I'd've also made very suspicious frowns at the generated HTML/Javascript source. But I'd probably have been reduced to waving dead chickens in the end...

But hey, as long as the demo worked (And please: Pay no attention to the man behind the curtain!, congratulations and I hope the outcome is favourable!