Confused PostgreSQL Query Question

LordShryku

Okay, here I go again pasting code to the guru's. For some reason, and I can't figure out why, this query won't display any results.

<html>
<head>
<title>Query by Company</title>
<?
if ($submit) {
?>
<META HTTP-EQUIV=Refresh CONTENT="86400">
<?
};
?>
</head>
<body bgcolor="#D5D5AB" text="#000000" link="#0000FF" vlink="#0000FF" alink="#0000FF">
<div align="left">
<h2 align="left"><img src="/vad/Avnet_LSC.jpg" width="222" height="72"></h2>
<h2 align="left"><u><strong><font size="5">Database Query</font></strong></u>
</h2>
</div>
<?
if (!$submit) {
?>
<form action="<? echo $_SERVER['PHP_SELF']; ?>" method="POST" name="query">
<table>
<tr>
<th align=right>Company:
<td><input name="company" type="text" size="10" maxlength="4">
<tr>
<td colspan=2 align=center>
<input type="submit" name="submit" value="Submit Query">
</table>
</form>
<?
}
else
{
$host = "172.16.30.45";
$user = "aaron";
$db = "vad";
$connection = pg_Connect("host=$host dbname=$db user=$user");
if (!$connection) {
die("Could not open connection to the database server");
}
$query = "SELECT * from shipper where company = '$company' order by invoice";
$result = pg_query($connection, $query) or die("Error in query:$query. " . pg_last_error($connection));
$rows = pg_num_rows($result);
if ($rows > 0)
{
?><table>
<table border=1>
<tr><th colspan=1><? echo $rows; ?> entries for <? echo $company; ?>
</td></th>
</table><?
for ($i=0; $i<$rows; $i++)
{
$row = pg_fetch_row($result);
?>
<table>
<table border=1>
<tr><th>Company</th><th>Invoice</th><th>Quantity</th><th>PC Charge</th><th>Month</th><th>Year</th><th>DB Serial Number</th></tr>
<tr><td><? echo $row[0]; ?></td><td><? echo $row[1]; ?></td><td><? echo $row[2]; ?></td><td><? echo $row[3]; ?></td><td><? echo $row[4]; ?></td><td><? echo $row[5]; ?></td><td><? echo $row[6]; ?></td></tr>
</table>
<?
}
}
else
{
?>
<font size="-1">No data available.</font>
<?
}
pg_close($connection);
}
?>
<p align="left"> </p>
<a href="index.htm">Return to Main Menu</a><br>
<p align="left"></p>
<a href="queryindex.htm">Return to Query Menu</a>
</body>
</html>

But when I have two inputs, it does. Like if I have a place for company and invoice in the form, and I change the query to $query = "SELECT * from shipper where company = '$company' and invoice = '$invoice' order by invoice"; it has absolutely no problems.

Any help is appreciated. Thanks!

ultraslacker

I don't think it's the query - try addign more debugging, echoing it in the php to execute it on psql.

Mega

you should code in a manner that seperates your html from your coding, and code a lot cleaner.

it doesn't put ppl off helping you for one thing, and it makes debugging a lot easier, because you can test it after each stage.

Thats a major pro of OOP

LordShryku

ultraslacker, thanks for the response, I'm gonna play with it.

Mega....that doesn't really help me here. I'm by no means a web programmer, and still new at this. Telling me to code "clean" means something different to everyone.

Mega

Originally posted by LordShryku
ultraslacker, thanks for the response, I'm gonna play with it.

Mega....that doesn't really help me here. I'm by no means a web programmer, and still new at this. Telling me to code "clean" means something different to everyone.

I'm giving you advice, if you look through posts where the code is seperated and semiclean to clean, they get a lot of attention and fast responses.

if people feel as if it is going to take tham a while to read thru it all and then ages to help, u will get fewer responses 🙂

and putting

 tags around the text is always a good start :)

ultraslacker

I agree with Mega - I had recommended in my post that you beautify your code before posting, but then took it out and sent you a private message - hey, you are using postgres, so you're alright in my book! 🙂

As I found your php difficult to skim, I can only imagine the headaches it must cause you to debug- have you ever though of using a templating system such as Smarty or Fast Templates? It means you don't have to clutter up your php with html! I use 'em all the time - they're schweeeet!

Mega

i wrote my own templating system in OOP and i always use it for every task I undertake.

i obviously don't expect n00bs to grasp it straight away, but by making them aware that it's there and it's what they should aim for never does any harm 🙂

for beginner programmers, I think a good method is to have all you variables above the html, and include the html from another file:

$this = 'hi';
$var = 'howdy';

echo <<<EOF
$var is another word for $this hmm said characters &$*"%"^!
EOF;

then use functions, possibly just going straight to functions couldn't be bad. then I prefer to use OOP in order to do templates:

$TEMP = new template;

class template{

var $morestuff = 'hmm said stuff';

function dotemplate(){

global $stuff;

require('./Skinsfile.php');

return Skin( $this );

}

}

then have Skinsfile.php:

function Skin( $obj ){
return <<<EOF
hmm said {$obj->stuff}
98387&^&"^%£*

{$obj->morestuff}
EOF;
}

🙂

LordShryku

Well, I'm still VERY new to this, so I'm doing this straight to a text editor. But I'm gonna take a look at this templating system,even though I'm still unsure of what it does 🙂)

Thanks you both for your help, I need it 🙂