Help with random image script.

nivlaC

Thanks to mrmuffin I got this script to work, except I now want to convert it into a random image script that can be used in image tags, but I don't know how. Can someone please help me?

<?php

function get_the_damn_image($pics) {

// image.php

$name = "nivlaC";

if($d = opendir("/home/puremadnezz/images/$name/")) {
	$pics = array();
		while(false != ($f = readdir($d))) {    
			if(eregi(".(jpg|png|gif)$", $f)) {
					$pics[] = $f;
			}
		}
	closedir($d);  
	$n = count($pics) - 1;

	srand(time());

	$r = rand(0, $n);

	echo "<img src=\"$pics[$r]\" border=\"0\">";

}

}

switch ($image){

case "image.gif":
get_the_damn_image($pics);
break;

}

?>

Thanks a lot!

nivlaC

I still can't figure it out. Anyone else? 🙁

mikesgt2

What exactly do you want?

nivlaC

I want to make it so it would work in image tags (<img src="...>).

mrmufin

First off, nivlaC...

There's a slight mistake in the while() statement which another user pointed out. The test should be

// note the !== instead of !=
while(false !== ($f = readdir($d))) {
	// yada yada yada..
}

Additionally, weird things tend to happen to posted PHP code which use regular expressions. I believe I hit on that yesterday. There should be a backslash immediately before the "." in the eregi() test:

if(eregi(".(jpg|png|gif)$", $f)) {
}

Last, but not least, when generating image tags, the src="" must be either relative to the httpd server root for your domain:

(src="/images/somepic.jpg")

or relative to the document trying to load the image:

(src="images/somepic.jpg")

Trying to load an image from the full image file path:
(src="/home/someuser/pics/nekkidbabe.jpg")

just will not work...

mrmufin

Oh, yeah...

it's always best to close directories after they've been opened successfully. Stick a

closedir($d);

down towards the bottom of the

if($d = opendir(...))

conditional... D'OH!

nivlaC

Thank you, but I'm still having problems calling the script in an html image tag. It always appears as a broken image. Any idea on how to fix that?

mrmufin

I'm not sure what you mean by 'calling the script in an html image tag'...

So, as far as how to fix that... Well, based on what you originally needed, I kindly suggest that it's not (very) broken.

You wanted a utility which would list all of the images of types .jpg, .gif or *.png within a directory, which it accomplishes.

Then you wanted a random image selected from that list, which it also does.

Perhaps if we take a few steps backwards and try some simple tests, like:

Select an image from the directory '/home/puremadnezz/images/' and 'manually' create the image tag within your script. This will verify that the webserver can use images from that directory within pages...

See if that works; if it does, post the <img /> tag that you're 'manually' writing into your script, and we'll take it from there...

nivlaC

I don't know how to manually create the image in my script, sorry.

mrmufin

Yes you do! Your modifications to the image utility prove it! Something like:

echo '<img src="images/babe.jpg" border="0" />';

Where the stuff specified by the src="" part of the image tag corresponds to an image which exists in the directory "/home/puremadnezz/images/" (since that's where your function is deriving it's list of images from...)

nivlaC

So, I guess it does work in the broswer.

There are two images in the directory and it picks a random one each time I refresh it.

But when I use it in the image tag, it shows a broken image because the image.php?image=image.gif is HTML. When I view the source, it shows the image tag code.

edwardsbc

What you are really after is a PHP page that returns an "image" instead of HTML. This is possible, and I saw posts on the old version of this forum on how to do it.

If I remember correctly, you must manually return a header with the proper mime-type (image/jpg???) and then "send" the actual image file as if it were an ftp download to the users browser.

Sorry I don't have an example, but this should get you on the right track.

mrmufin

Originally posted by edwardsbc

If I remember correctly, you must manually return a header with the proper mime-type (image/jpg???) and then "send" the actual image file as if it were an ftp download to the users browser.

Which is about where we were with this little widget yesterday around this time... Sorta like this:

header("Content-Type: image/jpeg");
header("Location: " . $some_image);

where $some_image referenced an image in a directory somewhere... Until nivlaC decided to use the script in question to generate an image tag, rather than just 'sending the image' with a new header.

And now I'm not sure exactly what he's trying to do with the script. But dammit, it was working fine yesterday!

Hey, man, I got a red guitar, too!

edwardsbc

Yeah, got a Cherry Fireburst Les Paul Custom (2002) and a Wine colored 1978 American Stratocaster. I'm a real hack with the guitar, but I love having good tools! 😃

nivlaC

Thank you, mrmuffin. I finally got it to work.

<?php

function get_the_damn_image($pics) {

// image.php

$name = "nivlaC";

if($d = opendir("/home/puremadnezz/images/$name/")) {
	$pics = array();
		while(false !== ($f = readdir($d))) {    
			if(eregi("\.(jpg|png|gif)$", $f)) {
					$pics[] = $f;
			}
		}
	closedir($d);
	$n = count($pics) - 1;

	srand(time());

	$r = rand(0, $n);

	header("Content-Type: image/jpeg");
	header("Location: " . $pics[$r]);

}

}

switch ($image){

case "image.gif":
get_the_damn_image($pics);
break;

}

?>

🙂

mrmufin

Originally posted by edwardsbc
Yeah, got a Cherry Fireburst Les Paul Custom (2002) and a Wine colored 1978 American Stratocaster. I'm a real hack with the guitar, but I love having good tools! 😃

And straying even further off topic, my red guitar is a '91 American Strat plus. I also have an absolutely succulent Martin CE-something-or-other acoustic. (I suck at at model numbers, and don't really give a rat's wrinkled posterior about 'em, as long as the damn thing feels good in my hands and doesn't sound like it was made in a toy factory.)

nivlaC

Well, not really.

I'm using it for my sig on my site's forums and it only changes when I make a post. I want it to change every time the page is loaded... 🙁

mrmufin

Cool! nivlaC made the damn thing work! I'm outta here. Off to be with the very lovely 'msmufin'... And, boys, she is very lovely, indeed...

Have fun, nivlaC. I'm just so delighted to be of assistance...

nivlaC

Yup, I guess I did fix it. 🙂

Thanks for all your help!