does this code work?

ShawnD

you guys helped me make a mailer thing before and it did indeed work. i did some editting with it to try and make a template but it didn't work so i changed it back to the way it was (or tried). i can't send mail with it anymore but then to check if the SMTP server was the problem, i used my ISP given email account and sent an email to my hotmail account and it worked... here is the code:

<div align="center">
  <form action="<?php echo $PHP_SELF; ?>" method="POST">
  <table width="650" cellspacing="1">
    <tr>
      <td>
      who shall i email?
      </td>
      <td>
      <input type="text" name="name" value="<?php echo $HTTP_POST_VARS['name']; ?>">
      </td>
    </tr>
    <tr>
      <td>
        what is the title?
      </td>
      <td>
        <input type="text" name="title" value="<?php echo $HTTP_POST_VARS['title']; ?>">
      </td>
    </tr>
    <tr>
      <td>
        what is the message?
      </td>
      <td valign="top">
        <textarea rows="30" cols="30" name="message"><?php echo $HTTP_POST_VARS['message']; ?></textarea>
      </td>
    </tr>
    <tr>
      <td>
      </td>
      <td>
        <input type="submit" name="submit" value="email now">
      </td>
    </tr>
    </form>
</div>
<?php

if ($HTTP_POST_VARS['name'] != '0') {
mail($HTTP_POST_VARS['name'], $HTTP_POST_VARS['title'], $HTTP_POST_VARS['message']);
}
?>

did i screw up the code somehow? i can't see where 🙁

thefury

<div align="center">
  <form action="<?=$PHP_SELF?>" method="POST">
  <table width="650" cellspacing="1">
    <tr>
      <td>
      who shall i email?
      </td>
      <td>
      <input type="text" name="name" value="<?=$HTTP_POST_VARS['name']?>">
      </td>
    </tr>
    <tr>
      <td>
        what is the title?
      </td>
      <td>
        <input type="text" name="title" value="<?=$HTTP_POST_VARS['title']?>">
      </td>
    </tr>
    <tr>
      <td>
        what is the message?
      </td>
      <td valign="top">
        <textarea rows="30" cols="30" name="message"><?=$HTTP_POST_VARS['message']></textarea>
      </td>
    </tr>
    <tr>
      <td>
      </td>
      <td>
        <input type="submit" name="submit" value="email now">
      </td>
    </tr>
    </form>
</div>
<?
if(!empty($HTTP_POST_VARS['name']) && !empty($HTTP_POST_VARS['title']) && !empty($HTTP_POST_VARS['message'])) {
	mail($HTTP_POST_VARS['name'], $HTTP_POST_VARS['title'], $HTTP_POST_VARS['message']);
}
?>

ShawnD

sorry but that code of yours has even more problems than the code i originaly had, here is what yours looks like:

thefury

Guess your server is ghetto.. Just copy and paste the last if stuff over the orig version of the code.

The <? and <?= are shortcuts.. Prob added to a newer version of php that you got.

ShawnD

i downloaded PHP on that webserver exactly 3 weeks ago. straight from php.net

thefury

Hmm so how did the <?php get in that script in that screen shot?

Has to be <?=$var?>

http://www.php.net/manual/en/function.echo.php

ShawnD

it is, this is what the new file is exactly:

<html>
<head>
<title>mail test</title>
</head>

<body>


<div align="center">

  <form action="<?=$PHP_SELF?>" method="POST">

  <table width="650" cellspacing="1">

<tr>

  <td>

  who shall i email?

  </td>

  <td>

  <input type="text" name="name" value="<?=$HTTP_POST_VARS['name']?>">

  </td>

</tr>

<tr>

  <td>

    what is the title?

  </td>

  <td>

    <input type="text" name="title" value="<?=$HTTP_POST_VARS['title']?>">

  </td>

</tr>

<tr>

  <td>

    what is the message?

  </td>

  <td valign="top">

    <textarea rows="30" cols="30" name="message"><?=$HTTP_POST_VARS['message']></textarea>

  </td>

</tr>

<tr>

  <td>

  </td>

  <td>

    <input type="submit" name="submit" value="email now">

  </td>

</tr>

</form>

</div>

<?

if(!empty($HTTP_POST_VARS['name']) && !empty($HTTP_POST_VARS['title']) && !empty($HTTP_POST_VARS['message'])) {

mail($HTTP_POST_VARS['name'], $HTTP_POST_VARS['title'], $HTTP_POST_VARS['message']);

}

?>
</body>
</html>

btw i think there is a missing ? after $HTTP_PST_VARS['message']
i added a ? there and it didn't work that way either so i changed it back.

thefury

Use the code you posted.. and replace

if ($HTTP_POST_VARS['name'] != '0') {
mail($HTTP_POST_VARS['name'], $HTTP_POST_VARS['title'], $HTTP_POST_VARS['message']);
}

with

if(!empty($HTTP_POST_VARS['name']) && !empty($HTTP_POST_VARS['title']) && !empty($HTTP_POST_VARS['message'])) {
    mail($HTTP_POST_VARS['name'], $HTTP_POST_VARS['title'], $HTTP_POST_VARS['message']);
}

All that does is stop ppl from sending emails with empty content. The other stuff I changed was just to make it easier on the eye. Btw if your server's php is up to do, you should use $_POST and not $HTTP_POST_VARS 🙂.

ShawnD

but $HTTP_POST_VARS does actually work, it did work before i tampered with the file believe it or not

thefury

Ya php is backwards compatible

The only problem with your code is...

$HTTP_POST_VARS['name'] != '0'

All that does is check to see if name is the number 0.. I would guess you mean to see if its empty.

ShawnD

but wait, = checks for value but == checks for equality, if the name has no value, it will not send.

thefury

No = assigns a value.. == Checks for equality.

$var = 'yes';

if($var = 'noo') <-- Makes "$var" the value of "noo"

if($var == 'yes') <-- True

if($var != 'yes') <-- False

Weedpacket

Y'know, I can't help but look at all the pretty colours...

<textarea rows="30" cols="30" name="message"><?=$HTTP_POST_VARS['message']></textarea>

That missing '?' definitely should be there. Otherwise PHP won't know to drop out of PHP-parsing mode and back into raw HTML mode.

If your config has short_tags turned off, then "<?" and "<?=" won't work, and "<?php" and "<?php echo" have to be used instead. "<?php =" is a parse error and "<?php=" isn't even recognised as a PHP start tag - which is why it's appearing in your screenshot.

thefury

Yah saw that.. Wrote it up quick. But all the <?php= in the image dont make sence..

Weedpacket

Originally posted by thefury
Yah saw that.. Wrote it up quick. But all the <?php= in the image dont make sence..

Reckon your post and my edit passed each other in the early-morning fog...

ShawnD

yer pretty smart there weed, where did you learn PHP?