are my code correct?

[dewed-x]

Ive tried hole week to get this code correct......I sick of that please help me what have I done wrong (its my questbook).
The information dont want to put itself in the database only the id and the date does it:

<?php
$dbcnx = @mysql_connect ("localhost", "root", "sucker");
if (!$dbcnx)
{
echo ("NO");
exit();
}
?>
<form action="<?php echo($php_self); ?>" method=post>
name:
<input type="text" name="namn" cols="10">
mail:
<input name="hotmail" cols="10">
comments:
<textarea cols="30" rows="7" name="ovrigt">
</textarea>
<input type="submit" value="ok" name="ok">
<input type="reset" value="Återställ">
</form>

<?php
mysql_select_db("gastbok") or die (mysql_error());
{
$sql = "INSERT INTO information SET " .
"namn = '$namn'," .
"hotmail = '$hotmail', " .
"ovrigakommentarer = 'ovrigt', " .
"datum = CURDATE()";
}
mysql_query($sql) or die (mysql_error());
?>

[eoghain]

Change your insert statement to this:

INSERT INTO information (namn, hotmail, orvigakommentarer, datum)
VALUES ('$namn', '$hotmail', 'ovrigt', CURDATE());

[dewed-x]

Originally posted by eoghain
Change your insert statement to this:

INSERT INTO information (namn, hotmail, orvigakommentarer, datum)
VALUES ('$namn', '$hotmail', 'ovrigt', CURDATE());

<b><u>
Its not working!!</b></u>

[dewed-x]

The information is confirmed in the id and the datum but not my text in my other inputs... its just blank

[eoghain]

Well I don't see anything else wrong with your code.

Can you run the insert statement from within the mysql shell?

You should either be getting all of your data or no data. Queries do not fail partially. You should put in an echo $sql; string just before your mysql_query() call so you can be sure of what the query is that you are running.

[dewed-x]

okay ive done that and it stands:

INSERT INTO information (namn, hotmail, ovrigakommentarer, datum) VALUES ('', '', '', CURDATE())

There is like no values and why please help me!
Ive written in values so dont ask me that question plz

[bernouli]

did you forget the $ in front of ovrigt

<?php
mysql_select_db("gastbok") or die (mysql_error());
{
$sql = "INSERT INTO information SET " .
"namn = '$namn'," .
"hotmail = '$hotmail', " .
"ovrigakommentarer = '$ovrigt', " .
"datum = CURDATE()";
}
mysql_query($sql) or die (mysql_error());
?>

[eoghain]

Is this an old script that you are using on a newer install of PHP?

The newer version of PHP don't automatically convert GET and POST variables into $name variables. The newer versions leave the variables inside wrapper arrays $POST and $GET. Why don't you try this:

<?php 
mysql_select_db("gastbok") or die (mysql_error()); 
{ 
$sql = "INSERT INTO information SET " . 
"namn = '" . $_POST[namn] . "'," . 
"hotmail = '" . $_POST[hotmail] . "', " . 
"ovrigakommentarer = '" $_POST[ovrigt] . "', " . 
"datum = CURDATE()"; 
} 
mysql_query($sql) or die (mysql_error()); 
?>

And it looks like bernouli was right and you original post didn't include the $ infront of ovrigt, so I thought it was just text you added to each record. Anyway in the future you should cut and paste your code directly instead of re-typing it. It'll prevent typos when posting that will delay finding the problems.

[dewed-x]

thx for that one " . $_POST[namn] . " is correct