which is considered 'better' for coding php?

[Nico]

$sql = "SELECT day FROM day";
	$result = mysql_query($sql, $connection)
		or die("Query failed.");

OR

   [code=php]$result = mysql_query("SELECT day FROM day", $connection)
                       or die("Query failed.");[/code]

each of course returns the same results, i'm just curious if anyone has a preference and why. Thanx

Nico

[Reaver]

Often wondered that myself ... the second instance IMO would be better as there's one less variable but I see people using the first way all the time.

[jayant]

Its about personal preferences. There isn't any The Correct Way 😉
I prefer having least number of variables.

[bormuff98]

When I initially learnt PHP (from a book) I used the first way. I have since changed to the second way as, as has been pointed out, there is one less variable and thats always a good thing IMHO.

[mrmufin]

While I'm generally opposed to creating variables unnecessarily, I tend to be partial to the former of Nico's examples, particularly when an application is in the design stages.

My reasoning is that should a query fail, I like to be able to return the query, as well as any error message returned from MySQL. Ex:

$query = "SELECT foo, bar, baz FROM table WHERE baz='{$_POST['baz']}'";
$result = mysql_query($query, $conn);
if(!$result) {
	exit("Query $query failed: " . mysql_error());
}

I find that this greatly helps debugging, especially early in application design, or when initially integrating new queries into an application.

Just my nickel's worth; whatever works for you is cool...

[weekender]

i prefer the first - i hate having to scroll horizontally or having code split between lines, so i always make the code as short as possible by using variables. i just think it's easier to understand, too

[frigidman]

Im for the first way. Sure its another variable... but you use the same one over and over, so its not like every query of say 2000 db actions is a new variable, its all still "$sql".

Plus, since I use a special db object that cleans up the code even further, I like using the $sql then the db obj call to do things in two really small lines of code.

[mikesgt2]

I used to use the second but now i have moved to the first. I think it is easier to understand.