odbc problem

frog

I have just been doing PHP for a week and have a problem with odbc. I get "Warning: Supplied argument is not a valid ODBC-Link resource" when using odbc_exec and odbc_close. I have looked for silly typos etc but script looks alright to me. Here it is:

<?php
/ Mark Beal
03/09/02
This script will retrive appropriate entries from the database
according to a search term specified in search_form.php
/

phpinfo();

function HTML_head() {

//Top of page html stuff

echo "
<html><head>
<title>Epic Software Library</title>
</head>
<body bgcolor=\"#FFFFFF\" topmargin=0 leftmargin=0>";

}

function HTML_foot() {

//Bottom of page html stuff

echo "
</body></html>";

}

function Database_Connect() {

//Connect to the database
$cnx = odbc_connect("EpicSoftwareLibrary","","");
if (!cnx) {
Error_handler( "Error in odbc_connect" , $cnx );
}
}

function Select_Row() {

//Send odbc query

$cur = odbc_exec($cnx,"SELECT Manufacturer FROM software" );
if (!$cur) {
	Error_handler( "Error in odbc_exec( no cursor returned ) " , $cnx );
}

}

function Error_handler( $msg, $cnx) {
echo "$msg \n";
odbc_close($cnx);
exit();
}

function Close_DB () {
odbc_close($cnx);
}

//Run the functions

HTML_head();
Database_Connect();
Select_Row();
Close_DB();
HTML_foot();

The script is unfinished, I want to get a successful db connection before I carry on.
Any help would be much appreciated.

edwardsbc

Silly Typo:

//Connect to the database 
$cnx = odbc_connect("EpicSoftwareLibrary","",""); 
if (!$cnx) {   ### Note the '$' added here!!!!!!
Error_handler( "Error in odbc_connect" , $cnx ); 
}

Now it will tell you if the connection fails.

frog

Thanx for pointing out my Silly Typo, couldn't see the wood for the trees.
However, I have changed the script and no error is thrown out when using odbc_connect .
I still get the same error message "Warning: Supplied argument is not a valid ODBC-Link resource" when I use odbc_exec and odbc_close .
Could it be something to do with my configuration?
I have downloaded and installed the latest MDAC version from Microsulk and am using php4. I am running on an NT platform.
Also, is there a way that I can display the value of $cnx and would this help any.
As you can see, frogs eyes are bulging with all this stuff🙂

edwardsbc

Suddenly the light came on for me!

What you need to do is have Database_Connect() return the value of $cnx

function Database_Connect() { 
  $cnx = odbc_connect("EpicSoftwareLibrary","",""); 
  if (!cnx) { 
    Error_handler( "Error in odbc_connect" , $cnx ); 
    } 
  return $cnx;
  }

And then pass that variable to the other functions

function Select_Row($cnx) { 
  $cur = odbc_exec($cnx,"SELECT Manufacturer FROM software" ); 
  if (!$cur) { 
    Error_handler( "Error in odbc_exec( no cursor returned ) " ,   $cnx ); 
    } 
  }

The reason you need to do this is that php variables have scope. Variables within functions have no meaning outside the function.

HTML_head(); 
$cnxhandle=Database_Connect(); 
Select_Row($cnxhandle); 
Close_DB($cnxhandle); 
HTML_foot();

frog

Ahhh!! Thanx dude!!! I'll have a go at this tomorrow as I am off home now.
I adapted the code from a script I found on the web which maybe was not such a good idea. That script had the references to $cnx within the same function. Doh!

frog

New error,

I get Warning: SQL error: , SQL state 00000 in SQLConnect in c:\program files\apache group\apache\htdocs\run_query.php on line 33
for the odbc_connect.
I think it may be something to do with the user parameter. Has this got to be set? If so how do Apache and odbc need to be configured in this respect.
I have tried using my login name for windows 2000 but this does not seem to work and I still get the same error