Making the code more condensed

[micmac]

Hi all,
Can anyone tell me a better way to write this php script?
Thanks,
micmac

<?
		  $stat_check = $myrow["status"]; //place right variable here 
if($stat_check == 'New'){
echo "<input type=radio name=status value=New checked> &nbsp;<b>NEW</b>&nbsp;&nbsp;"; 
echo "<input type=radio name=status value=Accepted> &nbsp;<b>PROCESSED</b>&nbsp;&nbsp;";
echo "<input type=radio name=status value=Pending> &nbsp;<b>PENDING</b>&nbsp;&nbsp;";
echo "<input type=radio name=status value=Denied> &nbsp;<b>DENIED</b>";
			  } else if($stat_check == 'Accepted'){
echo "<input type=radio name=status value=New> &nbsp;<b>NEW</b>&nbsp;&nbsp;"; 
echo "<input type=radio name=status value=Accepted checked> &nbsp;<b>PROCESSED</b>&nbsp;&nbsp;";
echo "<input type=radio name=status value=Pending> &nbsp;<b>PENDING</b>&nbsp;&nbsp;";
echo "<input type=radio name=status value=Denied> &nbsp;<b>DENIED</b>";
			  } else if($stat_check == 'Pending'){
echo "<input type=radio name=status value=New> &nbsp;<b>NEW</b>&nbsp;&nbsp;"; 
echo "<input type=radio name=status value=Accepted> &nbsp;<b>PROCESSED</b>&nbsp;&nbsp;";
echo "<input type=radio name=status value=Pending checked> &nbsp;<b>PENDING</b>&nbsp;&nbsp;";
echo "<input type=radio name=status value=Denied> &nbsp;<b>DENIED</b>";			
			  } else if($stat_check == 'Denied'){
echo "<input type=radio name=status value=New> &nbsp;<b>NEW</b>&nbsp;&nbsp;"; 
echo "<input type=radio name=status value=Accepted> &nbsp;<b>PROCESSED</b>&nbsp;&nbsp;";
echo "<input type=radio name=status value=Pending> &nbsp;<b>PENDING</b>&nbsp;&nbsp;";
echo "<input type=radio name=status value=Denied checked> &nbsp;<b>DENIED</b>";
}			
?>

[bav]

Use function to make radio button and put the values in an array
For instance,
$radio_array = array("Accepted","pending","Denied");

In function loop through these values.

It should work!!

[GBahle]

This should work. It only does when $stat_check is equal to the values of the radiobuttons, and not sth else. if it is, none of the buttons will be checked.

<?
$stat_check = "Pending";// $myrow["status"]; //place right variable here 

function printRadios($toPrint) {
	$returnValue = "";
	for ($i = 0; $i < sizeof($toPrint); $i++) {
		$returnValue .= "<input type=radio name=status value=".$toPrint[$i]."> &nbsp;<b>".$toPrint[$i]."</b>&nbsp;&nbsp;\n";
	}
	return $returnValue;
}				  

$completeButtons = printRadios(array("New", "Accepted", "Pending", "Denied"));		  

$completeButtons = str_replace("value=".$stat_check, "value=".$stat_check." checked", $completeButtons);

echo $completeButtons;  

?>

[MrAlaska]

I usually build a switch statement to give 'checked' a value, but putting the values in an array works out pretty slick 🙂

<?php
$stat_check = $myrow["status"]; 
$array=array('New', 'Accepted', 'Pending', 'Denied');
foreach($array as $val){
	echo "<input type='radio' name='status' value='$val'";
	if ($stat_check==$val) echo " checked";
	echo ">&nbsp;<b>";
	if ($val=='Accepted') $val='Processed';
	echo strtoupper($val)."</b>&nbsp;&nbsp;";
}
?>