Functions and loggin in...problems

[VooDooRT]

Ok, here we go....

I made a very VERY simple login for my site, and I used a function to check if the user is logged in or not, but even if I AM logged in, I get a message saying I'm not logged in.

Here is the code that goes in each file:

//Check to see if user has cookie set for login
pw_cookie($user_name, $usercook, $password, $passcook);

include("header.php");

//Check to make sure password and user name match mysql information
pw_check($pw_sql, $user_name, $result, $mypw);
if($mypw[password] == $password and $user_name != NULL ) {

And here are the functions this bit of code is calling:

//Password cookie set function
function pw_cookie($usercook, $passcook, $user_name, $password)
{
$user_name = $usercook;
$password = $passcook;

setcookie("usercook", $user_name);
setcookie("passcook", $password);
}
//Password check function
function pw_check($pw_sql, $user_name, $result, $mypw)
{
$pw_sql = "SELECT * FROM admin_info WHERE user_name = \"$user_name\"";
$result = @mysql_query($pw_sql);
$mypw = mysql_fetch_array($result);
}

Where am I going wrong? It's not checking to make sure I logged in correctly...either that, or something else is going on...

It works just fine when I put the code into the file, but when I call it as a function, it craps out...

[bernouli]

why do you use 4 variables since you need only 2?

function pw_cookie($usercook, $passcook, $user_name, $password)
{
$user_name = $usercook;
$password = $passcook;

try this

function pw_check($pw_sql, $user_name, $result, $mypw)
{
global $mypw;
$pw_sql = "SELECT * FROM admin_info WHERE user_name = \"$user_name\"";
$result = @mysql_query($pw_sql);
$mypw = mysql_fetch_array($result);
}

[VooDooRT]

LoL, cause I'm not very good, and I was trying to go through everything before I posted here....

What does the global do for me?

[bernouli]

you use keyword global, so that you can use the variable outside the function, without global, you can only use the variable only inside the function

[VooDooRT]

Global didn't work... I'm really lost now...

[VooDooRT]

Anyone?

[dalecosp]

<curious>

I'm quite a novice, and probably need to see
more of your code ... but, in looking at what is
here, the question arises, what value does the
function return, and how are you using it?

IOW, do you need:

return $result;

??

</curious>

dalecosp

[VooDooRT]

Basically, it's calling on a couple of cookies sent by the script to ensure the person is logged in. Every time I try to see if the person is logged in, it says they're not. So I'm guessing it's not checking the cookies correctly. I dunno.

Anyway, I'll probably just switch to a session login and hopefully I won't have this problem...

[VooDooRT]

Ok, I must be EXTREMLY new at this...but, I'm having problems calling this function to make sure someone is logged in.

function login ($user_name, $password) { 
    $pw_sql= "SELECT * FROM admin_info WHERE user_name = '$user_name'"; 
    $result= mysql_query($pw_sql) or die("Error in Query: $pw_sql. mySQL said " . mysql_error() . '.');
    $login = mysql_num_rows($result); 

if ($login != '0') { 
                session_register('user_name'); 
    session_register('password'); 
    return TRUE; 
} 

else { 
    session_unset(); 
    session_destroy(); 
    return FALSE; 
} 
} 

I want to call it in several files. What do I use to call it? And can it be in "if-else" statement?

This php is a whole new universe compared to Visual Basic programming...

Should I just use:

function login($user_name, $password);
//what I want the logged in user to see goes here

else
{
//what I want the NON-logged in user to see
}

[VooDooRT]

Sorry for my newbie questions, but this is the only way I can learn...by seeing something.

php.net's manual doesn't really go into depth on examples that I can use. They have WAY TOO general of examples...

[bernouli]

try this

<?php
//
//your codes before the function
//

$mypw="";

function pw_check($pw_sql, $user_name, $result, $mypw)
{
global $mypw;
$pw_sql = "SELECT * FROM admin_info WHERE user_name = \"$user_name\"";
$result = @mysql_query($pw_sql);
$mypw = mysql_fetch_array($result);
}

//
//you call the function somewhere


?>

[VooDooRT]

Would that work? The function is in a different file than the login. I use a "require" statement to include the function file.

[bernouli]

I think so, have you tried?

[VooDooRT]

tried it, and it doesn't work🙁

[bernouli]

how about a "return" in the function?

function pw_check($pw_sql, $user_name, $result, $mypw)
{
global $mypw;
$pw_sql = "SELECT * FROM admin_info WHERE user_name = \"$user_name\"";
$result = @mysql_query($pw_sql);
return $mypw = mysql_fetch_array($result);

}