file upload help

stickman

I know I'am getting this all wrong but can't work out why as am noob any help appreciated
have attached code

stickman

sorry should have said why..

The file isn't uploading.. the variable $mainpic isn't getting passed for some reason... I've been reading other posts and trying to work it out for about 3 hours. can some one help please

bav

could you post it within the post as supposed to attachment.

stickman

ok but it's pretty long

<html>
<head>
<title>Remax Property</title>
<base target="_self">
<script language="JavaScript">
<!--
function TrackCount(fieldObj,countFieldName,maxChars)
{
var countField = eval("fieldObj.form."+countFieldName);
var diff = maxChars - fieldObj.value.length;

// Need to check & enforce limit here also in case user pastes data
if (diff < 0)
{
fieldObj.value = fieldObj.value.substring(0,maxChars);
diff = maxChars - fieldObj.value.length;
}
countField.value = diff;
}

function LimitText(fieldObj,maxChars)
{
var result = true;
if (fieldObj.value.length >= maxChars)
result = false;

if (window.event)
window.event.returnValue = result;
return result;
}

function MM_openBrWindow(theURL,winName,features) { //v2.0
window.open(theURL,winName,features);
}

stickman

/note that these htmlspecialchars and nl2br are the built in functons of php language/
echo "<font color=\"red\" size=\"+2\">Thank you very much</font><br>";
echo "<table width=\"50%\" border=\"0\" align=\"center\" cellpadding=\"3\" cellspacing=\"5\"><tr>";
echo "<td width=\"30%\" valign=\"middle\" bgcolor=\"#CCCCCC\"> <div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Photo Delivery:</font></strong></div></td><td><table width=\"70%\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\"><tr><td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Hardcopy:</font></strong></td><td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$hardcopy</font></strong></td>";
echo "</tr><tr><td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Email:</font></strong></td><td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$email</font></strong></td></tr></table></td></tr><tr><td bgcolor=\"#CCCCCC\"><div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Headline:</font></strong></div></td>";
echo "<td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$headline</font></strong></td></tr><tr> <td bgcolor=\"#CCCCCC\"><div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Suburb:</font></strong></div></td><td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$suburb</font></strong></td></tr><tr>";
echo "<td bgcolor=\"#CCCCCC\"><div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Main Text:</font></strong></div></td> <td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$textarea</font></strong></td> </tr> <tr> <td bgcolor=\"#CCCCCC\"><div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Inspect:</font></strong></div></td>";
echo "<td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$inspect</font></strong></td></tr><tr><td bgcolor=\"#CCCCCC\"><div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Price:</font></strong></div></td><td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$price</font></strong></td></tr><tr>";
echo "<td bgcolor=\"#CCCCCC\"><div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Address:</font></strong></div></td> <td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$address<br>$address2 </font></strong></td> </tr> <tr> <td bgcolor=\"#CCCCCC\"><div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Contact:</font></strong></div></td>";
echo "<td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">$contact</font></strong></td> </tr> <tr> <td bgcolor=\"#CCCCCC\"><div align=\"center\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Main Pic:</font></strong></div></td><td><div align=\"center\"><img src=\"pics/$address1/$mainpic_name\" width=\"300\" height=\"250\"></div></td></tr></table>";

}
exit;
}

//end of if

stickman

echo "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"100%\"> <tr> <td valign=\"top\" align=\"center\"> <table border=\"0\" cellpadding=\"9\" cellspacing=\"0\" width=\"95%\"><tr> <td><BLOCKQUOTE> <br><table width=\"80%\" border=\"0\" align=\"center\" cellpadding=\"2\" cellspacing=\"2\"><tr> <td colspan=\"5\"><div align=\"center\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><strong><font color=\"#000066\" size=\"6\">REMAX";
echo "</font><font size=\"4\"><br>ADVERTISING PROFORMER </font><br>(SINGLE MODULE) <font color=\"#FF0000\">ALL FIELDS MUST BE COMPLETED</font></strong></font> <font color=\"#FF0000\" size=\"2\" face=\"Arial, Helvetica, sans-serif\"><strong><br></strong></font><hr></div></td></tr><tr><td height=\"54\" colspan=\"5\"> <table width=\"60%\" border=\"0\" align=\"center\" cellpadding=\"2\" cellspacing=\"3\"><tr><td width=\"30%\" bgcolor=\"#CCCCCC\"><strong><font color=\"#000000\" size=\"2\" face=\"Arial, Helvetica, sans-serif\">";
echo "One Photo ONLY:</font></strong></td><td width=\"40%\" bgcolor=\"#CCCCCC\"><strong><font color=\"#000000\" size=\"2\" face=\"Arial, Helvetica, sans-serif\">Hard Copy Photo</font></strong></td><td width=\"5%\"> <strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><select name=\"hardcopy\" id=\"hardcopy\"><option value=\"n/a\">n/a</option><option value=\"Yes\">Yes</option><option value=\"No\">No</option></select></font></strong></td></tr><tr><td> </td><td bgcolor=\"#CCCCCC\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Email Photo</font></strong></td><td><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><select name=\"email\" id=\"email\"><option value=\"n/a\">n/a</option><option value=\"Yes\">Yes</option><option value=\"No\">No</option></select>";
echo " </font></strong></td></tr></table></td></tr><tr><td colspan=\"5\"><table width=\"100%\" border=\"0\" align=\"center\" cellpadding=\"2\" cellspacing=\"2\"><tr bgcolor=\"#CCCCCC\"><td width=\"62%\" height=\"26\"><strong><font color=\"#000000\" size=\"2\" face=\"Arial, Helvetica, sans-serif\">Headline<font size=\"1\">(28 Characters Max)</font></font></strong></td><td width=\"42%\"><strong><font color=\"#000000\" size=\"2\" face=\"Arial, Helvetica, sans-serif\">Suburb<font size=\"1\">(14 Characters Max)</font></font></strong></td></tr><tr><td><input name=\"headline\" type=\"text\" id=\"headline\" size=\"28\" maxlength=\"28\"></td><td><input name=\"suburb\" type=\"text\" id=\"suburb\" size=\"14\" maxlength=\"14\"></td></tr><tr> <td height=\"26\" colspan=\"2\" bgcolor=\"#CCCCCC\"><strong><font size=\"2\" face=\"Arial, Helvetica, sans-serif\">Body Text <font size=\"1\">(330 Characters Max)</font></font></strong></td>";
echo "</tr><tr> <td colspan=\"2\"><div align=\"center\"><textarea name=\"textarea\" cols=\"66\" rows=\"6\" wrap=\"VIRTUAL\" id=\"textarea\" onkeypress=\"LimitText(this,330)\" onkeyup=\"TrackCount(this,'textcount',330)\"></textarea><br><br><font color=\"#FF0000\" size=\"1\"><i><strong>Characters remaining:.. </strong></i></font></font> <font color=\"#FF0000\" size=\"1\" face=\"Arial, Helvetica, sans-serif\"><strong> <input name=\"textcount\" type=\"text\" value=\"330\" size=\"3\" maxlength=\"3\"></strong></font></p></div></td></tr></table></td></tr><tr align=\"center\" valign=\"middle\"> <td width=\"15%\" height=\"26\" valign=\"top\" bgcolor=\"#FFFFFF\"> <table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\"><tr><td height=\"26\" bgcolor=\"#CCCCCC\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><strong>INSPECT:</strong></font></td></tr><tr> <td height=\"26\" bgcolor=\"#FFFFFF\"> </td></tr>";
echo "</table><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"> </font></td><td width=\"15%\" bgcolor=\"#FFFFFF\"> </td><td align=\"center\" valign=\"top\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><input name=\"inspect\" type=\"text\" id=\"inspect\" value=\"\" size=\"24\" maxlength=\"24\"></font></td><td width=\"15%\" align=\"center\" valign=\"top\" bgcolor=\"#FFFFFF\"> <table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\"><tr> <td height=\"26\" bgcolor=\"#CCCCCC\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><strong>PRICE:</strong></font></td>";
echo "</tr><tr> <td height=\"26\" bgcolor=\"#FFFFFF\"> </td></tr></table><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"> </font></td><td align=\"center\" valign=\"top\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><input name=\"price\" type=\"text\" id=\"price\" size=\"18\" maxlength=\"18\"></font></td></tr><tr align=\"center\" valign=\"middle\"><td valign=\"top\"><table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\"><tr> <td height=\"26\" bgcolor=\"#CCCCCC\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><strong>ADDRESS:</strong></font></td></tr><tr> <td height=\"26\" bgcolor=\"#FFFFFF\"> </td></tr>";
echo "</table></td><td> </td><td align=\"center\" valign=\"top\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"> <input name=\"address\" type=\"text\" id=\"address\" value=\"\" size=\"24\"><br><input name=\"address2\" type=\"text\" id=\"address2\" value=\"\" size=\"24\"></font></td><td align=\"center\" valign=\"top\" bgcolor=\"#FFFFFF\"> <table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\"><tr> <td height=\"26\" bgcolor=\"#CCCCCC\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"><strong>CONTACT:</strong></font></td>";
echo "</tr><tr> <td height=\"26\" bgcolor=\"#FFFFFF\"> </td></tr></table><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"> </font></td><td align=\"center\" valign=\"top\"><font size=\"2\" face=\"Arial, Helvetica, sans-serif\"> <textarea name=\"contact\" cols=\"18\" rows=\"2\" wrap=\"VIRTUAL\" id=\"contact\"></textarea></font></td></tr><tr> <td colspan=\"5\"><hr></td></tr><tr> <td colspan=\"5\"><div align=\"center\"><font color=\"#FF0000\" size=\"2\" face=\"Arial, Helvetica, sans-serif\"><strong>TO BE SUBMITTED TO SHIRLEY NOT LATER THAN 10AM TUESDAYS</strong></font></div></td>";
echo "</tr><tr> <td colspan=\"5\"><div align=\"center\"><table width=\"98%\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\"><tr align=\"left\" valign=\"middle\"> <td width=\"40%\" height=\"62\"><strong><font color=\"#000000\" size=\"3\" face=\"Arial, Helvetica, sans-serif\">Image File:</font></strong></td><td> <div align=\"left\"><p> <font face=\"Arial, Helvetica, sans-serif\"> <input name=\"mainpic\" type=\"file\" id=\"mainpic\" size=\"60\"></font></p> </div></td></tr></table></div></td></tr></table></BLOCKQUOTE><div align=\"center\"><center><p><font face=\"Arial, Helvetica, sans-serif\">";
echo "<input name=\"submit\" type=\"submit\" value=\"Upload\"></font> </p><p><font face=\"Arial, Helvetica, sans-serif\"> <input name=\"Button\" type=\"button\" value=\"Complete\"></font></p><p><font face=\"Arial, Helvetica, sans-serif\"><input type=\"reset\" name=\"reset\" value=\"reset\"></font></p></center></div><HR></td></tr></table></td></tr></table>";

?>
</form>

</body>
</html>

bav

have you checked out the article on this site, File uploads made easy?
Here's the link for it. I think that is done is much simpler way.

http://www.phpbuilder.com/columns/bealers20000904.php3

stickman

I appreciate the link but would really like to know why the way I have done it isn't working.