Maximum Execution Time

Phpdiot

I've a problem with a script which I've downloaded. It run well just then but when I've entered quite a number of record in my database, the script give me the fatal error call. This is snippet which is causing the error but I can't figure out how to optimize it.
Any help is greatly appreciated.


function ShowCategoryPath($cat) {

  global $category_separator;

  $parent_id = 1000;
  while($parent_id) {
    // read name and parent_id
    $query = "select * from category where category_id=$cat";
    $result = mysql_query($query);    

    $parent_id = mysql_result($result,0,'parent_id');
    $name = mysql_result($result,0,'name');

// write path
if(empty($path)) {
  $path = $name;
}
else {
  $path = $name . $category_separator . $path;    
}

// next looping
$cat = $parent_id;
  }
  return $path . " ";
}

I don't understand where the $path came from. Any idea?

dannys

If you want to alter the timelimit see http://www.php.net/manual/en/function.set-time-limit.php

The following will turn off the time limit and is useful for scripts where you know you're going to spend a lot of time interacting with an external server or a database.

set_time_limit (0);

Phpdiot

I would like to optimize the script. Is it possible? because on first run though whereby no data are being added yet, this snippet already slows down which I'm not sure why. I change every aspect I could on mysql_result to mysql_fetch_row, mysql_fetch_object, even the parent_id I try to change it to 20 or something lesser. Still to no avail. Is this code dieing?

killerbishop

Instead of SELECT'ing "*" try selecting only the fields you need. If you use an asterisk - all fields are returned. This will cause a tremendous burden on your script (and the database server) unnecessarily if all you need is the name.

Phpdiot

Actually that's just a milliseconds count difference. I've already tried that which still slows everything down. Anyway, got myself a recursive functions and it works in a FLASH!

hmm, thanks everyone.