Error in updating records

chinni_77

I'm trying to update multiple filelds of a table.when ever i try to update N submit, i get this error:"Dynamic SQL Error SQL error code = -104 Unexpected end of command "

Could somebody pls tell me why the error is occuring.Here is my script.

<?
//Database connection

   if (isset($HTTP_POST_VARS["btn_update"]))
    {
    reset($data);
    while (list($id, $rbs_data) = each($data))
       {
    if (!$rbs_data['enrolment']) $enrolment=0; else $enrolment=1;
    if (!$rbs_data['ciphering']) $ciphering=0; else $ciphering=1;

$update_sql =   "update TBL_RBS SET ".
                "RBS_RFPI = '{$rbs_data['rfpi']}', ".
                "RBS_IPADDRESS = '{$rbs_data['ip_address']}', ".
                "RBS_ENROLMENT = $enrolment, ".
                "RBS_CIPHERING = $ciphering, ".
                "RBS_MACADDRESS = '{$rbs_data['mac_address']}', ".
                "RBS_SUBNETMASK = '{$rbs_data['subnet_mask']}', ".
                "RBS_ROUTERIP = '{$rbs_data['router_ip']}', ".
                "RBS_TFTPSERVERIPADDRESS = '{$rbs_data['tftp_server']}', ".
                "RBS_TFTPFILENAME = '{$rbs_data['tftp_file']}' ".
                "where RBS_ID = {$rbs_data['id']}";

$update_results = ibase_query($update_sql);
  }
}

//Select statement
?>
<b>To delete records</b></p>
<form name="editRBS" action="<?=$HTTP_SERVER_VARS['PHP_SELF']?>" method="POST">
<table cellpadding="0" cellspacing="0" width="909">

<?php

while ($row = ibase_fetch_object($result_id)){
      $rfpi=$row->RBS_RFPI;
      $ciphering=$row->RBS_CIPHERING;
      $ipaddress=$row->RBS_IPADDRESS;
      $macaddress=$row->RBS_MACADDRESS;
      $subnetmask=$row->RBS_SUBNETMASK;
      $routerip=$row->RBS_ROUTERIP;
      $enrolment=$row->RBS_ENROLMENT;
      $tftpserver=$row->RBS_TFTPSERVERIPADDRESS;
      $tftpfile=$row->RBS_TFTPFILENAME;
?>

<tr style="margin:0; padding:0;" align="left" valign="top">
<td width="156" height="23">
<input type="text" name="data[<?=$row->RBS_ID?>][rfpi]" value="<?=$rfpi?>">
</td>
<td width="154" height="23">
<input type="text" name="data[<?=$row->RBS_ID?>][ip_address]" value="<?=$ipaddress?>">
</td>
<td width="69" height="23">
<input type="checkbox" name="data[<?=$row->RBS_ID?>][enrolment]" value="1" <? if ($enrolment==1)echo "checked";?>>
</td>
<td width="65" height="23">
<input type="checkbox" name="data[<?=$row->RBS_ID?>][ciphering]" value="1" <? if ($ciphering==1)echo "checked";?>>
</td>
All other fields follows.............................
</tr>
<?php

}
?>
</table>
<input type="submit" name="btn_update" value="Update">
&nbsp;&nbsp;
</form>
</body>
</html>

khaine

First things first did you check your input data. I have had more grief with user putting a single quote in an input field. check to see if the incomming data has one. It could be the cause of the problem.

Secondly you might need to surround the enrolment and ciphering variables with a single quote. As a space in this will cause the same problem.

$update_sql =   "update TBL_RBS SET ".
                    "RBS_RFPI = '{$rbs_data['rfpi']}', ".
                    "RBS_IPADDRESS = '{$rbs_data['ip_address']}', ".
                    "RBS_ENROLMENT = '$enrolment', ".
                    "RBS_CIPHERING = '$ciphering', ".
                    "RBS_MACADDRESS = '{$rbs_data['mac_address']}', ".
                    "RBS_SUBNETMASK = '{$rbs_data['subnet_mask']}', ".
                    "RBS_ROUTERIP = '{$rbs_data['router_ip']}', ".
                    "RBS_TFTPSERVERIPADDRESS = '{$rbs_data['tftp_server']}', ".
                    "RBS_TFTPFILENAME = '{$rbs_data['tftp_file']}' ".
                    "where RBS_ID = {$rbs_data['id']}";

Mark.

chinni_77

hello khaine,

It has'nt solved my problem.
Actually, I'm trying to delete and also update.
Delete is working fine and update is'nt.I only posted the code before which i'm using for update.

First, when i run the form, i.e which displays all the fileds from the table, I've seen the source code.With each of the form filed, i can see my id field value also.

And now, when i try to make some changes and submit the form, it gives me error and i notice the id field is empy.So, i think it is not identifying which row it has to update.

Do you have any ideas why??

Thank you

chinni_77

I fixed it