if... or elseif...?

[r3n]

I want to exicute two if case statements at the same time followed by an else. And i'm not sure of the correct way to do it...

I have:

<want to run this if...>(mysql_num_rows($validate_voter)>0) 
{
vars, querys, header etc;
}

And i want to run:

<should this be elseif or if?!?!>(!isset($_COOKIE["r3nPoll"]))
{
vars, querys, header etc;
}

And last but not least... the else.

[PhaZZed]

if this { } else { }

or

if this { } elseif { }

they are all basically the same, just try them and see what results you get.

[r3n]

if(mysql_num_rows($validate_voter)>0) 
{
$msg1 = 1; //msg1: 1=Cheater, 2=Not cheater
$msg2 = 2; //msg2: 1=Display, 2=Don't Display
header("Location: http:" . $filename . "?" . $php_query . "&pollreq=" . $poll_results_page . "&msg1=" . $msg1 .  "&msg2=" . $msg2 . "#poll");
}

if(!isset($_COOKIE["r3nPoll"]))
{
$msg1 = 1; //msg1: 1=Cheater, 2=Not cheater
$msg2 = 2; //msg2: 1=Display, 2=Don't Display
header("Location: http:" . $filename . "?" . $php_query . "&pollreq=" . $poll_results_page . "&msg1=" . $msg1 .  "&msg2=" . $msg2 . "#poll");
}
else
{
$msg1 = 2; //msg1: 1=Cheater, 2=Not cheater
$msg2 = 2; //msg2: 1=Display, 2=Don't Display
// Updates vote count number (adds 1)
mysql_query("update $poll_data set optionCount=optionCount +1 where pollID=$pollID and voteID=$voteID") or die (mysql_error());
// Updates vote count number TOTAL (adds 1)
mysql_query("update $poll_data set optionTotal=optionTotal +1 where pollID=$pollID") or die (mysql_error());
// Updates IP info for anti-cheat
mysql_query("insert $poll_log set votersIP='$REMOTE_ADDR', timestamp=now(), pollID=$pollID, voteID=$voteID") or die (mysql_error());

$cookie_value = 'Voted for option ' . $voteID; 
$cookie_expire_time = time() + 15768000; // valid for one year
$cookie_path = '/'; 
setcookie ('r3nPoll' , $cookie_value , $cookie_expire_time , $cookie_path); 

header("Location: http:" . $filename . "?" . $php_query . "&pollreq=" . $poll_results_page . "&msg1=" . $msg1 . "&msg2=" . $msg2 . "#poll");
}

This is basicaly what i have at the moment - but putting the ! before isset makes the script thing the user HAS a cookie when they dont.

I need a way to stop the script from doing this, without loosing the ! -- or even if theres a way to replace the ! with something else....

[PhaZZed]

i think you are confuzzed somewhere along the line!

I have to go home now :/ I hope someone else replies!

[r3n]

Well basicaly, adding the ! makes the script thing that there IS a cookie on that person's comp. If i take away the ! everything works fine 🙂 -- apart from the fact that the cookie isnt recognised

[Frag]

You mean you want to check both the values of num_rows>0 and the cookie value at the same time?

if(mysql_num_rows($validate_voter)>0 && !isset($_COOKIE["r3nPoll"]) )
      $msg1_=_1;_//msg1: 1=Cheater, 2=Not cheater
      $msg2_=_2;_//msg2: 1=Display, 2=Don't Display
      header("Location: http:"_._$filename_._"?"_._$php_query_._"&pollreq="_._$poll_results_page_._"&msg1="_._$msg1_.__"&msg2="_._$msg2_._"#poll");
}

_

Did some cut and paste hope that came out right.

Frag

[r3n]

Thanks for the reply. -- Wouldn't && make it add the two statements together? -- i need it to check one or the other....

[r3n]

ok, i tried your code -- it parsed ok 🙂 hehe - but... there is something realy wierd going on;
The exclamation mark (!) as you know is saying "if the value is TRUE" (please correct me if i'm wrong).
When its there, it kind of... ignores the cookie bit and denys the user. When the ! isnt there, it bypasses the if statement all together and makes a new cookie 🙁
Why is it doing this?

[siwis]

Nope, the ! actually means NO or NOT thus
!isset() means that if there is no variable set.

As such your existing code denies users if they haven't voted and allows users who have the cookie to vote (but as no-one can vote in the first place, this is basically nobody!

as for the "&&" it is the logical operator equivalent to AND

ie if this=that AND somethingelse=theother do this, else do that would be:

if (($a == $b) && ($c == $d)) {
//do this
} else {
//do that
};

[r3n]

i havent got time to test the code right now -- but is the logical operator for 'or' -- OR, if the logical operator for and is AND?
because i need it to do one OR the other -- not 1 AND the other 🙂

[MrAlaska]

Originally posted by r3n
i havent got time to test the code right now -- but is the logical operator for 'or' -- OR, if the logical operator for and is AND?
because i need it to do one OR the other -- not 1 AND the other 🙂

Yes, or the shorthand substitute for 'or' is two pipes ||
http://www.php.net/manual/en/language.operators.logical.php

EDIT: Actually, two pipes is NOT a true substitute for 'or' and && is not a true substitute for 'and'. I never noticed before, but && has a different precedence than 'and' and || has a different precedence than 'or'. Something to keep in mind, you never know when it might bite you...

[siwis]

In real terms, the && and || operators offer better results, assuming that you set your code correctly. In complex comparisons, you are far more likely to get spurious result using "and" or "or" than you are by uisng "&&" or "||". I use the C operators in all events with the exception of SQLs.

and Is true if both of its arguments are true
or Is true if either OR both of its arguments are true
! Is true if the single argument to its right is false, and false if the argument is true
xor Is true if either but NOT both of its arguments are true
&& Same as 'and' but binds to its arguments more tightly
|| Same as 'or' but binds to its arguments more tightly

[r3n]

Thanks for the help guys, but i still have some problems - hehe. Look at the code below:

<?

// Checks if this ip has voted before
$validate_voter = mysql_query("select votersIP from $poll_log where votersIP = '$REMOTE_ADDR' and pollID=$pollID") or DIE(mysql_error());
if ((mysql_num_rows($validate_voter)>0) || (isset($_COOKIE['r3nPoll' . $pollID])))
{
$msg1 = 1; //msg1: 1=Cheater, 2=Not cheater
$msg2 = 2; //msg2: 1=Display, 2=Don't Display
header("Location: http:" . $filename . "?" . $php_query . "&pollreq=" . $poll_results_page . "&msg1=" . $msg1 .  "&msg2=" . $msg2 . "#poll");
}

else
{
$msg1 = 2; //msg1: 1=Cheater, 2=Not cheater
$msg2 = 2; //msg2: 1=Display, 2=Don't Display
// Updates vote count number (adds 1)
mysql_query("update $poll_data set optionCount=optionCount +1 where pollID=$pollID and voteID=$voteID") or die (mysql_error());
// Updates vote count number TOTAL (adds 1)
mysql_query("update $poll_data set optionTotal=optionTotal +1 where pollID=$pollID") or die (mysql_error());
// Updates IP info for anti-cheat
//mysql_query("insert $poll_log set votersIP='$REMOTE_ADDR', timestamp=now(), pollID=$pollID, voteID=$voteID") or die (mysql_error());

$cookie_value = 'Voted for option ' . $voteID; 
$cookie_expire_time = time() + 3600 * 12 * 365;
$cookie_path = '/'; 
setcookie ('r3nPoll' . $pollID , $cookie_value , $cookie_expire_time , $cookie_path);

header("Location: http:" . $filename . "?" . $php_query . "&pollreq=" . $poll_results_page . "&msg1=" . $msg1 . "&msg2=" . $msg2 . "#poll");
}

?>

Can anybody see WHY the script isn't detecting the existing cookie and returning else (I have disabled the IP query whilst i'm working on the cookie bug, just incase anybody wondered 🙂)

[r3n]

<?
echo !isset($_COOKIE['r3nPoll' . 1]);
?>

Returns '1'

but

<?
echo isset($_COOKIE['r3nPoll' . 1]);
?>

Returns nothing

Just thaught i'd share that with you, hehe

btw: $pollID = 1

[r3n]

http://www.phpbuilder.com/board/showthread.php?s=&threadid=10210810

Ok, i moved the post here because the topic has strayed from the title 🙂